diff mbox series

arm64: dts: juno: drop unnecessary address-cells and size-cells properties

Message ID 1523286560-30889-1-git-send-email-sudeep.holla@arm.com
State Accepted
Commit c326599b29f0dac8d73147309ffd31cce2cfdc05
Headers show
Series arm64: dts: juno: drop unnecessary address-cells and size-cells properties | expand

Commit Message

Sudeep Holla April 9, 2018, 3:09 p.m. UTC
/smb@8000000/motherboard/gpio_keys node doesn't have "ranges" or "reg"
property in child nodes. So it's unnecessary to have address-cells
as well as size-cells properties which results in below warning.

Warning (avoid_unnecessary_addr_size):
/smb@8000000/motherboard/gpio_keys:
	unnecessary #address-cells/#size-cells without "ranges" or child "reg"
	property

This patch drops the unnecessary address+size-cell properties.

Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

---
 arch/arm64/boot/dts/arm/juno-motherboard.dtsi | 2 --
 1 file changed, 2 deletions(-)

(Missed cc-ed people earlier)

--
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Liviu Dudau April 10, 2018, 9:24 a.m. UTC | #1
On Mon, Apr 09, 2018 at 04:09:20PM +0100, Sudeep Holla wrote:
> /smb@8000000/motherboard/gpio_keys node doesn't have "ranges" or "reg"

> property in child nodes. So it's unnecessary to have address-cells

> as well as size-cells properties which results in below warning.

> 

> Warning (avoid_unnecessary_addr_size):

> /smb@8000000/motherboard/gpio_keys:

> 	unnecessary #address-cells/#size-cells without "ranges" or child "reg"

> 	property

> 

> This patch drops the unnecessary address+size-cell properties.

> 

> Cc: Liviu Dudau <liviu.dudau@arm.com>

> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>

> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>


Looks like the sensible thing to do!

Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>


Best regards,
Liviu

> ---

>  arch/arm64/boot/dts/arm/juno-motherboard.dtsi | 2 --

>  1 file changed, 2 deletions(-)

> 

> (Missed cc-ed people earlier)

> 

> diff --git a/arch/arm64/boot/dts/arm/juno-motherboard.dtsi b/arch/arm64/boot/dts/arm/juno-motherboard.dtsi

> index 2ac43221ddb6..69804c5f1197 100644

> --- a/arch/arm64/boot/dts/arm/juno-motherboard.dtsi

> +++ b/arch/arm64/boot/dts/arm/juno-motherboard.dtsi

> @@ -56,8 +56,6 @@

> 

>  			gpio_keys {

>  				compatible = "gpio-keys";

> -				#address-cells = <1>;

> -				#size-cells = <0>;

> 

>  				power-button {

>  					debounce_interval = <50>;

> --

> 2.7.4

> 


-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/arm/juno-motherboard.dtsi b/arch/arm64/boot/dts/arm/juno-motherboard.dtsi
index 2ac43221ddb6..69804c5f1197 100644
--- a/arch/arm64/boot/dts/arm/juno-motherboard.dtsi
+++ b/arch/arm64/boot/dts/arm/juno-motherboard.dtsi
@@ -56,8 +56,6 @@ 

 			gpio_keys {
 				compatible = "gpio-keys";
-				#address-cells = <1>;
-				#size-cells = <0>;

 				power-button {
 					debounce_interval = <50>;