[v1,15/24] tests/tcg/i368: fix hello-i386

Message ID 20180410193919.28026-16-alex.bennee@linaro.org
State New
Headers show
Series
  • fix building of tests/tcg
Related show

Commit Message

Alex Bennée April 10, 2018, 7:39 p.m.
This is a direct syscall test so needs additional CFLAGS and LDFLAGS.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
 tests/tcg/i386/Makefile.target | 6 ++++++
 1 file changed, 6 insertions(+)

-- 
2.16.2

Comments

Thomas Huth April 11, 2018, 3:38 p.m. | #1
On 10.04.2018 21:39, Alex Bennée wrote:
> This is a direct syscall test so needs additional CFLAGS and LDFLAGS.

> 

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> ---

>  tests/tcg/i386/Makefile.target | 6 ++++++

>  1 file changed, 6 insertions(+)

> 

> diff --git a/tests/tcg/i386/Makefile.target b/tests/tcg/i386/Makefile.target

> index 1df69e0dab..44803c0382 100644

> --- a/tests/tcg/i386/Makefile.target

> +++ b/tests/tcg/i386/Makefile.target

> @@ -9,6 +9,12 @@ CFLAGS+=$(CROSS_CC_GUEST_CFLAGS)

>  endif

>  endif

>  

> +#

> +# hello-i386 is a barebones app

> +#

> +hello-i386: CFLAGS+=-ffreestanding

> +hello-i386: LDFLAGS+=-nostdlib

> +

>  #

>  # test-386 includes a couple of additional objects that need to be linked together

>  #

> 


Reviewed-by: Thomas Huth <thuth@redhat.com>
Philippe Mathieu-Daudé April 16, 2018, 12:14 a.m. | #2
On 04/10/2018 04:39 PM, Alex Bennée wrote:
> This is a direct syscall test so needs additional CFLAGS and LDFLAGS.

> 

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>


Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


> ---

>  tests/tcg/i386/Makefile.target | 6 ++++++

>  1 file changed, 6 insertions(+)

> 

> diff --git a/tests/tcg/i386/Makefile.target b/tests/tcg/i386/Makefile.target

> index 1df69e0dab..44803c0382 100644

> --- a/tests/tcg/i386/Makefile.target

> +++ b/tests/tcg/i386/Makefile.target

> @@ -9,6 +9,12 @@ CFLAGS+=$(CROSS_CC_GUEST_CFLAGS)

>  endif

>  endif

>  

> +#

> +# hello-i386 is a barebones app

> +#

> +hello-i386: CFLAGS+=-ffreestanding

> +hello-i386: LDFLAGS+=-nostdlib

> +

>  #

>  # test-386 includes a couple of additional objects that need to be linked together

>  #

>

Patch

diff --git a/tests/tcg/i386/Makefile.target b/tests/tcg/i386/Makefile.target
index 1df69e0dab..44803c0382 100644
--- a/tests/tcg/i386/Makefile.target
+++ b/tests/tcg/i386/Makefile.target
@@ -9,6 +9,12 @@  CFLAGS+=$(CROSS_CC_GUEST_CFLAGS)
 endif
 endif
 
+#
+# hello-i386 is a barebones app
+#
+hello-i386: CFLAGS+=-ffreestanding
+hello-i386: LDFLAGS+=-nostdlib
+
 #
 # test-386 includes a couple of additional objects that need to be linked together
 #