[edk2,edk2-platforms,v2,2/6] Platform/ARM/Sgi: add NOR flash platform library implementation

Message ID 1523558863-5427-3-git-send-email-thomas.abraham@arm.com
State New
Headers show
Series
  • Untitled series #10616
Related show

Commit Message

Thomas Abraham April 12, 2018, 6:47 p.m.
From: Vishwanatha HG <vishwanatha.hg@arm.com>


Add a initial NOR flash driver platform wrapper as part of the platform
library. Access to NOR fash 0 is enabled in this initial implementation.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Vishwanatha HG <vishwanatha.hg@arm.com>

Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>

---
 Platform/ARM/SgiPkg/Library/NorFlashLib/NorFlash.c | 60 ++++++++++++++++++++++
 .../ARM/SgiPkg/Library/NorFlashLib/NorFlashLib.inf | 33 ++++++++++++
 2 files changed, 93 insertions(+)
 create mode 100644 Platform/ARM/SgiPkg/Library/NorFlashLib/NorFlash.c
 create mode 100644 Platform/ARM/SgiPkg/Library/NorFlashLib/NorFlashLib.inf

-- 
2.7.4

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Ard Biesheuvel April 16, 2018, 6:21 a.m. | #1
On 12 April 2018 at 20:47, Thomas Abraham <thomas.abraham@arm.com> wrote:
> From: Vishwanatha HG <vishwanatha.hg@arm.com>

>

> Add a initial NOR flash driver platform wrapper as part of the platform

> library. Access to NOR fash 0 is enabled in this initial implementation.

>

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Vishwanatha HG <vishwanatha.hg@arm.com>

> Signed-off-by: Thomas Abraham <thomas.abraham@arm.com>

> ---

>  Platform/ARM/SgiPkg/Library/NorFlashLib/NorFlash.c | 60 ++++++++++++++++++++++

>  .../ARM/SgiPkg/Library/NorFlashLib/NorFlashLib.inf | 33 ++++++++++++

>  2 files changed, 93 insertions(+)

>  create mode 100644 Platform/ARM/SgiPkg/Library/NorFlashLib/NorFlash.c

>  create mode 100644 Platform/ARM/SgiPkg/Library/NorFlashLib/NorFlashLib.inf

>

> diff --git a/Platform/ARM/SgiPkg/Library/NorFlashLib/NorFlash.c b/Platform/ARM/SgiPkg/Library/NorFlashLib/NorFlash.c

> new file mode 100644

> index 0000000..5d7efea

> --- /dev/null

> +++ b/Platform/ARM/SgiPkg/Library/NorFlashLib/NorFlash.c

> @@ -0,0 +1,60 @@

> +/** @file

> +

> +  Copyright (c) 2018, ARM Ltd. All rights reserved.

> +

> +  This program and the accompanying materials are licensed and made available

> +  under the terms and conditions of the BSD License which accompanies this

> +  distribution.  The full text of the license may be found at

> +  http://opensource.org/licenses/bsd-license.php

> +

> +  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,

> +  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.

> +

> + **/

> +

> +#include <PiDxe.h>

> +#include <Library/DebugLib.h>

> +#include <Library/IoLib.h>

> +#include <Library/NorFlashPlatformLib.h>

> +#include <SgiPlatform.h>

> +

> +STATIC NOR_FLASH_DESCRIPTION mNorFlashDevices[] = {

> +  {

> +    SGI_EXP_SMC_CS0_BASE,

> +    SGI_EXP_SMC_CS0_BASE,

> +    SIZE_256KB * 255,

> +    SIZE_256KB,

> +    {0xEBF0B9DF, 0x17d0, 0x4812, { 0xA9, 0x59, 0xCF, 0xD7, 0x92, 0xEE, 0x31, 0x13} }

> +  },

> +  {

> +    SGI_EXP_SMC_CS0_BASE,

> +    SGI_EXP_SMC_CS0_BASE + SIZE_256KB * 255,

> +    SIZE_64KB * 4,

> +    SIZE_64KB,

> +    {0x98C111C6, 0xB322, 0x4C33, { 0x95, 0xD5, 0xAF, 0x56, 0xAF, 0x90, 0x18, 0x6A } }

> +  },

> +};

> +

> +EFI_STATUS

> +NorFlashPlatformInitialization (

> +  VOID

> +  )

> +{

> +  return EFI_SUCCESS;

> +}

> +

> +EFI_STATUS

> +NorFlashPlatformGetDevices (

> +  OUT NOR_FLASH_DESCRIPTION   **NorFlashDevices,

> +  OUT UINT32                  *Count

> +  )

> +{

> +  if ((NorFlashDevices == NULL) || (Count == NULL)) {

> +    return EFI_INVALID_PARAMETER;

> +  }

> +

> +  *NorFlashDevices = mNorFlashDevices;

> +  *Count = sizeof (mNorFlashDevices) / sizeof (NOR_FLASH_DESCRIPTION);


Please use ARRAY_SIZE() here

> +

> +  return EFI_SUCCESS;

> +}

> diff --git a/Platform/ARM/SgiPkg/Library/NorFlashLib/NorFlashLib.inf b/Platform/ARM/SgiPkg/Library/NorFlashLib/NorFlashLib.inf

> new file mode 100644

> index 0000000..a860e5c

> --- /dev/null

> +++ b/Platform/ARM/SgiPkg/Library/NorFlashLib/NorFlashLib.inf

> @@ -0,0 +1,33 @@

> +#/** @file

> +#

> +#  Copyright (c) 2018, ARM Ltd. All rights reserved.

> +

> +#  This program and the accompanying materials are licensed and made available

> +#  under the terms and conditions of the BSD License which accompanies this

> +#  distribution.  The full text of the license may be found at

> +#  http://opensource.org/licenses/bsd-license.php

> +#

> +#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,

> +#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.

> +#

> +#**/

> +

> +[Defines]

> +  INF_VERSION                    = 0x00010005


0x0001001A

> +  BASE_NAME                      = NorFlashSgiLib

> +  FILE_GUID                      = 3f021755-6d74-4065-9ee4-98225267b36e

> +  MODULE_TYPE                    = DXE_DRIVER

> +  VERSION_STRING                 = 1.0

> +  LIBRARY_CLASS                  = NorFlashPlatformLib

> +

> +[Sources.common]

> +  NorFlash.c

> +

> +[Packages]

> +  MdePkg/MdePkg.dec

> +  ArmPlatformPkg/ArmPlatformPkg.dec

> +

> +[LibraryClasses]

> +  BaseLib

> +  DebugLib

> +  IoLib

> --

> 2.7.4

>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/Platform/ARM/SgiPkg/Library/NorFlashLib/NorFlash.c b/Platform/ARM/SgiPkg/Library/NorFlashLib/NorFlash.c
new file mode 100644
index 0000000..5d7efea
--- /dev/null
+++ b/Platform/ARM/SgiPkg/Library/NorFlashLib/NorFlash.c
@@ -0,0 +1,60 @@ 
+/** @file
+
+  Copyright (c) 2018, ARM Ltd. All rights reserved.
+
+  This program and the accompanying materials are licensed and made available
+  under the terms and conditions of the BSD License which accompanies this
+  distribution.  The full text of the license may be found at
+  http://opensource.org/licenses/bsd-license.php
+
+  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+
+ **/
+
+#include <PiDxe.h>
+#include <Library/DebugLib.h>
+#include <Library/IoLib.h>
+#include <Library/NorFlashPlatformLib.h>
+#include <SgiPlatform.h>
+
+STATIC NOR_FLASH_DESCRIPTION mNorFlashDevices[] = {
+  {
+    SGI_EXP_SMC_CS0_BASE,
+    SGI_EXP_SMC_CS0_BASE,
+    SIZE_256KB * 255,
+    SIZE_256KB,
+    {0xEBF0B9DF, 0x17d0, 0x4812, { 0xA9, 0x59, 0xCF, 0xD7, 0x92, 0xEE, 0x31, 0x13} }
+  },
+  {
+    SGI_EXP_SMC_CS0_BASE,
+    SGI_EXP_SMC_CS0_BASE + SIZE_256KB * 255,
+    SIZE_64KB * 4,
+    SIZE_64KB,
+    {0x98C111C6, 0xB322, 0x4C33, { 0x95, 0xD5, 0xAF, 0x56, 0xAF, 0x90, 0x18, 0x6A } }
+  },
+};
+
+EFI_STATUS
+NorFlashPlatformInitialization (
+  VOID
+  )
+{
+  return EFI_SUCCESS;
+}
+
+EFI_STATUS
+NorFlashPlatformGetDevices (
+  OUT NOR_FLASH_DESCRIPTION   **NorFlashDevices,
+  OUT UINT32                  *Count
+  )
+{
+  if ((NorFlashDevices == NULL) || (Count == NULL)) {
+    return EFI_INVALID_PARAMETER;
+  }
+
+  *NorFlashDevices = mNorFlashDevices;
+  *Count = sizeof (mNorFlashDevices) / sizeof (NOR_FLASH_DESCRIPTION);
+
+  return EFI_SUCCESS;
+}
diff --git a/Platform/ARM/SgiPkg/Library/NorFlashLib/NorFlashLib.inf b/Platform/ARM/SgiPkg/Library/NorFlashLib/NorFlashLib.inf
new file mode 100644
index 0000000..a860e5c
--- /dev/null
+++ b/Platform/ARM/SgiPkg/Library/NorFlashLib/NorFlashLib.inf
@@ -0,0 +1,33 @@ 
+#/** @file
+#
+#  Copyright (c) 2018, ARM Ltd. All rights reserved.
+
+#  This program and the accompanying materials are licensed and made available
+#  under the terms and conditions of the BSD License which accompanies this
+#  distribution.  The full text of the license may be found at
+#  http://opensource.org/licenses/bsd-license.php
+#
+#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+#
+#**/
+
+[Defines]
+  INF_VERSION                    = 0x00010005
+  BASE_NAME                      = NorFlashSgiLib
+  FILE_GUID                      = 3f021755-6d74-4065-9ee4-98225267b36e
+  MODULE_TYPE                    = DXE_DRIVER
+  VERSION_STRING                 = 1.0
+  LIBRARY_CLASS                  = NorFlashPlatformLib
+
+[Sources.common]
+  NorFlash.c
+
+[Packages]
+  MdePkg/MdePkg.dec
+  ArmPlatformPkg/ArmPlatformPkg.dec
+
+[LibraryClasses]
+  BaseLib
+  DebugLib
+  IoLib