From patchwork Fri Apr 13 11:24:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 133364 Delivered-To: patch@linaro.org Received: by 10.46.84.18 with SMTP id i18csp621829ljb; Fri, 13 Apr 2018 04:24:30 -0700 (PDT) X-Google-Smtp-Source: AIpwx49CXeXKsmeF3l49EnXrCmZcBcvO3ZYziZbnSDTGjclas17n4kk+Dz2gIsLR/DKMBaSLlWCQ X-Received: by 10.28.230.91 with SMTP id d88mr3293221wmh.67.1523618670420; Fri, 13 Apr 2018 04:24:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523618670; cv=none; d=google.com; s=arc-20160816; b=y9cz8JWrHRe5iYX3jDZxXeacSfWBpbkvEEv4b4dZyDIauAEkh37detBtFotnTj7e6Z tDjAx/P5nkXNzr8zf1Yi/ER9zfflamMJNXVkRF9C9NTRYn1SndKRfIbgsbtf+8kqSrxG qAO0ax2frltfbRS1gAZ5psooEVi2Ms1v9nZz5wBJQoJN6wCuT9WXyR/gbtEMlLaU6sVz nfxiXYKmHtDuGSQ8B0cmUzQdPiDxKugdxXdiJPGVA1wKLpH5AUmwVWSUuXw8ZAeDdoh2 p3u9gvaE6OUo/EhEb5kJqX0i3FgEj1qYPEBt+Rpqe5Nmhg1yklxbTrSYPMvJrNRnrs3l zoGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=6H6fgL85o8JZXvlzxj6qp19Y10LRwGS1q6RLuS5rBzg=; b=o4ndg+1fg28lFqjPO7UkjzwrNdKYBykn5qYzxzQKGqlCZj6LnKRmeSHkuBHv6TCYPo qQgOKF8sCO0+oPXi23uaG2WUszsJDIcjqDcu6LizCx6FneulifowZzY32HiRHneKq8UF maOFsMLG9F9eVSlKZjOHdI/IJ8T3hMyFqUMZIViPKjnk8Syb6xY6C3XjWWJOTiCpFE4Q bInnRSTxquKQLqOr2K6S0hsnx+H5wa+/wQb+b2y8gC9gGPFEZD96T7q6D7OL1txOaoyK P3F0tjPhlmajPZhhfjM1hb0Gr8+mwGcXooHJw3eH4/KNFVixwTgNk5QI+fLdBvc3itrv qq/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=SMi9z6j2; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id v11si4015946wri.218.2018.04.13.04.24.30; Fri, 13 Apr 2018 04:24:30 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=SMi9z6j2; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 860052675DE; Fri, 13 Apr 2018 13:24:19 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 60BF0267614; Fri, 13 Apr 2018 13:24:17 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id EFF8926760F for ; Fri, 13 Apr 2018 13:24:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=oxcXhO14BA5PZ42emytvtAlhLuvPoAr50z/OEuaqJIE=; b=SMi9z6j24hKO R/VTYJrwtggi226GbMlbWuFYFwZy37eYjPWa6AXXYkCo8Cwyk+BFRqSnvf2S8ZYEHWk4hlISWqP6t mxpczPrcmlARC2JBuU4ubws09ja3fzU3cHmiu0iEJUAupGJWtvLI1o6OtBOvRkBYBS+muCMlqKWyO lzfZE=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1f6woK-0008Cj-Hr; Fri, 13 Apr 2018 11:24:08 +0000 Received: from broonie by debutante with local (Exim 4.90_1) (envelope-from ) id 1f6woK-0000Dd-2m; Fri, 13 Apr 2018 12:24:08 +0100 From: Mark Brown To: Jia-Ju Bai In-Reply-To: Message-Id: Date: Fri, 13 Apr 2018 12:24:08 +0100 Cc: alsa-devel@alsa-project.org, Mark Brown Subject: [alsa-devel] Applied "ASoC: intel: bytcr_rt5640: Replace GFP_ATOMIC with GFP_KERNEL in snd_byt_rt5640_mc_probe" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: intel: bytcr_rt5640: Replace GFP_ATOMIC with GFP_KERNEL in snd_byt_rt5640_mc_probe has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From f5c74c2918e51be14bc9c11c76fa118e354f4789 Mon Sep 17 00:00:00 2001 From: Jia-Ju Bai Date: Mon, 9 Apr 2018 18:47:37 +0800 Subject: [PATCH] ASoC: intel: bytcr_rt5640: Replace GFP_ATOMIC with GFP_KERNEL in snd_byt_rt5640_mc_probe snd_byt_rt5640_mc_probe() is never called in atomic context. This function is only set as ".probe" in "struct platform_driver". Despite never getting called from atomic context, snd_byt_rt5640_mc_probe() calls devm_kzalloc() with GFP_ATOMIC, which waits busily for allocation. GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, to avoid busy waiting and improve the possibility of sucessful allocation. This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai Signed-off-by: Mark Brown --- sound/soc/intel/boards/bytcr_rt5640.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c index a8d8bff788e7..ad5fcd5a1762 100644 --- a/sound/soc/intel/boards/bytcr_rt5640.c +++ b/sound/soc/intel/boards/bytcr_rt5640.c @@ -744,7 +744,7 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev) int i; is_bytcr = false; - priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_ATOMIC); + priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM;