From patchwork Mon Apr 16 07:22:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jassi Brar X-Patchwork-Id: 133439 Delivered-To: patch@linaro.org Received: by 10.46.84.18 with SMTP id i18csp3277215ljb; Mon, 16 Apr 2018 00:38:35 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/RSpfPQGtmBmeYMJFyK7hJ/osdiinRElGW7NIY43bXS6jcVhS8FVNRix3iUqS4RQRv5Um4 X-Received: by 10.99.114.14 with SMTP id n14mr1430885pgc.384.1523864315308; Mon, 16 Apr 2018 00:38:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523864315; cv=none; d=google.com; s=arc-20160816; b=vQpyQ11oJR9n2AN0L7eD/myruJ3R7JDZZjESh2Qn2tJWH9QckG66MOgNCpakvTrw1Q egAnhGdwaylSZnO+k0rb6spal8iBar1k92dWp08quvjsdNBWlk00LoGD9G4i0Cglq2xd l3Evr4JqtxEtf7j949Qe17VqIe5q9beuSTOz9U06OpFDQTK05lh/f4YX+10+DfxA6eQL w84AalfyR7dj6Q4cu4J76QhLkaxpDMGX4RQXVMVJiW5QTT48IYB887JXQgRyyaPm5l8q OwoW20Lwd9qNXKVFJJC2SaiN95I0IBFNhTjCx8cXIqzcFpzdOuFvJIK4uSlpWfQMWx1W /KIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=4i2f3d2Nv1xFQ9vRyLf8VK0vF6yqUeHBZsaKFzg2ztE=; b=qy7WMj/vzyqQi7Zkipg4kA63SnwWNOvqpDOyALmOu4TeIy0doLYGr8pIxkRd1xX5Hb y95yttgqkElbsd7ZN/5L0EJRMYHEHBmJlticoJ+urwOHFXE4osEHOdc9RBvAaahNOOzx a/FQ8XnwD6vvGYWtZZuUxqaKGOmI1EZU0mQKQro7mcqnRVQ48IxjLR7uIbjQBZjRsiBN JnHS9HXeNFBR+WWzQBNVLHb4C5R2FghcdCysP53k62KZQWA4dpGyDvQjmS7G4t/V0WWY MnqxRm0c3y+LpwszOyuXpsiJL3f0Ld/7OISpgz3z8knwG+piHaHlytqTe/kttxyR+jQU 5D5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QK2LbRo1; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bf10-v6si11875019plb.417.2018.04.16.00.38.35; Mon, 16 Apr 2018 00:38:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=QK2LbRo1; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753183AbeDPHic (ORCPT + 9 others); Mon, 16 Apr 2018 03:38:32 -0400 Received: from mail-pl0-f65.google.com ([209.85.160.65]:36819 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751200AbeDPHib (ORCPT ); Mon, 16 Apr 2018 03:38:31 -0400 Received: by mail-pl0-f65.google.com with SMTP id 91-v6so9549841pld.3 for ; Mon, 16 Apr 2018 00:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=4i2f3d2Nv1xFQ9vRyLf8VK0vF6yqUeHBZsaKFzg2ztE=; b=QK2LbRo15tF5u29QsOhpTVq5wh5QzzMgiD99bDGXda7T77GbZC4L5Jwmv0QQGTU0sy /D5qPIgpwoEX5rxYCeZ2qPvge7cMW0eJg+zDjdviIJ8z/DX6EVGBCM8OVj7AHt9uFNDM UXC8Le7QHkqSgrmVFmFqbKtoy5GdvrfPEOyx4eMX46Gea/nQY9AzlngrI4AqvDdQ6tfy D5/DlxE55SQ2RvLpAAXc+ZiZ1cjYidBCVTxfIqCsBQFBqcVTrkHbDMAy9It5ixzw0nL2 1kHTHV3BrH9cpcNKaLevYRYvURUvb+g0prpl1QNtpjGl9yGRkHKtca1uyfn6yP6zd3De ecYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=4i2f3d2Nv1xFQ9vRyLf8VK0vF6yqUeHBZsaKFzg2ztE=; b=cHbu37t8eNdLEIVv7AlciTcwbzYDztGUD5fICya3xH5tcM2mUYX+Z0EvfVPq5glXFf sUGONAm/6RHUlZEx3AMU6UaU4W+rtI6oDhhTtA8c+HNtOMcCDGl3KEqZI4hX+fsHI+Hz k7Mm0XNHYE8yDWVOoZHlKzymVjqXeZcn79n+mEPnKTyUbgjbpgS5QODINXTkxAL/tdIt DE6U4w76+14JkQ5577RnSwiUbSBSsaye60n+ePAy0e4Pzn8UCVBn5wBmdvhyT/A9XXET yrHfPGveGDfGrhWbQJ20ldVwLzohRnq3EbdLL0fznfjbL/UglgGayRW5o9Qt3gdIn5En FA6Q== X-Gm-Message-State: ALQs6tBy/QnpayZkTDk+BF16m8OHya7tEq5V289BCVntGZqF+lX7IEkS dxqaYNW69Xzsk4v9qrpnDwm9uUrX X-Received: by 2002:a17:902:aa03:: with SMTP id be3-v6mr14053094plb.299.1523864310728; Mon, 16 Apr 2018 00:38:30 -0700 (PDT) Received: from localhost.localdomain ([117.224.27.197]) by smtp.gmail.com with ESMTPSA id g72sm2896786pfg.60.2018.04.16.00.38.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 16 Apr 2018 00:38:29 -0700 (PDT) From: jassisinghbrar@gmail.com To: netdev@vger.kernel.org Cc: davem@davemloft.net, masahisa.kojima@linaro.org, ard.biesheuvel@linaro.org, Jassi Brar Subject: [PATCH 1/2] net: netsec: enable tx-irq during open callback Date: Mon, 16 Apr 2018 12:52:16 +0530 Message-Id: <1523863336-12653-1-git-send-email-jassisinghbrar@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jassi Brar Enable TX-irq as well during ndo_open() as we can not count upon RX to arrive early enough to trigger the napi. This patch is critical for installation over network. Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver") Signed-off-by: Jassi Brar --- drivers/net/ethernet/socionext/netsec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c index f4c0b02..f6fe70e 100644 --- a/drivers/net/ethernet/socionext/netsec.c +++ b/drivers/net/ethernet/socionext/netsec.c @@ -1313,8 +1313,8 @@ static int netsec_netdev_open(struct net_device *ndev) napi_enable(&priv->napi); netif_start_queue(ndev); - /* Enable RX intr. */ - netsec_write(priv, NETSEC_REG_INTEN_SET, NETSEC_IRQ_RX); + /* Enable TX+RX intr. */ + netsec_write(priv, NETSEC_REG_INTEN_SET, NETSEC_IRQ_RX | NETSEC_IRQ_TX); return 0; err3: