From patchwork Mon Apr 16 11:00:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 133447 Delivered-To: patch@linaro.org Received: by 10.46.84.18 with SMTP id i18csp3429892ljb; Mon, 16 Apr 2018 04:01:08 -0700 (PDT) X-Google-Smtp-Source: AIpwx48xUpdLH0TMcsiYqJZsSX7rmga/gkGB75+4N9sp5i8bqX4A64SEo+4AcDhvYcCzeJRs7sp2 X-Received: by 10.98.137.218 with SMTP id n87mr21308131pfk.48.1523876468537; Mon, 16 Apr 2018 04:01:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523876468; cv=none; d=google.com; s=arc-20160816; b=TVDYgQhiSxdfXpNu9f0iOmV7XN8A7STO1J1Ds5942RlkVOQctzDXlf2tkUDKfcQvyD bJ3fM9fpB75kB21+bB7xd8wo1o/iYU87gzLdxJlwmG4iglOnKwnoA8v8xQuj27qOGo3h CD5na29cEGiV14Rqjr46bYeqtC1wqnI5fzJaRS96ST6QfqTKqHmOPuszZ1TgBa1QRVhY CzR/bBsLd4/PRWthiwHrxINU57vOu35NrUKkBtNt6Er3Hw3Clv7jqg9Re0isdw3mNI1M KAoCwh3AVbjNbyR986NSvd7IWhHN573i/kBgJf9RVs3y6u0ntp1dE1DvKLZYiK73Dz76 kLYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=cZ2WkH4iAQz6+oZO6Ox1PDElvPAmCuBgNQGmouwTHiA=; b=RIvAiwhOdBwcaT0Teien4NSwSzZbtPCyZRpPwXyY8azSzNO9SuIoLnOwFV5CstA5Ki D0T9J+/RP3tKHDTZzbxYhYYTGKofDfL2k3bD4ulC6v2Ul3SFxWI7Mil+Hn+E4YOPt2OL DXIY6R1OCGiv4WVd7gUFdYgQSI3YryishkBrOlp38AY80SqTYn23BdejKcrNIb4AsEdw sQhZ1vrbZgixti2Pz+Iq2uFBA+ug8Kro2ViieIBCYO+SmMAfGl3zJDcxQcsAFyNNHzwC Zi7mhPqEg7/QcpV7CJeryU70f5dYJrtLqFbE2FrE6n2U4aHF1/dreJ/8AvvwA2Oj8ZFF Vp0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=X5gtaESx; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id bg7-v6si12054804plb.537.2018.04.16.04.01.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Apr 2018 04:01:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=X5gtaESx; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 046A822497F56; Mon, 16 Apr 2018 04:01:08 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2a00:1450:400c:c0c::241; helo=mail-wr0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-wr0-x241.google.com (mail-wr0-x241.google.com [IPv6:2a00:1450:400c:c0c::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 64B5222497F2D for ; Mon, 16 Apr 2018 04:01:06 -0700 (PDT) Received: by mail-wr0-x241.google.com with SMTP id v24so7669221wra.8 for ; Mon, 16 Apr 2018 04:01:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=i3Ust7hvtFqvCbnMo6vHyF9WQORvirUcrm7FdXboVDE=; b=X5gtaESx4ppwZyiGvHVU9fri4U/01weynLWpDRdZrt5sp0CMxR/9f31x1CLiE7lhVQ AvQXSbYKFakmyAIAqy+iorEAJeG+AQfRWvNvvhCkdvZxGE73Zr+S1+kEVcLoV3aVpIgm Y/aEU6YJ6YzAdL0ua71kXvnxyMRDRiXPnga7Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=i3Ust7hvtFqvCbnMo6vHyF9WQORvirUcrm7FdXboVDE=; b=qidpoAFhZyn3pHNy8K0HjswenRsCjHfXGdN/B1pjZhhzLJIbtkbj4ICMiardDTwy4s lMQp+0/XtmEVJ3z6+5kD5CJAAT/0MEO5lx24iZWB6yoVar5/iayGb9iOrGULMzlJCXzC Xrv8ZSSl43g9OWW3L7uJvU3srcpwI4S8JNr2xJ4Ab0K0IH0D0+OgmxTBpojT9J2Vg1p1 alUr/8qP8n6PnY1Y1i9A18zH7BWSVUu4VdLT+BSCa2biqfxgBEtyyQl9vy7k5PSbW6Bw eWUqq/r+QDzwCQLtL04nNJK2Z2k7sLSt9anT2oAFjKmThZgqSkPY2ktNFUsZSrmDw7l6 BTUg== X-Gm-Message-State: ALQs6tA7UkbJUMFo5gKJ8QgbaCUbVqKBYmEs3TtUJpF5EVeGgxIoVh5b e4jkdDmC2fF5zlVWvtB7IYOjdfVfV0g= X-Received: by 10.223.152.20 with SMTP id v20mr1404637wrb.93.1523876464299; Mon, 16 Apr 2018 04:01:04 -0700 (PDT) Received: from localhost.localdomain ([2a01:e35:3995:5470:200:1aff:fe1b:b328]) by smtp.gmail.com with ESMTPSA id y100sm16931392wmh.2.2018.04.16.04.01.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Apr 2018 04:01:03 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Mon, 16 Apr 2018 13:00:58 +0200 Message-Id: <20180416110058.16952-1-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.0 Subject: [edk2] [PATCH edk2-platforms] Silicon/Socionext/SynQuacer: update PHY reference clock rate X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jaswinder.singh@linaro.org, Ard Biesheuvel , leif.lindholm@linaro.org, masahisa.kojima@linaro.org MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" As reported by Kojima-san, the PHY reference clock value we use in our ACPI and DT descriptions is out of sync with the hardware. Replace 125 MHz with 250 MHz throughout. Cc: Masahisa Kojima Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- Kojima-san, Please confirm that the modification to ogma_config.h is correct. Thanks, Ard. Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl | 2 +- Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi | 4 ++-- Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/netsec_for_uefi/ogma_config.h | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) -- 2.17.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Leif Lindholm diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl index b6f6c4360029..3f73c191d4d6 100644 --- a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl @@ -162,7 +162,7 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "SNI", "SYNQUACR", Package (2) { "phy-channel", FixedPcdGet32 (PcdNetsecPhyAddress) }, Package (2) { "max-speed", 1000 }, Package (2) { "max-frame-size", 9000 }, - Package (2) { "socionext,phy-clock-frequency", 125000000 }, + Package (2) { "socionext,phy-clock-frequency", 250000000 }, } }) } diff --git a/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi b/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi index 6e93c6ae16a8..f6887329f6c7 100644 --- a/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi +++ b/Silicon/Socionext/SynQuacer/DeviceTree/SynQuacer.dtsi @@ -420,9 +420,9 @@ reg-shift = <2>; }; - clk_netsec: refclk125mhz { + clk_netsec: refclk250mhz { compatible = "fixed-clock"; - clock-frequency = <125000000>; + clock-frequency = <250000000>; #clock-cells = <0>; }; diff --git a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/netsec_for_uefi/ogma_config.h b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/netsec_for_uefi/ogma_config.h index 1caf64e30623..f6ec9b30ec8e 100644 --- a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/netsec_for_uefi/ogma_config.h +++ b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/netsec_for_uefi/ogma_config.h @@ -16,8 +16,8 @@ #ifndef OGMA_CONFIG_H #define OGMA_CONFIG_H -#define OGMA_CONFIG_CLK_HZ 125000000UL -#define OGMA_CONFIG_GMAC_CLK_HZ 125000000UL +#define OGMA_CONFIG_CLK_HZ 250000000UL +#define OGMA_CONFIG_GMAC_CLK_HZ 250000000UL #define OGMA_CONFIG_CHECK_CLK_SUPPLY #define OGMA_CONFIG_USE_READ_GMAC_STAT