acpi:ipmi: Convert ipmi_user_t to struct ipmi_user *

Message ID 1524064541-22252-1-git-send-email-minyard@acm.org
State New
Headers show
Series
  • acpi:ipmi: Convert ipmi_user_t to struct ipmi_user *
Related show

Commit Message

Corey Minyard April 18, 2018, 3:15 p.m.
From: Corey Minyard <cminyard@mvista.com>


Signed-off-by: Corey Minyard <cminyard@mvista.com>

Cc: Zhao Yakui <yakui.zhao@intel.com>
Cc: Lv Zheng <lv.zheng@intel.com>
---
 drivers/acpi/acpi_ipmi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

I'm getting rid of this annoying coding style violation, if you
could get this in that would be great.

-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Rafael J. Wysocki April 23, 2018, 7:59 a.m. | #1
On Wednesday, April 18, 2018 5:15:41 PM CEST minyard@acm.org wrote:
> From: Corey Minyard <cminyard@mvista.com>

> 

> Signed-off-by: Corey Minyard <cminyard@mvista.com>

> Cc: Zhao Yakui <yakui.zhao@intel.com>

> Cc: Lv Zheng <lv.zheng@intel.com>

> ---

>  drivers/acpi/acpi_ipmi.c | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> I'm getting rid of this annoying coding style violation, if you

> could get this in that would be great.

> 

> diff --git a/drivers/acpi/acpi_ipmi.c b/drivers/acpi/acpi_ipmi.c

> index 1b64419..712fd31 100644

> --- a/drivers/acpi/acpi_ipmi.c

> +++ b/drivers/acpi/acpi_ipmi.c

> @@ -46,7 +46,7 @@ struct acpi_ipmi_device {

>  	spinlock_t tx_msg_lock;

>  	acpi_handle handle;

>  	struct device *dev;

> -	ipmi_user_t user_interface;

> +	struct ipmi_user *user_interface;

>  	int ipmi_ifnum; /* IPMI interface number */

>  	long curr_msgid;

>  	bool dead;

> @@ -125,7 +125,7 @@ ipmi_dev_alloc(int iface, struct device *dev, acpi_handle handle)

>  {

>  	struct acpi_ipmi_device *ipmi_device;

>  	int err;

> -	ipmi_user_t user;

> +	struct ipmi_user *user;

>  

>  	ipmi_device = kzalloc(sizeof(*ipmi_device), GFP_KERNEL);

>  	if (!ipmi_device)

> 


FWIW:

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>



--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/acpi/acpi_ipmi.c b/drivers/acpi/acpi_ipmi.c
index 1b64419..712fd31 100644
--- a/drivers/acpi/acpi_ipmi.c
+++ b/drivers/acpi/acpi_ipmi.c
@@ -46,7 +46,7 @@  struct acpi_ipmi_device {
 	spinlock_t tx_msg_lock;
 	acpi_handle handle;
 	struct device *dev;
-	ipmi_user_t user_interface;
+	struct ipmi_user *user_interface;
 	int ipmi_ifnum; /* IPMI interface number */
 	long curr_msgid;
 	bool dead;
@@ -125,7 +125,7 @@  ipmi_dev_alloc(int iface, struct device *dev, acpi_handle handle)
 {
 	struct acpi_ipmi_device *ipmi_device;
 	int err;
-	ipmi_user_t user;
+	struct ipmi_user *user;
 
 	ipmi_device = kzalloc(sizeof(*ipmi_device), GFP_KERNEL);
 	if (!ipmi_device)