[v5,05/23] ASoC: qdsp6: dt-bindings: Add q6adm dt bindings

Message ID 20180418153157.1960-6-srinivas.kandagatla@linaro.org
State Superseded
Headers show
Series
  • [v5,01/23] soc: qcom dt-bindings: Add APR bus bindings
Related show

Commit Message

Srinivas Kandagatla April 18, 2018, 3:31 p.m.
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>


This patch add DT bindings for ADM (Audio Device Manager) DSP module.
This module implements mixer controls to setup the connections between
AFE ports and ASM streams.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

Reviewed-and-tested-by: Rohit kumar <rohitkr@codeaurora.org>
---
 .../devicetree/bindings/sound/qcom,q6adm.txt       | 33 ++++++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6adm.txt

-- 
2.16.2

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Comments

Rob Herring April 24, 2018, 4:15 p.m. | #1
On Wed, Apr 18, 2018 at 04:31:39PM +0100, srinivas.kandagatla@linaro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

> 

> This patch add DT bindings for ADM (Audio Device Manager) DSP module.

> This module implements mixer controls to setup the connections between

> AFE ports and ASM streams.

> 

> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

> Reviewed-and-tested-by: Rohit kumar <rohitkr@codeaurora.org>

> ---

>  .../devicetree/bindings/sound/qcom,q6adm.txt       | 33 ++++++++++++++++++++++

>  1 file changed, 33 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6adm.txt


Similar comments in this one.

> 

> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6adm.txt b/Documentation/devicetree/bindings/sound/qcom,q6adm.txt

> new file mode 100644

> index 000000000000..f1e2df8d2ea8

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/sound/qcom,q6adm.txt

> @@ -0,0 +1,33 @@

> +Qualcomm Audio Device Manager (Q6ADM) binding

> +

> +Q6ADM is one of the APR audio service on Q6DSP.

> +Please refer to qcom,apr.txt for details of the coommon apr service bindings

> +used by the apr service device.

> +

> +- but must contain the following property:

> +

> +- compatible:

> +	Usage: required

> +	Value type: <stringlist>

> +	Definition: must be "qcom,adm-v<MAJOR-NUMBER>.<MINOR-NUMBER>".

> +		   Or "qcom,adm" where the version number can be queried

> +		   from DSP.

> +		   example "qcom,adm-v2.0"

> +

> +

> += ADM routing

> +"routing" subnode of the ADM node represents adm routing specific configuration

> +

> +- #sound-dai-cells

> +	Usage: required

> +	Value type: <prop-encoded-array>

> +	Definition: Must be 0

> +

> += EXAMPLE

> +q6adm {


a6adm@?

Needs to be the number, not a define.

> +	compatible = "qcom,q6adm";

> +	reg = <APR_SVC_ADM>;

> +	q6routing: routing {

> +		#sound-dai-cells = <0>;

> +	};

> +};

> -- 

> 2.16.2

> 

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Patch

diff --git a/Documentation/devicetree/bindings/sound/qcom,q6adm.txt b/Documentation/devicetree/bindings/sound/qcom,q6adm.txt
new file mode 100644
index 000000000000..f1e2df8d2ea8
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/qcom,q6adm.txt
@@ -0,0 +1,33 @@ 
+Qualcomm Audio Device Manager (Q6ADM) binding
+
+Q6ADM is one of the APR audio service on Q6DSP.
+Please refer to qcom,apr.txt for details of the coommon apr service bindings
+used by the apr service device.
+
+- but must contain the following property:
+
+- compatible:
+	Usage: required
+	Value type: <stringlist>
+	Definition: must be "qcom,adm-v<MAJOR-NUMBER>.<MINOR-NUMBER>".
+		   Or "qcom,adm" where the version number can be queried
+		   from DSP.
+		   example "qcom,adm-v2.0"
+
+
+= ADM routing
+"routing" subnode of the ADM node represents adm routing specific configuration
+
+- #sound-dai-cells
+	Usage: required
+	Value type: <prop-encoded-array>
+	Definition: Must be 0
+
+= EXAMPLE
+q6adm {
+	compatible = "qcom,q6adm";
+	reg = <APR_SVC_ADM>;
+	q6routing: routing {
+		#sound-dai-cells = <0>;
+	};
+};