[v2] doc: dev-tools: kselftest.rst: update contributing new tests

Message ID 20180419102825.2990-1-anders.roxell@linaro.org
State Accepted
Commit a997a703d08f805eb8767fbc586fd938f09d13cc
Headers show
Series
  • [v2] doc: dev-tools: kselftest.rst: update contributing new tests
Related show

Commit Message

Anders Roxell April 19, 2018, 10:28 a.m.
Add a description that the kernel headers should be used as far as it is
possible and then the system headers.

Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

---
 Documentation/dev-tools/kselftest.rst | 5 +++++
 1 file changed, 5 insertions(+)

-- 
2.11.0

Comments

Shuah Khan April 24, 2018, 7:35 p.m. | #1
On 04/19/2018 04:28 AM, Anders Roxell wrote:
> Add a description that the kernel headers should be used as far as it is

> possible and then the system headers.

> 

> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

> ---

>  Documentation/dev-tools/kselftest.rst | 5 +++++

>  1 file changed, 5 insertions(+)

> 

> diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst

> index e80850eefe13..3bf371a938d0 100644

> --- a/Documentation/dev-tools/kselftest.rst

> +++ b/Documentation/dev-tools/kselftest.rst

> @@ -151,6 +151,11 @@ Contributing new tests (details)

>     TEST_FILES, TEST_GEN_FILES mean it is the file which is used by

>     test.

>  

> + * First use the headers inside the kernel source and/or git repo, and then the

> +   system headers.  Headers for the kernel release as opposed to headers

> +   installed by the distro on the system should be the primary focus to be able

> +   to find regressions.

> +

>  Test Harness

>  ============

>  

> 


Here is my reviewed by for this to go through documentation tree.

Reviewed-by: Shuah Khan (Samsung OSG) <shuah@kernel.org>


thanks,
-- Shuah
Jonathan Corbet April 27, 2018, 10:56 p.m. | #2
On Thu, 19 Apr 2018 12:28:25 +0200
Anders Roxell <anders.roxell@linaro.org> wrote:

> Add a description that the kernel headers should be used as far as it is

> possible and then the system headers.

> 

> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>


Applied, thanks.

jon

Patch

diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst
index e80850eefe13..3bf371a938d0 100644
--- a/Documentation/dev-tools/kselftest.rst
+++ b/Documentation/dev-tools/kselftest.rst
@@ -151,6 +151,11 @@  Contributing new tests (details)
    TEST_FILES, TEST_GEN_FILES mean it is the file which is used by
    test.
 
+ * First use the headers inside the kernel source and/or git repo, and then the
+   system headers.  Headers for the kernel release as opposed to headers
+   installed by the distro on the system should be the primary focus to be able
+   to find regressions.
+
 Test Harness
 ============