diff mbox series

[v2,42/43] tests/tcg: disable fp-test for 32 bit (HACK!)

Message ID 20180419135901.30035-43-alex.bennee@linaro.org
State New
Headers show
Series fix building of tests/tcg | expand

Commit Message

Alex Bennée April 19, 2018, 1:59 p.m. UTC 
This prevents us trying to build fp-test for 32 bit guests as they
would fail due to pollution from config-host.h when including osdep.h.
As keeping softfloat.o would be useful maybe we can conditionally
disabled it?

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
 tests/tcg/multiarch/Makefile.target | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.17.0

Comments

Richard Henderson April 19, 2018, 10:02 p.m. UTC | #1 
On 04/19/2018 03:59 AM, Alex Bennée wrote:
> +ifneq (,$(findstring 64,$(TARGET_NAME)))


You're only considering aarch64, x86_64, ppc64 and the like.
This fails for alpha, s390x and the like.


r~
Alex Bennée April 20, 2018, 6:43 a.m. UTC | #2 
Richard Henderson <richard.henderson@linaro.org> writes:

> On 04/19/2018 03:59 AM, Alex Bennée wrote:

>> +ifneq (,$(findstring 64,$(TARGET_NAME)))

>

> You're only considering aarch64, x86_64, ppc64 and the like.

> This fails for alpha, s390x and the like.


Yes, it's a temporary hack that needs a better solution.

--
Alex Bennée
diff mbox series

Patch

diff --git a/tests/tcg/multiarch/Makefile.target b/tests/tcg/multiarch/Makefile.target
index 52adc18625..8bf6f3f8dc 100644
--- a/tests/tcg/multiarch/Makefile.target
+++ b/tests/tcg/multiarch/Makefile.target
@@ -31,6 +31,7 @@  run-test-mmap: test-mmap
 #
 # Include the fp-test from the main test suite
 #
+ifneq (,$(findstring 64,$(TARGET_NAME)))
 
 VPATH+=$(SRC_PATH)/tests/fp
 VPATH+=$(SRC_PATH)/fpu
@@ -46,3 +47,4 @@  fp-test.o softfloat.o: %.o: %.c
 fp-test: fp-test.o softfloat.o
 	$(CC) $^ -o $@ -lm -static
 
+endif