| Message ID | 20180419142151.9862-1-peter.maydell@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | target/arm: Remove stale TODO comment | expand |
On 04/19/2018 11:21 AM, Peter Maydell wrote: > Remove a stale TODO comment -- we have now made the arm_ldl_ptw() > and arm_ldq_ptw() functions propagate physical memory read errors > out to their callers. ... in 3b39d734141. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > target/arm/helper.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/target/arm/helper.c b/target/arm/helper.c > index 2ebd086ef2..0fa02c31e1 100644 > --- a/target/arm/helper.c > +++ b/target/arm/helper.c > @@ -8681,13 +8681,7 @@ static hwaddr S1_ptw_translate(CPUARMState *env, ARMMMUIdx mmu_idx, > return addr; > } > > -/* All loads done in the course of a page table walk go through here. > - * TODO: rather than ignoring errors from physical memory reads (which > - * are external aborts in ARM terminology) we should propagate this > - * error out so that we can turn it into a Data Abort if this walk > - * was being done for a CPU load/store or an address translation instruction > - * (but not if it was for a debug access). > - */ > +/* All loads done in the course of a page table walk go through here. */ > static uint32_t arm_ldl_ptw(CPUState *cs, hwaddr addr, bool is_secure, > ARMMMUIdx mmu_idx, ARMMMUFaultInfo *fi) > { >
diff --git a/target/arm/helper.c b/target/arm/helper.c index 2ebd086ef2..0fa02c31e1 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -8681,13 +8681,7 @@ static hwaddr S1_ptw_translate(CPUARMState *env, ARMMMUIdx mmu_idx, return addr; } -/* All loads done in the course of a page table walk go through here. - * TODO: rather than ignoring errors from physical memory reads (which - * are external aborts in ARM terminology) we should propagate this - * error out so that we can turn it into a Data Abort if this walk - * was being done for a CPU load/store or an address translation instruction - * (but not if it was for a debug access). - */ +/* All loads done in the course of a page table walk go through here. */ static uint32_t arm_ldl_ptw(CPUState *cs, hwaddr addr, bool is_secure, ARMMMUIdx mmu_idx, ARMMMUFaultInfo *fi) {
Remove a stale TODO comment -- we have now made the arm_ldl_ptw() and arm_ldq_ptw() functions propagate physical memory read errors out to their callers. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- target/arm/helper.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) -- 2.17.0