diff mbox series

[4/4] crypto/dpaa_sec: update maximum queue pairs to 2

Message ID 1524156759-12931-4-git-send-email-hemant.agrawal@nxp.com
State Superseded
Headers show
Series [1/4] crypto/dpaa_sec: support dynamic logging | expand

Commit Message

Hemant Agrawal April 19, 2018, 4:52 p.m. UTC 
From: Nipun Gupta <nipun.gupta@nxp.com>


Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>

---
 drivers/crypto/dpaa_sec/dpaa_sec.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.7.4

Comments

De Lara Guarch, Pablo April 20, 2018, 9:47 a.m. UTC | #1 
Hi,

> -----Original Message-----

> From: Hemant Agrawal [mailto:hemant.agrawal@nxp.com]

> Sent: Thursday, April 19, 2018 5:53 PM

> To: dev@dpdk.org

> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;

> akhil.goyal@nxp.com; Nipun Gupta <nipun.gupta@nxp.com>

> Subject: [PATCH 4/4] crypto/dpaa_sec: update maximum queue pairs to 2

> 

> From: Nipun Gupta <nipun.gupta@nxp.com>

> 

> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>


Is this a fix? Why you are increasing the maximum number of queue pairs?

Thanks,
Pablo
Akhil Goyal April 20, 2018, 10:20 a.m. UTC | #2 
Hi Hemant/Nipun
On 4/19/2018 10:22 PM, Hemant Agrawal wrote:
> From: Nipun Gupta <nipun.gupta@nxp.com>

>

> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>

> ---

>  drivers/crypto/dpaa_sec/dpaa_sec.h | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.h b/drivers/crypto/dpaa_sec/dpaa_sec.h

> index 1433595..5b25aa1 100644

> --- a/drivers/crypto/dpaa_sec/dpaa_sec.h

> +++ b/drivers/crypto/dpaa_sec/dpaa_sec.h

> @@ -136,7 +136,7 @@ struct dpaa_sec_qp {

>  	int tx_errs;

>  };

>

> -#define RTE_DPAA_MAX_NB_SEC_QPS 1

> +#define RTE_DPAA_MAX_NB_SEC_QPS 2

>  #define RTE_DPAA_MAX_RX_QUEUE RTE_DPAA_SEC_PMD_MAX_NB_SESSIONS

>  #define DPAA_MAX_DEQUEUE_NUM_FRAMES 63

>

>

Why 2? I think it should be 8.

Akhil
Akhil Goyal April 20, 2018, 10:22 a.m. UTC | #3 
Hi Pablo,
On 4/20/2018 3:17 PM, De Lara Guarch, Pablo wrote:
> Hi,

>

>> -----Original Message-----

>> From: Hemant Agrawal [mailto:hemant.agrawal@nxp.com]

>> Sent: Thursday, April 19, 2018 5:53 PM

>> To: dev@dpdk.org

>> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;

>> akhil.goyal@nxp.com; Nipun Gupta <nipun.gupta@nxp.com>

>> Subject: [PATCH 4/4] crypto/dpaa_sec: update maximum queue pairs to 2

>>

>> From: Nipun Gupta <nipun.gupta@nxp.com>

>>

>> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>

>

> Is this a fix? Why you are increasing the maximum number of queue pairs?

>

> Thanks,

> Pablo

>

This is not a fix. We are increasing the number to handle some of the 
use case which we were not handling before.

Akhil
Hemant Agrawal April 20, 2018, 10:23 a.m. UTC | #4 
> Hi Hemant/Nipun

> On 4/19/2018 10:22 PM, Hemant Agrawal wrote:

> > From: Nipun Gupta <nipun.gupta@nxp.com>

> >

> > Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>

> > ---

> >  drivers/crypto/dpaa_sec/dpaa_sec.h | 2 +-

> >  1 file changed, 1 insertion(+), 1 deletion(-)

> >

> > diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.h

> > b/drivers/crypto/dpaa_sec/dpaa_sec.h

> > index 1433595..5b25aa1 100644

> > --- a/drivers/crypto/dpaa_sec/dpaa_sec.h

> > +++ b/drivers/crypto/dpaa_sec/dpaa_sec.h

> > @@ -136,7 +136,7 @@ struct dpaa_sec_qp {

> >  	int tx_errs;

> >  };

> >

> > -#define RTE_DPAA_MAX_NB_SEC_QPS 1

> > +#define RTE_DPAA_MAX_NB_SEC_QPS 2

> >  #define RTE_DPAA_MAX_RX_QUEUE

> RTE_DPAA_SEC_PMD_MAX_NB_SESSIONS

> > #define DPAA_MAX_DEQUEUE_NUM_FRAMES 63

> >

> >

> Why 2? I think it should be 8.

> 

[Hemant] Ok. Sending v2

> Akhil
Akhil Goyal April 20, 2018, 10:40 a.m. UTC | #5 
Hi Hemant,
On 4/20/2018 3:53 PM, Hemant Agrawal wrote:
>

>

>> Hi Hemant/Nipun

>> On 4/19/2018 10:22 PM, Hemant Agrawal wrote:

>>> From: Nipun Gupta <nipun.gupta@nxp.com>

>>>

>>> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>

>>> ---

>>>  drivers/crypto/dpaa_sec/dpaa_sec.h | 2 +-

>>>  1 file changed, 1 insertion(+), 1 deletion(-)

>>>

>>> diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.h

>>> b/drivers/crypto/dpaa_sec/dpaa_sec.h

>>> index 1433595..5b25aa1 100644

>>> --- a/drivers/crypto/dpaa_sec/dpaa_sec.h

>>> +++ b/drivers/crypto/dpaa_sec/dpaa_sec.h

>>> @@ -136,7 +136,7 @@ struct dpaa_sec_qp {

>>>  	int tx_errs;

>>>  };

>>>

>>> -#define RTE_DPAA_MAX_NB_SEC_QPS 1

>>> +#define RTE_DPAA_MAX_NB_SEC_QPS 2

>>>  #define RTE_DPAA_MAX_RX_QUEUE

>> RTE_DPAA_SEC_PMD_MAX_NB_SESSIONS

>>> #define DPAA_MAX_DEQUEUE_NUM_FRAMES 63

>>>

>>>

>> Why 2? I think it should be 8.

>>

> [Hemant] Ok. Sending v2


I guess this need some testing whether it will break the existing use 
cases or not.

Pablo,

I recommend, it would be good if you can apply the other 3 patches in 
this series in RC1. This patch should be hold back for RC2.

Thanks,
Akhil
De Lara Guarch, Pablo April 20, 2018, 4 p.m. UTC | #6 
> -----Original Message-----

> From: Akhil Goyal [mailto:akhil.goyal@nxp.com]

> Sent: Friday, April 20, 2018 11:40 AM

> To: Hemant Agrawal <hemant.agrawal@nxp.com>; dev@dpdk.org; De Lara

> Guarch, Pablo <pablo.de.lara.guarch@intel.com>

> Cc: Nipun Gupta <nipun.gupta@nxp.com>

> Subject: Re: [PATCH 4/4] crypto/dpaa_sec: update maximum queue pairs to 2

> 

> Hi Hemant,

> On 4/20/2018 3:53 PM, Hemant Agrawal wrote:

> >

> >

> >> Hi Hemant/Nipun

> >> On 4/19/2018 10:22 PM, Hemant Agrawal wrote:

> >>> From: Nipun Gupta <nipun.gupta@nxp.com>

> >>>

> >>> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>

> >>> ---

> >>>  drivers/crypto/dpaa_sec/dpaa_sec.h | 2 +-

> >>>  1 file changed, 1 insertion(+), 1 deletion(-)

> >>>

> >>> diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.h

> >>> b/drivers/crypto/dpaa_sec/dpaa_sec.h

> >>> index 1433595..5b25aa1 100644

> >>> --- a/drivers/crypto/dpaa_sec/dpaa_sec.h

> >>> +++ b/drivers/crypto/dpaa_sec/dpaa_sec.h

> >>> @@ -136,7 +136,7 @@ struct dpaa_sec_qp {

> >>>  	int tx_errs;

> >>>  };

> >>>

> >>> -#define RTE_DPAA_MAX_NB_SEC_QPS 1

> >>> +#define RTE_DPAA_MAX_NB_SEC_QPS 2

> >>>  #define RTE_DPAA_MAX_RX_QUEUE

> >> RTE_DPAA_SEC_PMD_MAX_NB_SESSIONS

> >>> #define DPAA_MAX_DEQUEUE_NUM_FRAMES 63

> >>>

> >>>

> >> Why 2? I think it should be 8.

> >>

> > [Hemant] Ok. Sending v2

> 

> I guess this need some testing whether it will break the existing use cases or not.

> 

> Pablo,

> 

> I recommend, it would be good if you can apply the other 3 patches in this series

> in RC1. This patch should be hold back for RC2.


Good to me.
Thanks,
Pablo

> 

> Thanks,

> Akhil
De Lara Guarch, Pablo May 7, 2018, 1:39 p.m. UTC | #7 
> -----Original Message-----

> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch, Pablo

> Sent: Friday, April 20, 2018 5:00 PM

> To: Akhil Goyal <akhil.goyal@nxp.com>; Hemant Agrawal

> <hemant.agrawal@nxp.com>; dev@dpdk.org

> Cc: Nipun Gupta <nipun.gupta@nxp.com>

> Subject: Re: [dpdk-dev] [PATCH 4/4] crypto/dpaa_sec: update maximum queue

> pairs to 2

> 

> 

> 

> > -----Original Message-----

> > From: Akhil Goyal [mailto:akhil.goyal@nxp.com]

> > Sent: Friday, April 20, 2018 11:40 AM

> > To: Hemant Agrawal <hemant.agrawal@nxp.com>; dev@dpdk.org; De Lara

> > Guarch, Pablo <pablo.de.lara.guarch@intel.com>

> > Cc: Nipun Gupta <nipun.gupta@nxp.com>

> > Subject: Re: [PATCH 4/4] crypto/dpaa_sec: update maximum queue pairs

> > to 2

> >

> > Hi Hemant,

> > On 4/20/2018 3:53 PM, Hemant Agrawal wrote:

> > >

> > >

> > >> Hi Hemant/Nipun

> > >> On 4/19/2018 10:22 PM, Hemant Agrawal wrote:

> > >>> From: Nipun Gupta <nipun.gupta@nxp.com>

> > >>>

> > >>> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>

> > >>> ---

> > >>>  drivers/crypto/dpaa_sec/dpaa_sec.h | 2 +-

> > >>>  1 file changed, 1 insertion(+), 1 deletion(-)

> > >>>

> > >>> diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.h

> > >>> b/drivers/crypto/dpaa_sec/dpaa_sec.h

> > >>> index 1433595..5b25aa1 100644

> > >>> --- a/drivers/crypto/dpaa_sec/dpaa_sec.h

> > >>> +++ b/drivers/crypto/dpaa_sec/dpaa_sec.h

> > >>> @@ -136,7 +136,7 @@ struct dpaa_sec_qp {

> > >>>  	int tx_errs;

> > >>>  };

> > >>>

> > >>> -#define RTE_DPAA_MAX_NB_SEC_QPS 1

> > >>> +#define RTE_DPAA_MAX_NB_SEC_QPS 2

> > >>>  #define RTE_DPAA_MAX_RX_QUEUE

> > >> RTE_DPAA_SEC_PMD_MAX_NB_SESSIONS

> > >>> #define DPAA_MAX_DEQUEUE_NUM_FRAMES 63

> > >>>

> > >>>

> > >> Why 2? I think it should be 8.

> > >>

> > > [Hemant] Ok. Sending v2

> >

> > I guess this need some testing whether it will break the existing use cases or

> not.

> >

> > Pablo,

> >

> > I recommend, it would be good if you can apply the other 3 patches in

> > this series in RC1. This patch should be hold back for RC2.

> 

> Good to me.


Any update on this?

> Thanks,

> Pablo

> 

> >

> > Thanks,

> > Akhil
diff mbox series

Patch

diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.h b/drivers/crypto/dpaa_sec/dpaa_sec.h
index 1433595..5b25aa1 100644
--- a/drivers/crypto/dpaa_sec/dpaa_sec.h
+++ b/drivers/crypto/dpaa_sec/dpaa_sec.h
@@ -136,7 +136,7 @@  struct dpaa_sec_qp {
 	int tx_errs;
 };
 
-#define RTE_DPAA_MAX_NB_SEC_QPS 1
+#define RTE_DPAA_MAX_NB_SEC_QPS 2
 #define RTE_DPAA_MAX_RX_QUEUE RTE_DPAA_SEC_PMD_MAX_NB_SESSIONS
 #define DPAA_MAX_DEQUEUE_NUM_FRAMES 63