| Message ID | 20180420145249.32435-4-peter.maydell@linaro.org |
|---|---|
| State | Accepted |
| Commit | 87364af8fe0c9def2e9de8e63f6b66135834318c |
| Headers | show |
| Series | Drop compile time limit on number of serial ports | expand |
On 04/20/2018 11:52 AM, Peter Maydell wrote: > Following commit 12051d82f004024, UART devices should handle > being passed a NULL pointer chardev, so we don't need to > create "null" backends in board code. Remove the code that > does this and updates serial_hds[]. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/mips/boston.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/hw/mips/boston.c b/hw/mips/boston.c > index fb23161b33..14f0f6673b 100644 > --- a/hw/mips/boston.c > +++ b/hw/mips/boston.c > @@ -505,10 +505,6 @@ static void boston_mach_init(MachineState *machine) > "boston-platregs", 0x1000); > memory_region_add_subregion_overlap(sys_mem, 0x17ffd000, platreg, 0); > > - if (!serial_hds[0]) { > - serial_hds[0] = qemu_chr_new("serial0", "null"); > - } > - > s->uart = serial_mm_init(sys_mem, 0x17ffe000, 2, > get_cps_irq(s->cps, 3), 10000000, > serial_hds[0], DEVICE_NATIVE_ENDIAN); >
On 20.04.2018 16:52, Peter Maydell wrote: > Following commit 12051d82f004024, UART devices should handle > being passed a NULL pointer chardev, so we don't need to > create "null" backends in board code. Remove the code that > does this and updates serial_hds[]. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > hw/mips/boston.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/hw/mips/boston.c b/hw/mips/boston.c > index fb23161b33..14f0f6673b 100644 > --- a/hw/mips/boston.c > +++ b/hw/mips/boston.c > @@ -505,10 +505,6 @@ static void boston_mach_init(MachineState *machine) > "boston-platregs", 0x1000); > memory_region_add_subregion_overlap(sys_mem, 0x17ffd000, platreg, 0); > > - if (!serial_hds[0]) { > - serial_hds[0] = qemu_chr_new("serial0", "null"); > - } > - > s->uart = serial_mm_init(sys_mem, 0x17ffe000, 2, > get_cps_irq(s->cps, 3), 10000000, > serial_hds[0], DEVICE_NATIVE_ENDIAN); > Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/hw/mips/boston.c b/hw/mips/boston.c index fb23161b33..14f0f6673b 100644 --- a/hw/mips/boston.c +++ b/hw/mips/boston.c @@ -505,10 +505,6 @@ static void boston_mach_init(MachineState *machine) "boston-platregs", 0x1000); memory_region_add_subregion_overlap(sys_mem, 0x17ffd000, platreg, 0); - if (!serial_hds[0]) { - serial_hds[0] = qemu_chr_new("serial0", "null"); - } - s->uart = serial_mm_init(sys_mem, 0x17ffe000, 2, get_cps_irq(s->cps, 3), 10000000, serial_hds[0], DEVICE_NATIVE_ENDIAN);
Following commit 12051d82f004024, UART devices should handle being passed a NULL pointer chardev, so we don't need to create "null" backends in board code. Remove the code that does this and updates serial_hds[]. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- hw/mips/boston.c | 4 ---- 1 file changed, 4 deletions(-) -- 2.17.0