crypto: ccree: limit build to plausible archs

Message ID 1524484097-8315-1-git-send-email-gilad@benyossef.com
State New
Headers show
Series
  • crypto: ccree: limit build to plausible archs
Related show

Commit Message

Gilad Ben-Yossef April 23, 2018, 11:48 a.m.
Limit option to compile ccree to plausible architectures.

Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>

---
 drivers/crypto/Kconfig | 1 +
 1 file changed, 1 insertion(+)

-- 
2.7.4

Comments

Gilad Ben-Yossef April 23, 2018, 1:22 p.m. | #1
On Mon, Apr 23, 2018 at 3:13 PM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> Hi Gilad,

>

> On Mon, Apr 23, 2018 at 1:48 PM, Gilad Ben-Yossef <gilad@benyossef.com> wrote:

>> Limit option to compile ccree to plausible architectures.

>

> Thanks for your patch!

>

>> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>

>> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>

>> ---

>>  drivers/crypto/Kconfig | 1 +

>>  1 file changed, 1 insertion(+)

>>

>> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig

>> index d1ea1a0..7302785 100644

>> --- a/drivers/crypto/Kconfig

>> +++ b/drivers/crypto/Kconfig

>> @@ -726,6 +726,7 @@ config CRYPTO_DEV_ARTPEC6

>>  config CRYPTO_DEV_CCREE

>>         tristate "Support for ARM TrustZone CryptoCell family of security processors"

>>         depends on CRYPTO && CRYPTO_HW && OF && HAS_DMA

>> +       depends on (XTENSA || X86 || UNICORE32 || SUPERH || RISCV || PPC32 || OPENRISC || NIOS2 || NDS32 || MIPS || MICROBLAZE || HEXAGON || H8300 || ARM || ARM64 || ARC || COMPILE_TEST)

>

> That list looks a bit excessive to me...


I'm sorry, but as an Arm employee I'm not in liberty to identify which
customer licensed or might license CryptoCell for which platform, now
or in the future.

I'm sure you understand.

Gilad


-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru
Geert Uytterhoeven April 23, 2018, 5:53 p.m. | #2
Hi Gilad,

On Mon, Apr 23, 2018 at 3:22 PM, Gilad Ben-Yossef <gilad@benyossef.com> wrote:
> On Mon, Apr 23, 2018 at 3:13 PM, Geert Uytterhoeven

> <geert@linux-m68k.org> wrote:

>> On Mon, Apr 23, 2018 at 1:48 PM, Gilad Ben-Yossef <gilad@benyossef.com> wrote:

>>> Limit option to compile ccree to plausible architectures.

>>

>> Thanks for your patch!

>>

>>> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>

>>> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>

>>> ---

>>>  drivers/crypto/Kconfig | 1 +

>>>  1 file changed, 1 insertion(+)

>>>

>>> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig

>>> index d1ea1a0..7302785 100644

>>> --- a/drivers/crypto/Kconfig

>>> +++ b/drivers/crypto/Kconfig

>>> @@ -726,6 +726,7 @@ config CRYPTO_DEV_ARTPEC6

>>>  config CRYPTO_DEV_CCREE

>>>         tristate "Support for ARM TrustZone CryptoCell family of security processors"

>>>         depends on CRYPTO && CRYPTO_HW && OF && HAS_DMA

>>> +       depends on (XTENSA || X86 || UNICORE32 || SUPERH || RISCV || PPC32 || OPENRISC || NIOS2 || NDS32 || MIPS || MICROBLAZE || HEXAGON || H8300 || ARM || ARM64 || ARC || COMPILE_TEST)

>>

>> That list looks a bit excessive to me...

>

> I'm sorry, but as an Arm employee I'm not in liberty to identify which

> customer licensed or might license CryptoCell for which platform, now

> or in the future.

>

> I'm sure you understand.


IC, a clever marketing scheme to make everyone think that everybody else
is already a licensee ;-)

What about using "depends on <list> || COMPILE_TEST", with <list> the
platforms for which the DTS (incl. "arm,cryptocell-*") will be submitted
for v4.18? The list can easily be extended when needed.

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Patch

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index d1ea1a0..7302785 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -726,6 +726,7 @@  config CRYPTO_DEV_ARTPEC6
 config CRYPTO_DEV_CCREE
 	tristate "Support for ARM TrustZone CryptoCell family of security processors"
 	depends on CRYPTO && CRYPTO_HW && OF && HAS_DMA
+	depends on (XTENSA || X86 || UNICORE32 || SUPERH || RISCV || PPC32 || OPENRISC || NIOS2 || NDS32 || MIPS || MICROBLAZE || HEXAGON || H8300 || ARM || ARM64 || ARC || COMPILE_TEST)
 	default n
 	select CRYPTO_HASH
 	select CRYPTO_BLKCIPHER