dt-bindings: staging: remove a couple of ADC bindings

Message ID 20180426015754.26605-1-robh@kernel.org
State New
Headers show
Series
  • dt-bindings: staging: remove a couple of ADC bindings
Related show

Commit Message

Rob Herring April 26, 2018, 1:57 a.m.
Remove LPC32xx and SPEAr ADC bindings in staging. They have not been
touched since 2012.

Cc: Roland Stigge <stigge@antcom.de>
Cc: Stefan Roese <sr@denx.de>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rob Herring <robh@kernel.org>

---
Move these out of staging please or they are going to be removed.

 .../bindings/staging/iio/adc/lpc32xx-adc.txt       | 16 -------------
 .../bindings/staging/iio/adc/spear-adc.txt         | 26 ----------------------
 2 files changed, 42 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/staging/iio/adc/lpc32xx-adc.txt
 delete mode 100644 Documentation/devicetree/bindings/staging/iio/adc/spear-adc.txt

-- 
2.14.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Viresh Kumar April 26, 2018, 5:32 a.m. | #1
@Thomas: Do you guys use this ?

On 25-04-18, 20:57, Rob Herring wrote:
> Remove LPC32xx and SPEAr ADC bindings in staging. They have not been

> touched since 2012.

> 

> Cc: Roland Stigge <stigge@antcom.de>

> Cc: Stefan Roese <sr@denx.de>

> Cc: Jonathan Cameron <jic23@kernel.org>

> Cc: Viresh Kumar <viresh.kumar@linaro.org>

> Signed-off-by: Rob Herring <robh@kernel.org>

> ---

> Move these out of staging please or they are going to be removed.

> 

>  .../bindings/staging/iio/adc/lpc32xx-adc.txt       | 16 -------------

>  .../bindings/staging/iio/adc/spear-adc.txt         | 26 ----------------------

>  2 files changed, 42 deletions(-)

>  delete mode 100644 Documentation/devicetree/bindings/staging/iio/adc/lpc32xx-adc.txt

>  delete mode 100644 Documentation/devicetree/bindings/staging/iio/adc/spear-adc.txt

> 

> diff --git a/Documentation/devicetree/bindings/staging/iio/adc/lpc32xx-adc.txt b/Documentation/devicetree/bindings/staging/iio/adc/lpc32xx-adc.txt

> deleted file mode 100644

> index b3629d3a9adf..000000000000

> --- a/Documentation/devicetree/bindings/staging/iio/adc/lpc32xx-adc.txt

> +++ /dev/null

> @@ -1,16 +0,0 @@

> -* NXP LPC32xx SoC ADC controller

> -

> -Required properties:

> -- compatible: must be "nxp,lpc3220-adc"

> -- reg: physical base address of the controller and length of memory mapped

> -  region.

> -- interrupts: The ADC interrupt

> -

> -Example:

> -

> -	adc@40048000 {

> -		compatible = "nxp,lpc3220-adc";

> -		reg = <0x40048000 0x1000>;

> -		interrupt-parent = <&mic>;

> -		interrupts = <39 0>;

> -	};

> diff --git a/Documentation/devicetree/bindings/staging/iio/adc/spear-adc.txt b/Documentation/devicetree/bindings/staging/iio/adc/spear-adc.txt

> deleted file mode 100644

> index 02ea23a63f20..000000000000

> --- a/Documentation/devicetree/bindings/staging/iio/adc/spear-adc.txt

> +++ /dev/null

> @@ -1,26 +0,0 @@

> -* ST SPEAr ADC device driver

> -

> -Required properties:

> -- compatible: Should be "st,spear600-adc"

> -- reg: Address and length of the register set for the device

> -- interrupt-parent: Should be the phandle for the interrupt controller

> -  that services interrupts for this device

> -- interrupts: Should contain the ADC interrupt

> -- sampling-frequency: Default sampling frequency

> -

> -Optional properties:

> -- vref-external: External voltage reference in milli-volts. If omitted

> -  the internal voltage reference will be used.

> -- average-samples: Number of samples to generate an average value. If

> -  omitted, single data conversion will be used.

> -

> -Examples:

> -

> -	adc: adc@d8200000 {

> -		compatible = "st,spear600-adc";

> -		reg = <0xd8200000 0x1000>;

> -		interrupt-parent = <&vic1>;

> -		interrupts = <6>;

> -		sampling-frequency = <5000000>;

> -		vref-external = <2500>;	/* 2.5V VRef */

> -	};

> -- 

> 2.14.1


-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Thomas Petazzoni April 26, 2018, 7:42 p.m. | #2
Hello,

On Thu, 26 Apr 2018 11:02:55 +0530, Viresh Kumar wrote:
> @Thomas: Do you guys use this ?

> 

> On 25-04-18, 20:57, Rob Herring wrote:

> > Remove LPC32xx and SPEAr ADC bindings in staging. They have not been

> > touched since 2012.

> > 

> > Cc: Roland Stigge <stigge@antcom.de>

> > Cc: Stefan Roese <sr@denx.de>

> > Cc: Jonathan Cameron <jic23@kernel.org>

> > Cc: Viresh Kumar <viresh.kumar@linaro.org>

> > Signed-off-by: Rob Herring <robh@kernel.org>

> > ---

> > Move these out of staging please or they are going to be removed.

> > 

> >  .../bindings/staging/iio/adc/lpc32xx-adc.txt       | 16 -------------

> >  .../bindings/staging/iio/adc/spear-adc.txt         | 26 ----------------------

> >  2 files changed, 42 deletions(-)


We are using the spear-adc driver, which is out of staging
in ./drivers/iio/adc/spear_adc.c. So rather than removing its DT binding
entirely, it should be moved out of staging.

I'm not using the LPC32xx ADC, but the IIO driver is also out of
staging, so for the same reason, it would be strange to remove the DT
binding.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Herring April 27, 2018, 2:13 a.m. | #3
On Thu, Apr 26, 2018 at 2:42 PM, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
> Hello,

>

> On Thu, 26 Apr 2018 11:02:55 +0530, Viresh Kumar wrote:

>> @Thomas: Do you guys use this ?

>>

>> On 25-04-18, 20:57, Rob Herring wrote:

>> > Remove LPC32xx and SPEAr ADC bindings in staging. They have not been

>> > touched since 2012.

>> >

>> > Cc: Roland Stigge <stigge@antcom.de>

>> > Cc: Stefan Roese <sr@denx.de>

>> > Cc: Jonathan Cameron <jic23@kernel.org>

>> > Cc: Viresh Kumar <viresh.kumar@linaro.org>

>> > Signed-off-by: Rob Herring <robh@kernel.org>

>> > ---

>> > Move these out of staging please or they are going to be removed.

>> >

>> >  .../bindings/staging/iio/adc/lpc32xx-adc.txt       | 16 -------------

>> >  .../bindings/staging/iio/adc/spear-adc.txt         | 26 ----------------------

>> >  2 files changed, 42 deletions(-)

>

> We are using the spear-adc driver, which is out of staging

> in ./drivers/iio/adc/spear_adc.c. So rather than removing its DT binding

> entirely, it should be moved out of staging.


Except I have comments on the spear binding and it's fair game to
change it being in staging, right?

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Thomas Petazzoni April 30, 2018, 9:24 a.m. | #4
Hello,

On Thu, 26 Apr 2018 21:13:17 -0500, Rob Herring wrote:

> >> >  .../bindings/staging/iio/adc/lpc32xx-adc.txt       | 16 -------------

> >> >  .../bindings/staging/iio/adc/spear-adc.txt         | 26 ----------------------

> >> >  2 files changed, 42 deletions(-)  

> >

> > We are using the spear-adc driver, which is out of staging

> > in ./drivers/iio/adc/spear_adc.c. So rather than removing its DT binding

> > entirely, it should be moved out of staging.  

> 

> Except I have comments on the spear binding and it's fair game to

> change it being in staging, right?


Sure, I don't care about binding changes. We ship the DT together with
the kernel on those SPEAr600 devices, so the DT backward compatibility
is totally useless for us, which allows to freely change the bindings.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/Documentation/devicetree/bindings/staging/iio/adc/lpc32xx-adc.txt b/Documentation/devicetree/bindings/staging/iio/adc/lpc32xx-adc.txt
deleted file mode 100644
index b3629d3a9adf..000000000000
--- a/Documentation/devicetree/bindings/staging/iio/adc/lpc32xx-adc.txt
+++ /dev/null
@@ -1,16 +0,0 @@ 
-* NXP LPC32xx SoC ADC controller
-
-Required properties:
-- compatible: must be "nxp,lpc3220-adc"
-- reg: physical base address of the controller and length of memory mapped
-  region.
-- interrupts: The ADC interrupt
-
-Example:
-
-	adc@40048000 {
-		compatible = "nxp,lpc3220-adc";
-		reg = <0x40048000 0x1000>;
-		interrupt-parent = <&mic>;
-		interrupts = <39 0>;
-	};
diff --git a/Documentation/devicetree/bindings/staging/iio/adc/spear-adc.txt b/Documentation/devicetree/bindings/staging/iio/adc/spear-adc.txt
deleted file mode 100644
index 02ea23a63f20..000000000000
--- a/Documentation/devicetree/bindings/staging/iio/adc/spear-adc.txt
+++ /dev/null
@@ -1,26 +0,0 @@ 
-* ST SPEAr ADC device driver
-
-Required properties:
-- compatible: Should be "st,spear600-adc"
-- reg: Address and length of the register set for the device
-- interrupt-parent: Should be the phandle for the interrupt controller
-  that services interrupts for this device
-- interrupts: Should contain the ADC interrupt
-- sampling-frequency: Default sampling frequency
-
-Optional properties:
-- vref-external: External voltage reference in milli-volts. If omitted
-  the internal voltage reference will be used.
-- average-samples: Number of samples to generate an average value. If
-  omitted, single data conversion will be used.
-
-Examples:
-
-	adc: adc@d8200000 {
-		compatible = "st,spear600-adc";
-		reg = <0xd8200000 0x1000>;
-		interrupt-parent = <&vic1>;
-		interrupts = <6>;
-		sampling-frequency = <5000000>;
-		vref-external = <2500>;	/* 2.5V VRef */
-	};