vl.c: Don't zero-initialize statics for serial_hds

Message ID 20180426140253.3918-1-peter.maydell@linaro.org
State Superseded
Headers show
Series
  • vl.c: Don't zero-initialize statics for serial_hds
Related show

Commit Message

Peter Maydell April 26, 2018, 2:02 p.m.
checkpatch reminds us that statics shouldn't be zero-initialized:

ERROR: do not initialise statics to 0 or NULL
#35: FILE: vl.c:157:
+static int num_serial_hds = 0;

ERROR: do not initialise statics to 0 or NULL
#36: FILE: vl.c:158:
+static Chardev **serial_hds = NULL;

I forgot to fix this in 6af2692e86f9fdfb3d; do so now.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

---
I wouldn't bother with this except that I forgot to fold
it in when applying the serial-limits patchset.

 vl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.17.0

Comments

Thomas Huth April 26, 2018, 2:19 p.m. | #1
On 26.04.2018 16:02, Peter Maydell wrote:
> checkpatch reminds us that statics shouldn't be zero-initialized:

> 

> ERROR: do not initialise statics to 0 or NULL

> #35: FILE: vl.c:157:

> +static int num_serial_hds = 0;

> 

> ERROR: do not initialise statics to 0 or NULL

> #36: FILE: vl.c:158:

> +static Chardev **serial_hds = NULL;

> 

> I forgot to fix this in 6af2692e86f9fdfb3d; do so now.

> 

> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

> ---

> I wouldn't bother with this except that I forgot to fold

> it in when applying the serial-limits patchset.

> 

>  vl.c | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/vl.c b/vl.c

> index 616956adf1..6d8b869dad 100644

> --- a/vl.c

> +++ b/vl.c

> @@ -154,8 +154,8 @@ QEMUClockType rtc_clock;

>  int vga_interface_type = VGA_NONE;

>  static DisplayOptions dpy;

>  int no_frame;

> -static int num_serial_hds = 0;

> -static Chardev **serial_hds = NULL;

> +static int num_serial_hds;

> +static Chardev **serial_hds;

>  Chardev *parallel_hds[MAX_PARALLEL_PORTS];

>  Chardev *virtcon_hds[MAX_VIRTIO_CONSOLES];

>  Chardev *sclp_hds[MAX_SCLP_CONSOLES];

> 


Reviewed-by: Thomas Huth <thuth@redhat.com>
Peter Maydell May 29, 2018, 3:25 p.m. | #2
Ping for application via qemu-trivial?

thanks
-- PMM

On 26 April 2018 at 15:19, Thomas Huth <thuth@redhat.com> wrote:
> On 26.04.2018 16:02, Peter Maydell wrote:

>> checkpatch reminds us that statics shouldn't be zero-initialized:

>>

>> ERROR: do not initialise statics to 0 or NULL

>> #35: FILE: vl.c:157:

>> +static int num_serial_hds = 0;

>>

>> ERROR: do not initialise statics to 0 or NULL

>> #36: FILE: vl.c:158:

>> +static Chardev **serial_hds = NULL;

>>

>> I forgot to fix this in 6af2692e86f9fdfb3d; do so now.

>>

>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

>> ---

>> I wouldn't bother with this except that I forgot to fold

>> it in when applying the serial-limits patchset.

>>

>>  vl.c | 4 ++--

>>  1 file changed, 2 insertions(+), 2 deletions(-)

>>

>> diff --git a/vl.c b/vl.c

>> index 616956adf1..6d8b869dad 100644

>> --- a/vl.c

>> +++ b/vl.c

>> @@ -154,8 +154,8 @@ QEMUClockType rtc_clock;

>>  int vga_interface_type = VGA_NONE;

>>  static DisplayOptions dpy;

>>  int no_frame;

>> -static int num_serial_hds = 0;

>> -static Chardev **serial_hds = NULL;

>> +static int num_serial_hds;

>> +static Chardev **serial_hds;

>>  Chardev *parallel_hds[MAX_PARALLEL_PORTS];

>>  Chardev *virtcon_hds[MAX_VIRTIO_CONSOLES];

>>  Chardev *sclp_hds[MAX_SCLP_CONSOLES];

>>

>

> Reviewed-by: Thomas Huth <thuth@redhat.com>
Peter Maydell June 11, 2018, 1:56 p.m. | #3
Ping^2 for qemu-trivial?

thanks
-- PMM

On 29 May 2018 at 16:25, Peter Maydell <peter.maydell@linaro.org> wrote:
> Ping for application via qemu-trivial?

>

> thanks

> -- PMM

>

> On 26 April 2018 at 15:19, Thomas Huth <thuth@redhat.com> wrote:

>> On 26.04.2018 16:02, Peter Maydell wrote:

>>> checkpatch reminds us that statics shouldn't be zero-initialized:

>>>

>>> ERROR: do not initialise statics to 0 or NULL

>>> #35: FILE: vl.c:157:

>>> +static int num_serial_hds = 0;

>>>

>>> ERROR: do not initialise statics to 0 or NULL

>>> #36: FILE: vl.c:158:

>>> +static Chardev **serial_hds = NULL;

>>>

>>> I forgot to fix this in 6af2692e86f9fdfb3d; do so now.

>>>

>>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

>>> ---

>>> I wouldn't bother with this except that I forgot to fold

>>> it in when applying the serial-limits patchset.

>>>

>>>  vl.c | 4 ++--

>>>  1 file changed, 2 insertions(+), 2 deletions(-)

>>>

>>> diff --git a/vl.c b/vl.c

>>> index 616956adf1..6d8b869dad 100644

>>> --- a/vl.c

>>> +++ b/vl.c

>>> @@ -154,8 +154,8 @@ QEMUClockType rtc_clock;

>>>  int vga_interface_type = VGA_NONE;

>>>  static DisplayOptions dpy;

>>>  int no_frame;

>>> -static int num_serial_hds = 0;

>>> -static Chardev **serial_hds = NULL;

>>> +static int num_serial_hds;

>>> +static Chardev **serial_hds;

>>>  Chardev *parallel_hds[MAX_PARALLEL_PORTS];

>>>  Chardev *virtcon_hds[MAX_VIRTIO_CONSOLES];

>>>  Chardev *sclp_hds[MAX_SCLP_CONSOLES];

>>>

>>

>> Reviewed-by: Thomas Huth <thuth@redhat.com>
Peter Maydell June 22, 2018, 12:58 p.m. | #4
On 11 June 2018 at 14:56, Peter Maydell <peter.maydell@linaro.org> wrote:
> Ping^2 for qemu-trivial?


Gave up and threw it into the latest target-arm pullreq :-)

thanks
-- PMM

Patch

diff --git a/vl.c b/vl.c
index 616956adf1..6d8b869dad 100644
--- a/vl.c
+++ b/vl.c
@@ -154,8 +154,8 @@  QEMUClockType rtc_clock;
 int vga_interface_type = VGA_NONE;
 static DisplayOptions dpy;
 int no_frame;
-static int num_serial_hds = 0;
-static Chardev **serial_hds = NULL;
+static int num_serial_hds;
+static Chardev **serial_hds;
 Chardev *parallel_hds[MAX_PARALLEL_PORTS];
 Chardev *virtcon_hds[MAX_VIRTIO_CONSOLES];
 Chardev *sclp_hds[MAX_SCLP_CONSOLES];