[edk2,edk2-platforms,2/5] Platform/Socionext/DeveloperBox: add SNP driver

Message ID 20180427113748.21663-3-ard.biesheuvel@linaro.org
State New
Headers show
Series
  • assorted SynQuacer updates
Related show

Commit Message

Ard Biesheuvel April 27, 2018, 11:37 a.m.
Even though the builtin NETSEC controller driver implements the Simple
Network Protocol (SNP) directly, other network controllers connected
via PCIe may be supported by a UNDI driver, which require the generic
SnpDxe driver in order to be usable.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 +
 Platform/Socionext/DeveloperBox/DeveloperBox.fdf | 1 +
 2 files changed, 2 insertions(+)

-- 
2.17.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm May 22, 2018, 3:04 p.m. | #1
To save me making a triple-take when I see this commit in the log in
future, could you change the subject to say SnpDxe instead of SNP?

If so, for the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>


On Fri, Apr 27, 2018 at 01:37:45PM +0200, Ard Biesheuvel wrote:
> Even though the builtin NETSEC controller driver implements the Simple

> Network Protocol (SNP) directly, other network controllers connected

> via PCIe may be supported by a UNDI driver, which require the generic

> SnpDxe driver in order to be usable.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---

>  Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 +

>  Platform/Socionext/DeveloperBox/DeveloperBox.fdf | 1 +

>  2 files changed, 2 insertions(+)

> 

> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc

> index cc36c2ed1772..430c3fb06df1 100644

> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc

> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc

> @@ -633,6 +633,7 @@ [Components.common]

>    MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf

>    MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf

>    MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf

> +  MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf

>    MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf

>    MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf

>    MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf

> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.fdf b/Platform/Socionext/DeveloperBox/DeveloperBox.fdf

> index 2da83850975b..1b8de4c3823a 100644

> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.fdf

> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.fdf

> @@ -203,6 +203,7 @@ [FV.FvMain]

>    INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf

>    INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf

>    INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf

> +  INF MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf

>    INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf

>    INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf

>    INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf

> -- 

> 2.17.0

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
index cc36c2ed1772..430c3fb06df1 100644
--- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
+++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
@@ -633,6 +633,7 @@  [Components.common]
   MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
   MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
   MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf
+  MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf
   MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf
   MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
   MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf
diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.fdf b/Platform/Socionext/DeveloperBox/DeveloperBox.fdf
index 2da83850975b..1b8de4c3823a 100644
--- a/Platform/Socionext/DeveloperBox/DeveloperBox.fdf
+++ b/Platform/Socionext/DeveloperBox/DeveloperBox.fdf
@@ -203,6 +203,7 @@  [FV.FvMain]
   INF MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf
   INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf
   INF MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf
+  INF MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf
   INF MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf
   INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf
   INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf