From patchwork Tue Apr 24 15:51:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jyri Sarha X-Patchwork-Id: 134783 Delivered-To: patch@linaro.org Received: by 10.46.151.6 with SMTP id r6csp4976023lji; Tue, 1 May 2018 06:44:37 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpIuvplt6UzAfuxHsWuGCjaUsn3NHmuychjuuZbATn5stI4CmtUGvtnpMMUXz+POqDcJWw0 X-Received: by 2002:a17:902:9a4b:: with SMTP id x11-v6mr1401893plv.176.1525182277823; Tue, 01 May 2018 06:44:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525182277; cv=none; d=google.com; s=arc-20160816; b=TlSn2d9xJnJ/Bo0V3KpwcYVdXyXZ6SMhtYPLoCxyiGBaMAz6GW6JDKqOMjWGhWr9Xn qecIVt8tlKRmuhGvQ9boFw5hYQKOG+BkWyaDjEl+weeJbyFLTdiHsKFeVjuv6BY1+5zR p+5TkvjljQRxzsad3zSHIiF/ZNk1TvhQtC7qkYWeTUdojtUrLTjCpsfBd6d7+KWnHPAT bncg+r2A6o3ahNaFvDIFZndUrcTFzhRuG/L1t7HPeul2B+VSnL9jCRbkolLEOajiE7p/ gv7N41nRNmAb8U+4b3RH7+lTzvSguCfwt7c/E6pXQkDR9mlnAe0hLO6ACxPQK73PhUPt sVbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to :arc-authentication-results; bh=+EKWksz38MUsqc5Boi0W28pTXmZ/Y79OqdrWMoaIcu0=; b=ShSnU9K7KzcxSVnkWzbIx20oj8aZIffS6tj8/iEge9Q2B1ugplus6WCb+oGHbZkP2s V3nYz1PmlPeAHVLzyG2bXI3YJsgDjKrneEw9OqLhJzv9BK08XWg2CyW6p0a5OGSLniBt KC5JiDH3toTzWEQ9cILekB3nitThkl9yOZ4mNRz0B7zJ01xZC5ReuX0+XA6KonBzVpbG 39yKxOO3ZTMqScup9lfC6wdx/sE9+cxc/m1YoAv3gmzILDi4LaBfdmJg/Ncj7jLa7Dma MEtFI4zVEHkvfm142K6pY123YtQQMq07tNNWEkH+iKAxZGfKUrs9Bs68BfEnF6XZ+DS0 noow== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=nWCFiDg0; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id o18si9665005pfa.346.2018.05.01.06.44.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 May 2018 06:44:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@ti.com header.s=ti-com-17Q1 header.b=nWCFiDg0; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EA46289823; Tue, 1 May 2018 13:44:35 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from lelnx193.ext.ti.com (lelnx193.ext.ti.com [198.47.27.77]) by gabe.freedesktop.org (Postfix) with ESMTPS id F315B89811 for ; Tue, 1 May 2018 13:44:34 +0000 (UTC) Received: from dflxv15.itg.ti.com ([128.247.5.124]) by lelnx193.ext.ti.com (8.15.1/8.15.1) with ESMTP id w3OFpLje027809; Tue, 24 Apr 2018 10:51:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1524585081; bh=w1XQeNxwavyMx+skbuHv8AY2LkEckcCEzargXPM32LY=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=nWCFiDg03KF1+N6r8F9mJ1pgC7UIjM2tL37vcV78J5DJdbfWQ0qS9ecXSDl62zzCw Zodk2wTdN5YmmS3pBqfvTaJmwqCFtXYu5CBk+vT2TfKFSUKCE2YrbYPcr9X8v6VF7D w8dg9hYwI3pgnaBhK0Sgu+ocR/dGP5iwU6TzY90c= Received: from DLEE113.ent.ti.com (dlee113.ent.ti.com [157.170.170.24]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id w3OFpLau007420; Tue, 24 Apr 2018 10:51:21 -0500 Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE113.ent.ti.com (157.170.170.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Tue, 24 Apr 2018 10:51:21 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Tue, 24 Apr 2018 10:51:21 -0500 Received: from jadmar.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id w3OFpDwD022588; Tue, 24 Apr 2018 10:51:19 -0500 From: Jyri Sarha To: Subject: [PATCH v3 2/2] drm/panel: Add device_link from panel device to drm device Date: Tue, 24 Apr 2018 18:51:08 +0300 Message-ID: <0ff9cd8d5ee3156e0bcdcc0483a251ce8ccc89e4.1524576910.git.jsarha@ti.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, linux@armlinux.org.uk, Jyri Sarha , tomi.valkeinen@ti.com, thierry.reding@gmail.com, laurent.pinchart@ideasonboard.com, peda@axentia.se Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Add device_link from panel device (supplier) to drm device (consumer) when drm_panel_attach() is called. This patch should protect the master drm driver if an attached panel driver unbinds while it is in use. The device_link should make sure the drm device is unbound before the panel driver becomes unavailable. The device_link is removed when drm_panel_detach() is called. The drm_panel_detach() should be called by the consumer DRM driver, not the panel driver, otherwise both drivers are racing to delete the same link. Signed-off-by: Jyri Sarha Reviewed-by: Eric Anholt --- drivers/gpu/drm/drm_panel.c | 10 ++++++++++ include/drm/drm_panel.h | 1 + 2 files changed, 11 insertions(+) diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c index 29d2c74..7474045 100644 --- a/drivers/gpu/drm/drm_panel.c +++ b/drivers/gpu/drm/drm_panel.c @@ -24,6 +24,7 @@ #include #include +#include #include #include @@ -101,6 +102,13 @@ int drm_panel_attach(struct drm_panel *panel, struct drm_connector *connector) if (panel->connector) return -EBUSY; + panel->link = device_link_add(connector->dev->dev, panel->dev, 0); + if (!panel->link) { + dev_err(panel->dev, "failed to link panel to %s\n", + dev_name(connector->dev->dev)); + return -EINVAL; + } + panel->connector = connector; panel->drm = connector->dev; @@ -123,6 +131,8 @@ EXPORT_SYMBOL(drm_panel_attach); */ int drm_panel_detach(struct drm_panel *panel) { + device_link_del(panel->link); + panel->connector = NULL; panel->drm = NULL; diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h index 14ac240..26a1b5f 100644 --- a/include/drm/drm_panel.h +++ b/include/drm/drm_panel.h @@ -89,6 +89,7 @@ struct drm_panel { struct drm_device *drm; struct drm_connector *connector; struct device *dev; + struct device_link *link; const struct drm_panel_funcs *funcs;