[edk2,edk2-platforms] Silicon/AMD/Styx/AcpiTables: fix wrongly copy/pasted variable name

Message ID 20180501163244.17402-1-ard.biesheuvel@linaro.org
State New
Headers show
Series
  • [edk2,edk2-platforms] Silicon/AMD/Styx/AcpiTables: fix wrongly copy/pasted variable name
Related show

Commit Message

Ard Biesheuvel May 1, 2018, 4:32 p.m.
Rename the variable holding the Styx PPTT table to mStyxPpttTable.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 Silicon/AMD/Styx/AcpiTables/Pptt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.17.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm May 1, 2018, 5:55 p.m. | #1
On Tue, May 01, 2018 at 06:32:44PM +0200, Ard Biesheuvel wrote:
> Rename the variable holding the Styx PPTT table to mStyxPpttTable.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>


Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>


> ---

>  Silicon/AMD/Styx/AcpiTables/Pptt.c | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/Silicon/AMD/Styx/AcpiTables/Pptt.c b/Silicon/AMD/Styx/AcpiTables/Pptt.c

> index d9d7c494d86f..1746bbe8b596 100644

> --- a/Silicon/AMD/Styx/AcpiTables/Pptt.c

> +++ b/Silicon/AMD/Styx/AcpiTables/Pptt.c

> @@ -156,7 +156,7 @@ typedef struct {

>    }                                                                           \

>  }

>  

> -STATIC STYX_PPTT_TABLE mSynQuacerPpttTable = {

> +STATIC STYX_PPTT_TABLE mStyxPpttTable = {

>    {

>      AMD_ACPI_HEADER(EFI_ACPI_6_2_PROCESSOR_PROPERTIES_TOPOLOGY_TABLE_STRUCTURE_SIGNATURE,

>                      STYX_PPTT_TABLE,

> @@ -221,5 +221,5 @@ PpttHeader (

>    VOID

>    )

>  {

> -  return (EFI_ACPI_DESCRIPTION_HEADER *)&mSynQuacerPpttTable.Pptt.Header;

> +  return (EFI_ACPI_DESCRIPTION_HEADER *)&mStyxPpttTable.Pptt.Header;

>  }

> -- 

> 2.17.0

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel May 2, 2018, 8:07 a.m. | #2
On 1 May 2018 at 19:55, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Tue, May 01, 2018 at 06:32:44PM +0200, Ard Biesheuvel wrote:

>> Rename the variable holding the Styx PPTT table to mStyxPpttTable.

>>

>> Contributed-under: TianoCore Contribution Agreement 1.1

>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

>

> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

>


Thanks. Pushed as 0db6171fb5a63e8d58ee7cfdecf36f5c57ce9315

>> ---

>>  Silicon/AMD/Styx/AcpiTables/Pptt.c | 4 ++--

>>  1 file changed, 2 insertions(+), 2 deletions(-)

>>

>> diff --git a/Silicon/AMD/Styx/AcpiTables/Pptt.c b/Silicon/AMD/Styx/AcpiTables/Pptt.c

>> index d9d7c494d86f..1746bbe8b596 100644

>> --- a/Silicon/AMD/Styx/AcpiTables/Pptt.c

>> +++ b/Silicon/AMD/Styx/AcpiTables/Pptt.c

>> @@ -156,7 +156,7 @@ typedef struct {

>>    }                                                                           \

>>  }

>>

>> -STATIC STYX_PPTT_TABLE mSynQuacerPpttTable = {

>> +STATIC STYX_PPTT_TABLE mStyxPpttTable = {

>>    {

>>      AMD_ACPI_HEADER(EFI_ACPI_6_2_PROCESSOR_PROPERTIES_TOPOLOGY_TABLE_STRUCTURE_SIGNATURE,

>>                      STYX_PPTT_TABLE,

>> @@ -221,5 +221,5 @@ PpttHeader (

>>    VOID

>>    )

>>  {

>> -  return (EFI_ACPI_DESCRIPTION_HEADER *)&mSynQuacerPpttTable.Pptt.Header;

>> +  return (EFI_ACPI_DESCRIPTION_HEADER *)&mStyxPpttTable.Pptt.Header;

>>  }

>> --

>> 2.17.0

>>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/Silicon/AMD/Styx/AcpiTables/Pptt.c b/Silicon/AMD/Styx/AcpiTables/Pptt.c
index d9d7c494d86f..1746bbe8b596 100644
--- a/Silicon/AMD/Styx/AcpiTables/Pptt.c
+++ b/Silicon/AMD/Styx/AcpiTables/Pptt.c
@@ -156,7 +156,7 @@  typedef struct {
   }                                                                           \
 }
 
-STATIC STYX_PPTT_TABLE mSynQuacerPpttTable = {
+STATIC STYX_PPTT_TABLE mStyxPpttTable = {
   {
     AMD_ACPI_HEADER(EFI_ACPI_6_2_PROCESSOR_PROPERTIES_TOPOLOGY_TABLE_STRUCTURE_SIGNATURE,
                     STYX_PPTT_TABLE,
@@ -221,5 +221,5 @@  PpttHeader (
   VOID
   )
 {
-  return (EFI_ACPI_DESCRIPTION_HEADER *)&mSynQuacerPpttTable.Pptt.Header;
+  return (EFI_ACPI_DESCRIPTION_HEADER *)&mStyxPpttTable.Pptt.Header;
 }