[v2] media: v4l: Add new 10-bit packed grayscale format

Message ID 1525769177-6328-1-git-send-email-todor.tomov@linaro.org
State Superseded
Headers show
Series
  • [v2] media: v4l: Add new 10-bit packed grayscale format
Related show

Commit Message

Todor Tomov May 8, 2018, 8:46 a.m.
The new format will be called V4L2_PIX_FMT_Y10P.
It is similar to the V4L2_PIX_FMT_SBGGR10P family formats
but V4L2_PIX_FMT_Y10P is a grayscale format.

Signed-off-by: Todor Tomov <todor.tomov@linaro.org>

---

v2:
- doc: improved bit-packed representation: added bit positions for LSB bits;
- doc: improved bit-packed representation: added table column widths.

 Documentation/media/uapi/v4l/pixfmt-y10p.rst | 33 ++++++++++++++++++++++++++++
 Documentation/media/uapi/v4l/yuv-formats.rst |  1 +
 drivers/media/v4l2-core/v4l2-ioctl.c         |  1 +
 include/uapi/linux/videodev2.h               |  1 +
 4 files changed, 36 insertions(+)
 create mode 100644 Documentation/media/uapi/v4l/pixfmt-y10p.rst

-- 
2.7.4

Comments

Hans Verkuil June 8, 2018, 8:13 a.m. | #1
On 05/08/2018 10:46 AM, Todor Tomov wrote:
> The new format will be called V4L2_PIX_FMT_Y10P.

> It is similar to the V4L2_PIX_FMT_SBGGR10P family formats

> but V4L2_PIX_FMT_Y10P is a grayscale format.

> 

> Signed-off-by: Todor Tomov <todor.tomov@linaro.org>


I see no patch adding support for this to a driver. We don't like adding new
defines without a driver that needs it.

Is it possible to add support for this to a mainlined driver? Or is it going to
be used by a new driver?

Regards,

	Hans

> ---

> 

> v2:

> - doc: improved bit-packed representation: added bit positions for LSB bits;

> - doc: improved bit-packed representation: added table column widths.

> 

>  Documentation/media/uapi/v4l/pixfmt-y10p.rst | 33 ++++++++++++++++++++++++++++

>  Documentation/media/uapi/v4l/yuv-formats.rst |  1 +

>  drivers/media/v4l2-core/v4l2-ioctl.c         |  1 +

>  include/uapi/linux/videodev2.h               |  1 +

>  4 files changed, 36 insertions(+)

>  create mode 100644 Documentation/media/uapi/v4l/pixfmt-y10p.rst

> 

> diff --git a/Documentation/media/uapi/v4l/pixfmt-y10p.rst b/Documentation/media/uapi/v4l/pixfmt-y10p.rst

> new file mode 100644

> index 0000000..13b5713

> --- /dev/null

> +++ b/Documentation/media/uapi/v4l/pixfmt-y10p.rst

> @@ -0,0 +1,33 @@

> +.. -*- coding: utf-8; mode: rst -*-

> +

> +.. _V4L2-PIX-FMT-Y10P:

> +

> +******************************

> +V4L2_PIX_FMT_Y10P ('Y10P')

> +******************************

> +

> +Grey-scale image as a MIPI RAW10 packed array

> +

> +

> +Description

> +===========

> +

> +This is a packed grey-scale image format with a depth of 10 bits per

> +pixel. Every four consecutive pixels are packed into 5 bytes. Each of

> +the first 4 bytes contain the 8 high order bits of the pixels, and

> +the 5th byte contains the 2 least significants bits of each pixel,

> +in the same order.

> +

> +**Bit-packed representation.**

> +

> +.. flat-table::

> +    :header-rows:  0

> +    :stub-columns: 0

> +    :widths: 8 8 8 8 64

> +

> +    * - Y'\ :sub:`00[9:2]`

> +      - Y'\ :sub:`01[9:2]`

> +      - Y'\ :sub:`02[9:2]`

> +      - Y'\ :sub:`03[9:2]`

> +      - Y'\ :sub:`03[1:0]`\ (bits 7--6) Y'\ :sub:`02[1:0]`\ (bits 5--4)

> +	Y'\ :sub:`01[1:0]`\ (bits 3--2) Y'\ :sub:`00[1:0]`\ (bits 1--0)

> diff --git a/Documentation/media/uapi/v4l/yuv-formats.rst b/Documentation/media/uapi/v4l/yuv-formats.rst

> index 3334ea4..9ab0592 100644

> --- a/Documentation/media/uapi/v4l/yuv-formats.rst

> +++ b/Documentation/media/uapi/v4l/yuv-formats.rst

> @@ -29,6 +29,7 @@ to brightness information.

>      pixfmt-y10

>      pixfmt-y12

>      pixfmt-y10b

> +    pixfmt-y10p

>      pixfmt-y16

>      pixfmt-y16-be

>      pixfmt-y8i

> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c

> index de5d96d..dececea 100644

> --- a/drivers/media/v4l2-core/v4l2-ioctl.c

> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c

> @@ -1147,6 +1147,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)

>  	case V4L2_PIX_FMT_Y16:		descr = "16-bit Greyscale"; break;

>  	case V4L2_PIX_FMT_Y16_BE:	descr = "16-bit Greyscale BE"; break;

>  	case V4L2_PIX_FMT_Y10BPACK:	descr = "10-bit Greyscale (Packed)"; break;

> +	case V4L2_PIX_FMT_Y10P:		descr = "10-bit Greyscale (MIPI Packed)"; break;

>  	case V4L2_PIX_FMT_Y8I:		descr = "Interleaved 8-bit Greyscale"; break;

>  	case V4L2_PIX_FMT_Y12I:		descr = "Interleaved 12-bit Greyscale"; break;

>  	case V4L2_PIX_FMT_Z16:		descr = "16-bit Depth"; break;

> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h

> index 600877b..b24ab720 100644

> --- a/include/uapi/linux/videodev2.h

> +++ b/include/uapi/linux/videodev2.h

> @@ -522,6 +522,7 @@ struct v4l2_pix_format {

>  

>  /* Grey bit-packed formats */

>  #define V4L2_PIX_FMT_Y10BPACK    v4l2_fourcc('Y', '1', '0', 'B') /* 10  Greyscale bit-packed */

> +#define V4L2_PIX_FMT_Y10P    v4l2_fourcc('Y', '1', '0', 'P') /* 10  Greyscale, MIPI RAW10 packed */

>  

>  /* Palette formats */

>  #define V4L2_PIX_FMT_PAL8    v4l2_fourcc('P', 'A', 'L', '8') /*  8  8-bit palette */

>
Todor Tomov June 8, 2018, 8:19 a.m. | #2
Hi Hans,

On  8.06.2018 11:13, Hans Verkuil wrote:
> On 05/08/2018 10:46 AM, Todor Tomov wrote:

>> The new format will be called V4L2_PIX_FMT_Y10P.

>> It is similar to the V4L2_PIX_FMT_SBGGR10P family formats

>> but V4L2_PIX_FMT_Y10P is a grayscale format.

>>

>> Signed-off-by: Todor Tomov <todor.tomov@linaro.org>

> 

> I see no patch adding support for this to a driver. We don't like adding new

> defines without a driver that needs it.

> 

> Is it possible to add support for this to a mainlined driver? Or is it going to

> be used by a new driver?


This will be used by a new version of the QComm CAMSS driver. I wanted to get it
reviewed first.
If it is ok, you could take it when the new QComm CAMSS is posted and accepted.

Best regards,
Todor

> 

> Regards,

> 

> 	Hans

> 

>> ---

>>

>> v2:

>> - doc: improved bit-packed representation: added bit positions for LSB bits;

>> - doc: improved bit-packed representation: added table column widths.

>>

>>  Documentation/media/uapi/v4l/pixfmt-y10p.rst | 33 ++++++++++++++++++++++++++++

>>  Documentation/media/uapi/v4l/yuv-formats.rst |  1 +

>>  drivers/media/v4l2-core/v4l2-ioctl.c         |  1 +

>>  include/uapi/linux/videodev2.h               |  1 +

>>  4 files changed, 36 insertions(+)

>>  create mode 100644 Documentation/media/uapi/v4l/pixfmt-y10p.rst

>>

>> diff --git a/Documentation/media/uapi/v4l/pixfmt-y10p.rst b/Documentation/media/uapi/v4l/pixfmt-y10p.rst

>> new file mode 100644

>> index 0000000..13b5713

>> --- /dev/null

>> +++ b/Documentation/media/uapi/v4l/pixfmt-y10p.rst

>> @@ -0,0 +1,33 @@

>> +.. -*- coding: utf-8; mode: rst -*-

>> +

>> +.. _V4L2-PIX-FMT-Y10P:

>> +

>> +******************************

>> +V4L2_PIX_FMT_Y10P ('Y10P')

>> +******************************

>> +

>> +Grey-scale image as a MIPI RAW10 packed array

>> +

>> +

>> +Description

>> +===========

>> +

>> +This is a packed grey-scale image format with a depth of 10 bits per

>> +pixel. Every four consecutive pixels are packed into 5 bytes. Each of

>> +the first 4 bytes contain the 8 high order bits of the pixels, and

>> +the 5th byte contains the 2 least significants bits of each pixel,

>> +in the same order.

>> +

>> +**Bit-packed representation.**

>> +

>> +.. flat-table::

>> +    :header-rows:  0

>> +    :stub-columns: 0

>> +    :widths: 8 8 8 8 64

>> +

>> +    * - Y'\ :sub:`00[9:2]`

>> +      - Y'\ :sub:`01[9:2]`

>> +      - Y'\ :sub:`02[9:2]`

>> +      - Y'\ :sub:`03[9:2]`

>> +      - Y'\ :sub:`03[1:0]`\ (bits 7--6) Y'\ :sub:`02[1:0]`\ (bits 5--4)

>> +	Y'\ :sub:`01[1:0]`\ (bits 3--2) Y'\ :sub:`00[1:0]`\ (bits 1--0)

>> diff --git a/Documentation/media/uapi/v4l/yuv-formats.rst b/Documentation/media/uapi/v4l/yuv-formats.rst

>> index 3334ea4..9ab0592 100644

>> --- a/Documentation/media/uapi/v4l/yuv-formats.rst

>> +++ b/Documentation/media/uapi/v4l/yuv-formats.rst

>> @@ -29,6 +29,7 @@ to brightness information.

>>      pixfmt-y10

>>      pixfmt-y12

>>      pixfmt-y10b

>> +    pixfmt-y10p

>>      pixfmt-y16

>>      pixfmt-y16-be

>>      pixfmt-y8i

>> diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c

>> index de5d96d..dececea 100644

>> --- a/drivers/media/v4l2-core/v4l2-ioctl.c

>> +++ b/drivers/media/v4l2-core/v4l2-ioctl.c

>> @@ -1147,6 +1147,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)

>>  	case V4L2_PIX_FMT_Y16:		descr = "16-bit Greyscale"; break;

>>  	case V4L2_PIX_FMT_Y16_BE:	descr = "16-bit Greyscale BE"; break;

>>  	case V4L2_PIX_FMT_Y10BPACK:	descr = "10-bit Greyscale (Packed)"; break;

>> +	case V4L2_PIX_FMT_Y10P:		descr = "10-bit Greyscale (MIPI Packed)"; break;

>>  	case V4L2_PIX_FMT_Y8I:		descr = "Interleaved 8-bit Greyscale"; break;

>>  	case V4L2_PIX_FMT_Y12I:		descr = "Interleaved 12-bit Greyscale"; break;

>>  	case V4L2_PIX_FMT_Z16:		descr = "16-bit Depth"; break;

>> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h

>> index 600877b..b24ab720 100644

>> --- a/include/uapi/linux/videodev2.h

>> +++ b/include/uapi/linux/videodev2.h

>> @@ -522,6 +522,7 @@ struct v4l2_pix_format {

>>  

>>  /* Grey bit-packed formats */

>>  #define V4L2_PIX_FMT_Y10BPACK    v4l2_fourcc('Y', '1', '0', 'B') /* 10  Greyscale bit-packed */

>> +#define V4L2_PIX_FMT_Y10P    v4l2_fourcc('Y', '1', '0', 'P') /* 10  Greyscale, MIPI RAW10 packed */

>>  

>>  /* Palette formats */

>>  #define V4L2_PIX_FMT_PAL8    v4l2_fourcc('P', 'A', 'L', '8') /*  8  8-bit palette */

>>

>

Patch

diff --git a/Documentation/media/uapi/v4l/pixfmt-y10p.rst b/Documentation/media/uapi/v4l/pixfmt-y10p.rst
new file mode 100644
index 0000000..13b5713
--- /dev/null
+++ b/Documentation/media/uapi/v4l/pixfmt-y10p.rst
@@ -0,0 +1,33 @@ 
+.. -*- coding: utf-8; mode: rst -*-
+
+.. _V4L2-PIX-FMT-Y10P:
+
+******************************
+V4L2_PIX_FMT_Y10P ('Y10P')
+******************************
+
+Grey-scale image as a MIPI RAW10 packed array
+
+
+Description
+===========
+
+This is a packed grey-scale image format with a depth of 10 bits per
+pixel. Every four consecutive pixels are packed into 5 bytes. Each of
+the first 4 bytes contain the 8 high order bits of the pixels, and
+the 5th byte contains the 2 least significants bits of each pixel,
+in the same order.
+
+**Bit-packed representation.**
+
+.. flat-table::
+    :header-rows:  0
+    :stub-columns: 0
+    :widths: 8 8 8 8 64
+
+    * - Y'\ :sub:`00[9:2]`
+      - Y'\ :sub:`01[9:2]`
+      - Y'\ :sub:`02[9:2]`
+      - Y'\ :sub:`03[9:2]`
+      - Y'\ :sub:`03[1:0]`\ (bits 7--6) Y'\ :sub:`02[1:0]`\ (bits 5--4)
+	Y'\ :sub:`01[1:0]`\ (bits 3--2) Y'\ :sub:`00[1:0]`\ (bits 1--0)
diff --git a/Documentation/media/uapi/v4l/yuv-formats.rst b/Documentation/media/uapi/v4l/yuv-formats.rst
index 3334ea4..9ab0592 100644
--- a/Documentation/media/uapi/v4l/yuv-formats.rst
+++ b/Documentation/media/uapi/v4l/yuv-formats.rst
@@ -29,6 +29,7 @@  to brightness information.
     pixfmt-y10
     pixfmt-y12
     pixfmt-y10b
+    pixfmt-y10p
     pixfmt-y16
     pixfmt-y16-be
     pixfmt-y8i
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c
index de5d96d..dececea 100644
--- a/drivers/media/v4l2-core/v4l2-ioctl.c
+++ b/drivers/media/v4l2-core/v4l2-ioctl.c
@@ -1147,6 +1147,7 @@  static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt)
 	case V4L2_PIX_FMT_Y16:		descr = "16-bit Greyscale"; break;
 	case V4L2_PIX_FMT_Y16_BE:	descr = "16-bit Greyscale BE"; break;
 	case V4L2_PIX_FMT_Y10BPACK:	descr = "10-bit Greyscale (Packed)"; break;
+	case V4L2_PIX_FMT_Y10P:		descr = "10-bit Greyscale (MIPI Packed)"; break;
 	case V4L2_PIX_FMT_Y8I:		descr = "Interleaved 8-bit Greyscale"; break;
 	case V4L2_PIX_FMT_Y12I:		descr = "Interleaved 12-bit Greyscale"; break;
 	case V4L2_PIX_FMT_Z16:		descr = "16-bit Depth"; break;
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index 600877b..b24ab720 100644
--- a/include/uapi/linux/videodev2.h
+++ b/include/uapi/linux/videodev2.h
@@ -522,6 +522,7 @@  struct v4l2_pix_format {
 
 /* Grey bit-packed formats */
 #define V4L2_PIX_FMT_Y10BPACK    v4l2_fourcc('Y', '1', '0', 'B') /* 10  Greyscale bit-packed */
+#define V4L2_PIX_FMT_Y10P    v4l2_fourcc('Y', '1', '0', 'P') /* 10  Greyscale, MIPI RAW10 packed */
 
 /* Palette formats */
 #define V4L2_PIX_FMT_PAL8    v4l2_fourcc('P', 'A', 'L', '8') /*  8  8-bit palette */