[2/2] kbuild: disable new dtc graph and unit-address warnings

Message ID 20180508135150.27762-2-robh@kernel.org
State Accepted
Commit 74656b682902c803493959dfc79dd0e0e8e31351
Headers show
Series
  • Untitled series #11209
Related show

Commit Message

Rob Herring May 8, 2018, 1:51 p.m.
dtc gained some new warnings for OF graphs and unique unit addresses,
but they are currently much too noisy. So turn off
'graph_child_address', 'graph_port', and 'unique_unit_address' warnings
by default. They can be enabled by building dtbs with W=1.

Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Michal Marek <michal.lkml@markovi.net>
Cc: linux-kbuild@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>

---
I plan to take this via DT tree as it is dependent on a dtc update in 
patch 1.

 scripts/Makefile.lib | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.17.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Masahiro Yamada May 8, 2018, 11:51 p.m. | #1
Hi Rob,

2018-05-08 22:51 GMT+09:00 Rob Herring <robh@kernel.org>:
> dtc gained some new warnings for OF graphs and unique unit addresses,

> but they are currently much too noisy. So turn off

> 'graph_child_address', 'graph_port', and 'unique_unit_address' warnings

> by default. They can be enabled by building dtbs with W=1.

>

> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>

> Cc: Michal Marek <michal.lkml@markovi.net>

> Cc: linux-kbuild@vger.kernel.org

> Signed-off-by: Rob Herring <robh@kernel.org>

> ---

> I plan to take this via DT tree as it is dependent on a dtc update in

> patch 1.



Yes, please do so.

Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>






>  scripts/Makefile.lib | 3 +++

>  1 file changed, 3 insertions(+)

>

> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib

> index 5af34a2b0cd9..1bb594fcfe12 100644

> --- a/scripts/Makefile.lib

> +++ b/scripts/Makefile.lib

> @@ -251,6 +251,9 @@ DTC_FLAGS += -Wno-unit_address_vs_reg \

>         -Wno-unit_address_format \

>         -Wno-avoid_unnecessary_addr_size \

>         -Wno-alias_paths \

> +       -Wno-graph_child_address \

> +       -Wno-graph_port \

> +       -Wno-unique_unit_address \

>         -Wno-pci_device_reg

>  endif

>

> --

> 2.17.0

>




-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 5af34a2b0cd9..1bb594fcfe12 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -251,6 +251,9 @@  DTC_FLAGS += -Wno-unit_address_vs_reg \
 	-Wno-unit_address_format \
 	-Wno-avoid_unnecessary_addr_size \
 	-Wno-alias_paths \
+	-Wno-graph_child_address \
+	-Wno-graph_port \
+	-Wno-unique_unit_address \
 	-Wno-pci_device_reg
 endif