arm64: dts: juno: fix OF graph endpoint node names

Message ID 20180508150952.24562-1-robh@kernel.org
State New
Headers show
Series
  • arm64: dts: juno: fix OF graph endpoint node names
Related show

Commit Message

Rob Herring May 8, 2018, 3:09 p.m.
OF graph endpoint node names should be 'endpoint'. Fix the following
warnings found by dtc:

Warning (graph_endpoint): /hdlcd@7ff50000/port/hdlcd1-endpoint: graph endpont node nameshould be 'endpoint'
Warning (graph_endpoint): /hdlcd@7ff60000/port/hdlcd0-endpoint: graph endpont node nameshould be 'endpoint'
Warning (graph_endpoint): /i2c@7ffa0000/hdmi-transmitter@70/port/tda998x-0-endpoint: graph endpont node name should be 'endpoint'
Warning (graph_endpoint): /i2c@7ffa0000/hdmi-transmitter@71/port/tda998x-1-endpoint: graph endpont node name should be 'endpoint'

Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Rob Herring <robh@kernel.org>

---
 arch/arm64/boot/dts/arm/juno-base.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

-- 
2.17.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Liviu Dudau May 8, 2018, 3:15 p.m. | #1
On Tue, May 08, 2018 at 10:09:49AM -0500, Rob Herring wrote:
> OF graph endpoint node names should be 'endpoint'. Fix the following

> warnings found by dtc:

> 

> Warning (graph_endpoint): /hdlcd@7ff50000/port/hdlcd1-endpoint: graph endpont node nameshould be 'endpoint'

> Warning (graph_endpoint): /hdlcd@7ff60000/port/hdlcd0-endpoint: graph endpont node nameshould be 'endpoint'

> Warning (graph_endpoint): /i2c@7ffa0000/hdmi-transmitter@70/port/tda998x-0-endpoint: graph endpont node name should be 'endpoint'

> Warning (graph_endpoint): /i2c@7ffa0000/hdmi-transmitter@71/port/tda998x-1-endpoint: graph endpont node name should be 'endpoint'

> 

> Cc: Liviu Dudau <liviu.dudau@arm.com>


Acked-by: Liviu Dudau <liviu.dudau@arm.com>


Thanks for this!
Liviu

> Cc: Sudeep Holla <sudeep.holla@arm.com>

> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>

> Signed-off-by: Rob Herring <robh@kernel.org>

> ---

>  arch/arm64/boot/dts/arm/juno-base.dtsi | 8 ++++----

>  1 file changed, 4 insertions(+), 4 deletions(-)

> 

> diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi

> index eb749c50a736..b2fedaab3fcc 100644

> --- a/arch/arm64/boot/dts/arm/juno-base.dtsi

> +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi

> @@ -677,7 +677,7 @@

>  		clock-names = "pxlclk";

>  

>  		port {

> -			hdlcd1_output: hdlcd1-endpoint {

> +			hdlcd1_output: endpoint {

>  				remote-endpoint = <&tda998x_1_input>;

>  			};

>  		};

> @@ -692,7 +692,7 @@

>  		clock-names = "pxlclk";

>  

>  		port {

> -			hdlcd0_output: hdlcd0-endpoint {

> +			hdlcd0_output: endpoint {

>  				remote-endpoint = <&tda998x_0_input>;

>  			};

>  		};

> @@ -720,7 +720,7 @@

>  			compatible = "nxp,tda998x";

>  			reg = <0x70>;

>  			port {

> -				tda998x_0_input: tda998x-0-endpoint {

> +				tda998x_0_input: endpoint {

>  					remote-endpoint = <&hdlcd0_output>;

>  				};

>  			};

> @@ -730,7 +730,7 @@

>  			compatible = "nxp,tda998x";

>  			reg = <0x71>;

>  			port {

> -				tda998x_1_input: tda998x-1-endpoint {

> +				tda998x_1_input: endpoint {

>  					remote-endpoint = <&hdlcd1_output>;

>  				};

>  			};

> -- 

> 2.17.0

> 


-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sudeep Holla May 9, 2018, 4:34 p.m. | #2
On 08/05/18 16:09, Rob Herring wrote:
> OF graph endpoint node names should be 'endpoint'. Fix the following

> warnings found by dtc:

> 

> Warning (graph_endpoint): /hdlcd@7ff50000/port/hdlcd1-endpoint: graph endpont node nameshould be 'endpoint'

> Warning (graph_endpoint): /hdlcd@7ff60000/port/hdlcd0-endpoint: graph endpont node nameshould be 'endpoint'

> Warning (graph_endpoint): /i2c@7ffa0000/hdmi-transmitter@70/port/tda998x-0-endpoint: graph endpont node name should be 'endpoint'

> Warning (graph_endpoint): /i2c@7ffa0000/hdmi-transmitter@71/port/tda998x-1-endpoint: graph endpont node name should be 'endpoint'

> 

> Cc: Liviu Dudau <liviu.dudau@arm.com>

> Cc: Sudeep Holla <sudeep.holla@arm.com>

> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>

> Signed-off-by: Rob Herring <robh@kernel.org>


Thanks Robs, both patches applied.

-- 
Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Herring May 23, 2018, 8:29 p.m. | #3
On Tue, May 8, 2018 at 10:09 AM, Rob Herring <robh@kernel.org> wrote:
> The ETF input should be connected to the funnel output, and the ETF

> output should be connected to the replicator input. The labels are wrong

> and these got swapped:

>

> Warning (graph_endpoint): /soc/funnel@821000/ports/port@8/endpoint: graph connection to node '/soc/etf@825000/ports/port@1/endpoint' is not bidirectional

> Warning (graph_endpoint): /soc/replicator@824000/ports/port@2/endpoint: graph connection to node '/soc/etf@825000/ports/port@0/endpoint' is not bidirectional

>

> Fixes: 7c10da373698 ("arm64: dts: qcom: Add msm8916 CoreSight components")

> Cc: Ivan T. Ivanov <ivan.ivanov@linaro.org>

> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>

> Cc: Andy Gross <andy.gross@linaro.org>

> Cc: David Brown <david.brown@linaro.org>

> Cc: linux-arm-msm@vger.kernel.org

> Signed-off-by: Rob Herring <robh@kernel.org>

> ---

>  arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)


Ping. Still seeing warnings in -next for these.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ivan T. Ivanov May 24, 2018, 4:48 a.m. | #4
Quoting Rob Herring (2018-05-23 23:29:29)
> On Tue, May 8, 2018 at 10:09 AM, Rob Herring <robh@kernel.org> wrote:

> > The ETF input should be connected to the funnel output, and the ETF

> > output should be connected to the replicator input. The labels are wrong

> > and these got swapped:

> >

> > Warning (graph_endpoint): /soc/funnel@821000/ports/port@8/endpoint: graph connection to node '/soc/etf@825000/ports/port@1/endpoint' is not bidirectional

> > Warning (graph_endpoint): /soc/replicator@824000/ports/port@2/endpoint: graph connection to node '/soc/etf@825000/ports/port@0/endpoint' is not bidirectional

> >

> > Fixes: 7c10da373698 ("arm64: dts: qcom: Add msm8916 CoreSight components")

> > Cc: Ivan T. Ivanov <ivan.ivanov@linaro.org>

> > Cc: Mathieu Poirier <mathieu.poirier@linaro.org>

> > Cc: Andy Gross <andy.gross@linaro.org>

> > Cc: David Brown <david.brown@linaro.org>

> > Cc: linux-arm-msm@vger.kernel.org

> > Signed-off-by: Rob Herring <robh@kernel.org>

> > ---

> >  arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++--

> >  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> Ping. Still seeing warnings in -next for these.

>


 Hi Rob,

 I no longer have access to this hardware and documentation.
 I am sure that Mathieu and friends will take care for verification
 of this patch :-)

 Regards,
 Ivan

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mathieu Poirier May 24, 2018, 4:32 p.m. | #5
On 23 May 2018 at 22:48, Ivan T. Ivanov <iivanov.xz@gmail.com> wrote:
> Quoting Rob Herring (2018-05-23 23:29:29)

>> On Tue, May 8, 2018 at 10:09 AM, Rob Herring <robh@kernel.org> wrote:

>> > The ETF input should be connected to the funnel output, and the ETF

>> > output should be connected to the replicator input. The labels are wrong

>> > and these got swapped:

>> >

>> > Warning (graph_endpoint): /soc/funnel@821000/ports/port@8/endpoint: graph connection to node '/soc/etf@825000/ports/port@1/endpoint' is not bidirectional

>> > Warning (graph_endpoint): /soc/replicator@824000/ports/port@2/endpoint: graph connection to node '/soc/etf@825000/ports/port@0/endpoint' is not bidirectional

>> >

>> > Fixes: 7c10da373698 ("arm64: dts: qcom: Add msm8916 CoreSight components")

>> > Cc: Ivan T. Ivanov <ivan.ivanov@linaro.org>

>> > Cc: Mathieu Poirier <mathieu.poirier@linaro.org>

>> > Cc: Andy Gross <andy.gross@linaro.org>

>> > Cc: David Brown <david.brown@linaro.org>

>> > Cc: linux-arm-msm@vger.kernel.org

>> > Signed-off-by: Rob Herring <robh@kernel.org>

>> > ---

>> >  arch/arm64/boot/dts/qcom/msm8916.dtsi | 4 ++--

>> >  1 file changed, 2 insertions(+), 2 deletions(-)

>>

>> Ping. Still seeing warnings in -next for these.

>>

>

>  Hi Rob,

>

>  I no longer have access to this hardware and documentation.

>  I am sure that Mathieu and friends will take care for verification

>  of this patch :-)


The code triggers on the "slave-mode" property rather than the labels,
so this patch has no effect on how a path is established.  I've tested
this on a 410c and things look good.

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

Tested-by: Mathieu Poirier <mathieu.poirier@linaro.org>


>

>  Regards,

>  Ivan

>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi
index eb749c50a736..b2fedaab3fcc 100644
--- a/arch/arm64/boot/dts/arm/juno-base.dtsi
+++ b/arch/arm64/boot/dts/arm/juno-base.dtsi
@@ -677,7 +677,7 @@ 
 		clock-names = "pxlclk";
 
 		port {
-			hdlcd1_output: hdlcd1-endpoint {
+			hdlcd1_output: endpoint {
 				remote-endpoint = <&tda998x_1_input>;
 			};
 		};
@@ -692,7 +692,7 @@ 
 		clock-names = "pxlclk";
 
 		port {
-			hdlcd0_output: hdlcd0-endpoint {
+			hdlcd0_output: endpoint {
 				remote-endpoint = <&tda998x_0_input>;
 			};
 		};
@@ -720,7 +720,7 @@ 
 			compatible = "nxp,tda998x";
 			reg = <0x70>;
 			port {
-				tda998x_0_input: tda998x-0-endpoint {
+				tda998x_0_input: endpoint {
 					remote-endpoint = <&hdlcd0_output>;
 				};
 			};
@@ -730,7 +730,7 @@ 
 			compatible = "nxp,tda998x";
 			reg = <0x71>;
 			port {
-				tda998x_1_input: tda998x-1-endpoint {
+				tda998x_1_input: endpoint {
 					remote-endpoint = <&hdlcd1_output>;
 				};
 			};