arm64: dts: sprd: fix typo in 'remote-endpoint'

Message ID 20180508150952.24562-4-robh@kernel.org
State Accepted
Commit e0c66d34bf105ad333f4ba8ef4dc777b73bca95f
Headers show
Series
  • arm64: dts: sprd: fix typo in 'remote-endpoint'
Related show

Commit Message

Rob Herring May 8, 2018, 3:09 p.m.
dtc now warns on incomplete OF graph endpoint connections:

arch/arm64/boot/dts/sprd/sp9860g-1h10.dtb: Warning (graph_endpoint): /soc/stm@10006000/port/endpoint: graph connection to node '/soc/funnel@10001000/ports/port@2/endpoint' is not bidirectional

The cause is a typo in 'remote-endpoint'.

Cc: Orson Zhai <orsonzhai@gmail.com>
Cc: Baolin Wang <baolin.wang@linaro.org>
Cc: Chunyan Zhang <zhang.lyra@gmail.com>
Signed-off-by: Rob Herring <robh@kernel.org>

---
 arch/arm64/boot/dts/sprd/sc9860.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Chunyan Zhang May 9, 2018, 1:58 a.m. | #1
Hi Rob,

On 8 May 2018 at 23:09, Rob Herring <robh@kernel.org> wrote:
> dtc now warns on incomplete OF graph endpoint connections:

>

> arch/arm64/boot/dts/sprd/sp9860g-1h10.dtb: Warning (graph_endpoint): /soc/stm@10006000/port/endpoint: graph connection to node '/soc/funnel@10001000/ports/port@2/endpoint' is not bidirectional

>

> The cause is a typo in 'remote-endpoint'.


Thanks for fixing this and,

Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>


>

> Cc: Orson Zhai <orsonzhai@gmail.com>

> Cc: Baolin Wang <baolin.wang@linaro.org>

> Cc: Chunyan Zhang <zhang.lyra@gmail.com>

> Signed-off-by: Rob Herring <robh@kernel.org>

> ---

>  arch/arm64/boot/dts/sprd/sc9860.dtsi | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/arch/arm64/boot/dts/sprd/sc9860.dtsi b/arch/arm64/boot/dts/sprd/sc9860.dtsi

> index 5dbfb796d9f9..dcd03ffcda03 100644

> --- a/arch/arm64/boot/dts/sprd/sc9860.dtsi

> +++ b/arch/arm64/boot/dts/sprd/sc9860.dtsi

> @@ -326,7 +326,7 @@

>                                         reg = <4>;

>                                         soc_funnel_in_port1: endpoint {

>                                                 slave-mode;

> -                                               remote-endpioint =

> +                                               remote-endpoint =

>                                                         <&stm_out_port>;

>                                         };

>                                 };

> --

> 2.17.0

>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Herring May 23, 2018, 8:30 p.m. | #2
On Tue, May 8, 2018 at 8:58 PM, Chunyan Zhang <zhang.lyra@gmail.com> wrote:
> Hi Rob,

>

> On 8 May 2018 at 23:09, Rob Herring <robh@kernel.org> wrote:

>> dtc now warns on incomplete OF graph endpoint connections:

>>

>> arch/arm64/boot/dts/sprd/sp9860g-1h10.dtb: Warning (graph_endpoint): /soc/stm@10006000/port/endpoint: graph connection to node '/soc/funnel@10001000/ports/port@2/endpoint' is not bidirectional

>>

>> The cause is a typo in 'remote-endpoint'.

>

> Thanks for fixing this and,

>

> Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>


Is someone going to apply this? Still seeing warnings in linux-next.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Baolin Wang May 24, 2018, 5:27 a.m. | #3
On 24 May 2018 at 04:30, Rob Herring <robh@kernel.org> wrote:
> On Tue, May 8, 2018 at 8:58 PM, Chunyan Zhang <zhang.lyra@gmail.com> wrote:

>> Hi Rob,

>>

>> On 8 May 2018 at 23:09, Rob Herring <robh@kernel.org> wrote:

>>> dtc now warns on incomplete OF graph endpoint connections:

>>>

>>> arch/arm64/boot/dts/sprd/sp9860g-1h10.dtb: Warning (graph_endpoint): /soc/stm@10006000/port/endpoint: graph connection to node '/soc/funnel@10001000/ports/port@2/endpoint' is not bidirectional

>>>

>>> The cause is a typo in 'remote-endpoint'.

>>

>> Thanks for fixing this and,

>>

>> Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>

>

> Is someone going to apply this? Still seeing warnings in linux-next.


I think Arnd will pick up this patch.

-- 
Baolin.wang
Best Regards
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Chunyan Zhang May 25, 2018, 2:36 a.m. | #4
Hi Arnd, Olof

Could you please take this patch through arm-soc git?

Thanks,
Chunyan

On 24 May 2018 at 04:30, Rob Herring <robh@kernel.org> wrote:
> On Tue, May 8, 2018 at 8:58 PM, Chunyan Zhang <zhang.lyra@gmail.com> wrote:

>> Hi Rob,

>>

>> On 8 May 2018 at 23:09, Rob Herring <robh@kernel.org> wrote:

>>> dtc now warns on incomplete OF graph endpoint connections:

>>>

>>> arch/arm64/boot/dts/sprd/sp9860g-1h10.dtb: Warning (graph_endpoint): /soc/stm@10006000/port/endpoint: graph connection to node '/soc/funnel@10001000/ports/port@2/endpoint' is not bidirectional

>>>

>>> The cause is a typo in 'remote-endpoint'.

>>

>> Thanks for fixing this and,

>>

>> Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>

>

> Is someone going to apply this? Still seeing warnings in linux-next.

>

> Rob

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Olof Johansson May 25, 2018, 10:11 p.m. | #5
On Fri, May 25, 2018 at 10:36:45AM +0800, Chunyan Zhang wrote:
> Hi Arnd, Olof

> 

> Could you please take this patch through arm-soc git?


Applied.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/arm64/boot/dts/sprd/sc9860.dtsi b/arch/arm64/boot/dts/sprd/sc9860.dtsi
index 5dbfb796d9f9..dcd03ffcda03 100644
--- a/arch/arm64/boot/dts/sprd/sc9860.dtsi
+++ b/arch/arm64/boot/dts/sprd/sc9860.dtsi
@@ -326,7 +326,7 @@ 
 					reg = <4>;
 					soc_funnel_in_port1: endpoint {
 						slave-mode;
-						remote-endpioint =
+						remote-endpoint =
 							<&stm_out_port>;
 					};
 				};