[6/8] firmware: arm_scmi: remove unnecessary bitmap_zero

Message ID 1525885634-22348-7-git-send-email-sudeep.holla@arm.com
State Accepted
Commit 8f3397ccb63ac3b0ddcc759565bcd66977c4eb1a
Headers show
Series
  • firmware: arm_scmi: trivial cleanups
Related show

Commit Message

Sudeep Holla May 9, 2018, 5:07 p.m.
kcalloc zeros the memory and it's totally unnecessary to zero the bitmap
again using bitmap_zero. This patch just drops the unnecessary use of
the bitmap_zero in the context.

Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

---
 drivers/firmware/arm_scmi/driver.c | 2 --
 1 file changed, 2 deletions(-)

-- 
2.7.4

Comments

Jonathan Cameron May 17, 2018, 8:43 a.m. | #1
On Wed, 9 May 2018 18:07:12 +0100
Sudeep Holla <sudeep.holla@arm.com> wrote:

> kcalloc zeros the memory and it's totally unnecessary to zero the bitmap

> again using bitmap_zero. This patch just drops the unnecessary use of

> the bitmap_zero in the context.

> 

> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>


> ---

>  drivers/firmware/arm_scmi/driver.c | 2 --

>  1 file changed, 2 deletions(-)

> 

> diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c

> index 33d2b78af3ff..4087d6c50ecd 100644

> --- a/drivers/firmware/arm_scmi/driver.c

> +++ b/drivers/firmware/arm_scmi/driver.c

> @@ -636,8 +636,6 @@ static int scmi_xfer_info_init(struct scmi_info *sinfo)

>  	if (!info->xfer_alloc_table)

>  		return -ENOMEM;

>  

> -	bitmap_zero(info->xfer_alloc_table, desc->max_msg);

> -

>  	/* Pre-initialize the buffer pointer to pre-allocated buffers */

>  	for (i = 0, xfer = info->xfer_block; i < desc->max_msg; i++, xfer++) {

>  		xfer->rx.buf = devm_kcalloc(dev, sizeof(u8), desc->max_msg_size,

Patch

diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
index 33d2b78af3ff..4087d6c50ecd 100644
--- a/drivers/firmware/arm_scmi/driver.c
+++ b/drivers/firmware/arm_scmi/driver.c
@@ -636,8 +636,6 @@  static int scmi_xfer_info_init(struct scmi_info *sinfo)
 	if (!info->xfer_alloc_table)
 		return -ENOMEM;
 
-	bitmap_zero(info->xfer_alloc_table, desc->max_msg);
-
 	/* Pre-initialize the buffer pointer to pre-allocated buffers */
 	for (i = 0, xfer = info->xfer_block; i < desc->max_msg; i++, xfer++) {
 		xfer->rx.buf = devm_kcalloc(dev, sizeof(u8), desc->max_msg_size,