diff mbox series

[PULL,01/21] hw/arm/iotkit.c: fix minor memory leak

Message ID 20180510174519.11264-2-peter.maydell@linaro.org
State Accepted
Commit 7a35383afd66458ff11fa5c72a1599f3a24f3073
Headers show
Series target-arm queue | expand

Commit Message

Peter Maydell May 10, 2018, 5:44 p.m. UTC 
Coverity (CID1390573) spots that we forgot to free the
gpioname strings in a loop in the iotkit realize function.
Correct the error.

This isn't a significant leak, because this function
only ever runs once.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Peter Xu <peterx@redhat.com>

Message-id: 20180427110137.19304-1-peter.maydell@linaro.org
---
 hw/arm/iotkit.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.17.0
diff mbox series

Patch

diff --git a/hw/arm/iotkit.c b/hw/arm/iotkit.c
index c5f0a5b98a..234185e8f7 100644
--- a/hw/arm/iotkit.c
+++ b/hw/arm/iotkit.c
@@ -517,6 +517,7 @@  static void iotkit_realize(DeviceState *dev, Error **errp)
                               qdev_get_gpio_in(DEVICE(&s->ppc_irq_orgate), i));
         qdev_connect_gpio_out_named(DEVICE(ppc), "irq", 0,
                                     qdev_get_gpio_in(devs, 0));
+        g_free(gpioname);
     }
 
     iotkit_forward_sec_resp_cfg(s);