From patchwork Fri May 11 10:23:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 135519 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp674301lji; Fri, 11 May 2018 03:23:36 -0700 (PDT) X-Google-Smtp-Source: AB8JxZpM+f+XXn1Ciohfi9IBj0oNMEjMtcXn/Db9HogNQDi+NYrYJniRR5pQn77BbOZ9dt+mF2/Q X-Received: by 2002:a17:902:8647:: with SMTP id y7-v6mr4866593plt.86.1526034215956; Fri, 11 May 2018 03:23:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1526034215; cv=none; d=google.com; s=arc-20160816; b=k4UtNFqB9jvi/3A7jRdeMeex1jiVRg6yiHs33cWN+lnJIByTAWGfI7I6nloBKfgpxj JxRC3BVgW+ju/CjMr/FnqOD6fDQVFgGG2VGGcLeNkoARqEVqSx7LSf3OCtXHw7NMoMS9 ADBtA9nbTi6+ZJVxVU4PCcCUCs1lGY7K2w3VA1fkbxqbCDiLcXCmpTAJ2jUrWvAXFZBw N2+lZesttEPPCkyU90GfJADo3HQ2JfIufWtWXRf+Yxi+Wx+zdeWQY3Oun6AofKI//9ls gohQNhvSpFmndLGElptyZFwa0sVhPw5YRA8IdlddroTm6cdrwtVrnWg6emudX8YB92be yHUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=IlgP/bhab8H3aV0f6bVf9vXiFU7+p/BQBCaqUC9ApP4=; b=UbLwvAUM2WNgzpLhsBycVIszvuPHOE6JmiDkNgriNmKA0uwcndLuZl6eXrXsDQzNky 3mKSwGGkHjNlY2uXYwKKLndpNyADaRqF5FqjCSL3gnGtOQmw2Wc+qBwReSvk9KdqOEde iea82+rzRbbikDTvQuTCSwZup6V6/VW0C356zjC7hlWeIiswpVtjVIY1D7d9gol6BIxk UEqDSAEex8gBy0bAiKRpd3ChgZ2TL749RSr5n2Yt7bCncmn0RICSa3z+HG5sIoGxmmen xJ9Kq1+vnj5RtZZLZguqeSOJKysb0QxZONppJ05vegBygZ+wiCAcuxl+G6CID78ZU1N3 aFKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h15-v6si3158855plk.485.2018.05.11.03.23.35; Fri, 11 May 2018 03:23:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752569AbeEKKXf (ORCPT + 6 others); Fri, 11 May 2018 06:23:35 -0400 Received: from foss.arm.com ([217.140.101.70]:39252 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750852AbeEKKXe (ORCPT ); Fri, 11 May 2018 06:23:34 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 533FB1596; Fri, 11 May 2018 03:23:34 -0700 (PDT) Received: from e107155-lin.cambridge.arm.com (unknown [10.1.210.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 448A03F73E; Fri, 11 May 2018 03:23:33 -0700 (PDT) From: Sudeep Holla To: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Liviu Dudau Cc: Sudeep Holla , Rob Herring Subject: [PATCH v2 1/2] ARM: dts: vexpress: use standard gpio bindings for sys_{led, mci, flash} Date: Fri, 11 May 2018 11:23:27 +0100 Message-Id: <1526034208-9690-1-git-send-email-sudeep.holla@arm.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1525884482-19855-1-git-send-email-sudeep.holla@arm.com> References: <1525884482-19855-1-git-send-email-sudeep.holla@arm.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Commit 2cff6dba57b7 ("ARM: dts: vexpress: fix node name unit-address presence warnings") removed the unit address as there was no associated reg property in these sysreg nodes. Also the latest DTC throws warnings for character '_' in the node names. Warning (node_name_chars_strict): /sysreg@10000/sys_led: Character '_' not recommended in node name Warning (node_name_chars_strict): /sysreg@10000/sys_mci: Character '_' not recommended in node name Warning (node_name_chars_strict): /sysreg@10000/sys_flash: Character '_' not recommended in node name The correct way to fix this as well as the original unit-address presence warnings is to use the standard gpio controller binding and specify the reg properties as per the hardware as it was before. However note that Vexpress sysreg MFD driver will still continue to use the hardcoded values for compatibility reasons. Cc: Liviu Dudau Suggested-by: Rob Herring Signed-off-by: Sudeep Holla --- arch/arm/boot/dts/vexpress-v2m-rs1.dtsi | 11 ++++++++--- arch/arm/boot/dts/vexpress-v2m.dtsi | 11 ++++++++--- 2 files changed, 16 insertions(+), 6 deletions(-) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Rob Herring diff --git a/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi b/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi index 7b8ff5b3b912..a8586a0b957d 100644 --- a/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi +++ b/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi @@ -76,21 +76,26 @@ v2m_sysreg: sysreg@10000 { compatible = "arm,vexpress-sysreg"; reg = <0x010000 0x1000>; + #address-cells = <1>; + #size-cells = <1>; - v2m_led_gpios: sys_led { + v2m_led_gpios: gpio@8 { compatible = "arm,vexpress-sysreg,sys_led"; + reg = <0x008 4>; gpio-controller; #gpio-cells = <2>; }; - v2m_mmc_gpios: sys_mci { + v2m_mmc_gpios: gpio@48 { compatible = "arm,vexpress-sysreg,sys_mci"; + reg = <0x048 4>; gpio-controller; #gpio-cells = <2>; }; - v2m_flash_gpios: sys_flash { + v2m_flash_gpios: gpio@4c { compatible = "arm,vexpress-sysreg,sys_flash"; + reg = <0x04c 4>; gpio-controller; #gpio-cells = <2>; }; diff --git a/arch/arm/boot/dts/vexpress-v2m.dtsi b/arch/arm/boot/dts/vexpress-v2m.dtsi index 9cd5e146abd5..37ecccebd937 100644 --- a/arch/arm/boot/dts/vexpress-v2m.dtsi +++ b/arch/arm/boot/dts/vexpress-v2m.dtsi @@ -76,21 +76,26 @@ v2m_sysreg: sysreg@0 { compatible = "arm,vexpress-sysreg"; reg = <0x00000 0x1000>; + #address-cells = <1>; + #size-cells = <1>; - v2m_led_gpios: sys_led { + v2m_led_gpios: gpio@8 { compatible = "arm,vexpress-sysreg,sys_led"; + reg = <0x008 4>; gpio-controller; #gpio-cells = <2>; }; - v2m_mmc_gpios: sys_mci { + v2m_mmc_gpios: gpio@48 { compatible = "arm,vexpress-sysreg,sys_mci"; + reg = <0x048 4>; gpio-controller; #gpio-cells = <2>; }; - v2m_flash_gpios: sys_flash { + v2m_flash_gpios: gpio@4c { compatible = "arm,vexpress-sysreg,sys_flash"; + reg = <0x04c 4>; gpio-controller; #gpio-cells = <2>; };