staging: video: fix warning unused variable

Message ID 20180514105442.10179-1-anders.roxell@linaro.org
State New
Headers show
Series
  • staging: video: fix warning unused variable
Related show

Commit Message

Anders Roxell May 14, 2018, 10:54 a.m.
When building video warnings pops up unused variable 'mdev',
drivers/staging/most/video/video.c: In function ‘vidioc_enum_fmt_vid_cap’:
drivers/staging/most/video/video.c:265:25: warning: unused variable ‘mdev’ [-Wunused-variable]
  struct most_video_dev *mdev = fh->mdev;
                         ^~~~
drivers/staging/most/video/video.c: In function ‘vidioc_g_fmt_vid_cap’:
drivers/staging/most/video/video.c:282:25: warning: unused variable ‘mdev’ [-Wunused-variable]
  struct most_video_dev *mdev = fh->mdev;
                         ^~~~
drivers/staging/most/video/video.c: In function ‘vidioc_g_std’:
drivers/staging/most/video/video.c:309:25: warning: unused variable ‘mdev’ [-Wunused-variable]
  struct most_video_dev *mdev = fh->mdev;
                         ^~~~

Remove the 'mdev' declaration.

Fixes: 7d7cdb4fa552 ("staging: most: video: remove debugging code")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

---
 drivers/staging/most/video/video.c | 9 ---------
 1 file changed, 9 deletions(-)

-- 
2.17.0

Comments

Greg KH May 14, 2018, 11:01 a.m. | #1
On Mon, May 14, 2018 at 12:54:42PM +0200, Anders Roxell wrote:
> When building video warnings pops up unused variable 'mdev',

> drivers/staging/most/video/video.c: In function ‘vidioc_enum_fmt_vid_cap’:

> drivers/staging/most/video/video.c:265:25: warning: unused variable ‘mdev’ [-Wunused-variable]

>   struct most_video_dev *mdev = fh->mdev;

>                          ^~~~

> drivers/staging/most/video/video.c: In function ‘vidioc_g_fmt_vid_cap’:

> drivers/staging/most/video/video.c:282:25: warning: unused variable ‘mdev’ [-Wunused-variable]

>   struct most_video_dev *mdev = fh->mdev;

>                          ^~~~

> drivers/staging/most/video/video.c: In function ‘vidioc_g_std’:

> drivers/staging/most/video/video.c:309:25: warning: unused variable ‘mdev’ [-Wunused-variable]

>   struct most_video_dev *mdev = fh->mdev;

>                          ^~~~

> 

> Remove the 'mdev' declaration.

> 

> Fixes: 7d7cdb4fa552 ("staging: most: video: remove debugging code")

> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

> ---

>  drivers/staging/most/video/video.c | 9 ---------

>  1 file changed, 9 deletions(-)


I posted the same exact fix about an hour ago, sorry.

greg k-h

Patch

diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c
index fc374711fcc0..cf342eb58e10 100644
--- a/drivers/staging/most/video/video.c
+++ b/drivers/staging/most/video/video.c
@@ -261,9 +261,6 @@  static int vidioc_querycap(struct file *file, void *priv,
 static int vidioc_enum_fmt_vid_cap(struct file *file, void *priv,
 				   struct v4l2_fmtdesc *f)
 {
-	struct comp_fh *fh = priv;
-	struct most_video_dev *mdev = fh->mdev;
-
 	if (f->index)
 		return -EINVAL;
 
@@ -278,9 +275,6 @@  static int vidioc_enum_fmt_vid_cap(struct file *file, void *priv,
 static int vidioc_g_fmt_vid_cap(struct file *file, void *priv,
 				struct v4l2_format *f)
 {
-	struct comp_fh *fh = priv;
-	struct most_video_dev *mdev = fh->mdev;
-
 	comp_set_format_struct(f);
 	return 0;
 }
@@ -305,9 +299,6 @@  static int vidioc_s_fmt_vid_cap(struct file *file, void *priv,
 
 static int vidioc_g_std(struct file *file, void *priv, v4l2_std_id *norm)
 {
-	struct comp_fh *fh = priv;
-	struct most_video_dev *mdev = fh->mdev;
-
 	*norm = V4L2_STD_UNKNOWN;
 	return 0;
 }