[v2,01/29] venus: hfi_msgs: correct pointer increment

Message ID 20180515075859.17217-2-stanimir.varbanov@linaro.org
State New
Headers show
Series
  • [v2,01/29] venus: hfi_msgs: correct pointer increment
Related show

Commit Message

Stanimir Varbanov May 15, 2018, 7:58 a.m.
Data pointer should be incremented by size of the structure not
the size of a pointer, correct the mistake.

Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>

---
 drivers/media/platform/qcom/venus/hfi_msgs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.14.1

Comments

Tomasz Figa May 18, 2018, 8:57 a.m. | #1
On Tue, May 15, 2018 at 5:13 PM Stanimir Varbanov <
stanimir.varbanov@linaro.org> wrote:

> Data pointer should be incremented by size of the structure not

> the size of a pointer, correct the mistake.


> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>

> ---

>   drivers/media/platform/qcom/venus/hfi_msgs.c | 4 ++--

>   1 file changed, 2 insertions(+), 2 deletions(-)


> diff --git a/drivers/media/platform/qcom/venus/hfi_msgs.c

b/drivers/media/platform/qcom/venus/hfi_msgs.c
> index 90c93d9603dc..589e1a6b36a9 100644

> --- a/drivers/media/platform/qcom/venus/hfi_msgs.c

> +++ b/drivers/media/platform/qcom/venus/hfi_msgs.c

> @@ -60,14 +60,14 @@ static void event_seq_changed(struct venus_core

*core, struct venus_inst *inst,
>                          frame_sz = (struct hfi_framesize *)data_ptr;

>                          event.width = frame_sz->width;

>                          event.height = frame_sz->height;

> -                       data_ptr += sizeof(frame_sz);

> +                       data_ptr += sizeof(*frame_sz);

>                          break;

>                  case HFI_PROPERTY_PARAM_PROFILE_LEVEL_CURRENT:

>                          data_ptr += sizeof(u32);

>                          profile_level = (struct hfi_profile_level

*)data_ptr;
>                          event.profile = profile_level->profile;

>                          event.level = profile_level->level;

> -                       data_ptr += sizeof(profile_level);

> +                       data_ptr += sizeof(*profile_level);

>                          break;

>                  default:

>                          break;

> --

> 2.14.1



(Posted to v1 originally, since I missed v2.)

Reviewed-by: Tomasz Figa <tfiga@chromium.org>


Best regards,
Tomasz

Patch

diff --git a/drivers/media/platform/qcom/venus/hfi_msgs.c b/drivers/media/platform/qcom/venus/hfi_msgs.c
index 90c93d9603dc..589e1a6b36a9 100644
--- a/drivers/media/platform/qcom/venus/hfi_msgs.c
+++ b/drivers/media/platform/qcom/venus/hfi_msgs.c
@@ -60,14 +60,14 @@  static void event_seq_changed(struct venus_core *core, struct venus_inst *inst,
 			frame_sz = (struct hfi_framesize *)data_ptr;
 			event.width = frame_sz->width;
 			event.height = frame_sz->height;
-			data_ptr += sizeof(frame_sz);
+			data_ptr += sizeof(*frame_sz);
 			break;
 		case HFI_PROPERTY_PARAM_PROFILE_LEVEL_CURRENT:
 			data_ptr += sizeof(u32);
 			profile_level = (struct hfi_profile_level *)data_ptr;
 			event.profile = profile_level->profile;
 			event.level = profile_level->level;
-			data_ptr += sizeof(profile_level);
+			data_ptr += sizeof(*profile_level);
 			break;
 		default:
 			break;