[4/4] musl: Make dev package rdep on staticdev

Message ID 13936651721b14a74b51c673c35c2b514299ca6c.1526452205.git.raj.khem@gmail.com
State New
Headers show
Series
  • gdb upgrade and misc fixes to enable gcc8
Related show

Commit Message

Khem Raj May 16, 2018, 6:32 a.m.
This is needed for enabling static linking with SDK

Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 meta/recipes-core/musl/musl_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.0

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Ross Burton May 16, 2018, 11:09 a.m. | #1
Surely if you want to support static linking in the SDK, you just need
to add staticdev-pkgs to the SDKIMAGE_FEATURES?

Ross

On 16 May 2018 at 07:32, Khem Raj <raj.khem@gmail.com> wrote:
> This is needed for enabling static linking with SDK

>

> Signed-off-by: Khem Raj <raj.khem@gmail.com>

> ---

>  meta/recipes-core/musl/musl_git.bb | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/meta/recipes-core/musl/musl_git.bb b/meta/recipes-core/musl/musl_git.bb

> index a0a098f5b4..d7d201df9d 100644

> --- a/meta/recipes-core/musl/musl_git.bb

> +++ b/meta/recipes-core/musl/musl_git.bb

> @@ -66,7 +66,7 @@ do_install() {

>         done

>  }

>

> -RDEPENDS_${PN}-dev += "linux-libc-headers-dev bsd-headers-dev libssp-nonshared-staticdev"

> +RDEPENDS_${PN}-dev += "linux-libc-headers-dev bsd-headers-dev libssp-nonshared-staticdev ${PN}-staticdev"

>  RPROVIDES_${PN}-dev += "libc-dev virtual-libc-dev"

>  RPROVIDES_${PN} += "ldd libsegfault rtld(GNU_HASH)"

>

> --

> 2.17.0

>

> --

> _______________________________________________

> Openembedded-core mailing list

> Openembedded-core@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj May 16, 2018, 1:32 p.m. | #2
On Wed, May 16, 2018 at 4:09 AM, Burton, Ross <ross.burton@intel.com> wrote:
> Surely if you want to support static linking in the SDK, you just need

> to add staticdev-pkgs to the SDKIMAGE_FEATURES?

>


In some usecase, compiler runtime and c library is only required everything
else is external. Adding whole staticdev bundle would conflict with that

> Ross

>

> On 16 May 2018 at 07:32, Khem Raj <raj.khem@gmail.com> wrote:

>> This is needed for enabling static linking with SDK

>>

>> Signed-off-by: Khem Raj <raj.khem@gmail.com>

>> ---

>>  meta/recipes-core/musl/musl_git.bb | 2 +-

>>  1 file changed, 1 insertion(+), 1 deletion(-)

>>

>> diff --git a/meta/recipes-core/musl/musl_git.bb b/meta/recipes-core/musl/musl_git.bb

>> index a0a098f5b4..d7d201df9d 100644

>> --- a/meta/recipes-core/musl/musl_git.bb

>> +++ b/meta/recipes-core/musl/musl_git.bb

>> @@ -66,7 +66,7 @@ do_install() {

>>         done

>>  }

>>

>> -RDEPENDS_${PN}-dev += "linux-libc-headers-dev bsd-headers-dev libssp-nonshared-staticdev"

>> +RDEPENDS_${PN}-dev += "linux-libc-headers-dev bsd-headers-dev libssp-nonshared-staticdev ${PN}-staticdev"

>>  RPROVIDES_${PN}-dev += "libc-dev virtual-libc-dev"

>>  RPROVIDES_${PN} += "ldd libsegfault rtld(GNU_HASH)"

>>

>> --

>> 2.17.0

>>

>> --

>> _______________________________________________

>> Openembedded-core mailing list

>> Openembedded-core@lists.openembedded.org

>> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Ross Burton May 16, 2018, 2:38 p.m. | #3
Surely in that usecase you can add musl-staticdev yourself?  Forcing
it into every SDK seems wasteful.

Ross

On 16 May 2018 at 14:32, Khem Raj <raj.khem@gmail.com> wrote:
> On Wed, May 16, 2018 at 4:09 AM, Burton, Ross <ross.burton@intel.com> wrote:

>> Surely if you want to support static linking in the SDK, you just need

>> to add staticdev-pkgs to the SDKIMAGE_FEATURES?

>>

>

> In some usecase, compiler runtime and c library is only required everything

> else is external. Adding whole staticdev bundle would conflict with that

>

>> Ross

>>

>> On 16 May 2018 at 07:32, Khem Raj <raj.khem@gmail.com> wrote:

>>> This is needed for enabling static linking with SDK

>>>

>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>

>>> ---

>>>  meta/recipes-core/musl/musl_git.bb | 2 +-

>>>  1 file changed, 1 insertion(+), 1 deletion(-)

>>>

>>> diff --git a/meta/recipes-core/musl/musl_git.bb b/meta/recipes-core/musl/musl_git.bb

>>> index a0a098f5b4..d7d201df9d 100644

>>> --- a/meta/recipes-core/musl/musl_git.bb

>>> +++ b/meta/recipes-core/musl/musl_git.bb

>>> @@ -66,7 +66,7 @@ do_install() {

>>>         done

>>>  }

>>>

>>> -RDEPENDS_${PN}-dev += "linux-libc-headers-dev bsd-headers-dev libssp-nonshared-staticdev"

>>> +RDEPENDS_${PN}-dev += "linux-libc-headers-dev bsd-headers-dev libssp-nonshared-staticdev ${PN}-staticdev"

>>>  RPROVIDES_${PN}-dev += "libc-dev virtual-libc-dev"

>>>  RPROVIDES_${PN} += "ldd libsegfault rtld(GNU_HASH)"

>>>

>>> --

>>> 2.17.0

>>>

>>> --

>>> _______________________________________________

>>> Openembedded-core mailing list

>>> Openembedded-core@lists.openembedded.org

>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj May 16, 2018, 3:04 p.m. | #4
On Wed, May 16, 2018 at 7:38 AM, Burton, Ross <ross.burton@intel.com> wrote:
> Surely in that usecase you can add musl-staticdev yourself?  Forcing

> it into every SDK seems wasteful.

>


I guess thats a fair argument I can accept it. Please ignore this patch then

> Ross

>

> On 16 May 2018 at 14:32, Khem Raj <raj.khem@gmail.com> wrote:

>> On Wed, May 16, 2018 at 4:09 AM, Burton, Ross <ross.burton@intel.com> wrote:

>>> Surely if you want to support static linking in the SDK, you just need

>>> to add staticdev-pkgs to the SDKIMAGE_FEATURES?

>>>

>>

>> In some usecase, compiler runtime and c library is only required everything

>> else is external. Adding whole staticdev bundle would conflict with that

>>

>>> Ross

>>>

>>> On 16 May 2018 at 07:32, Khem Raj <raj.khem@gmail.com> wrote:

>>>> This is needed for enabling static linking with SDK

>>>>

>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>

>>>> ---

>>>>  meta/recipes-core/musl/musl_git.bb | 2 +-

>>>>  1 file changed, 1 insertion(+), 1 deletion(-)

>>>>

>>>> diff --git a/meta/recipes-core/musl/musl_git.bb b/meta/recipes-core/musl/musl_git.bb

>>>> index a0a098f5b4..d7d201df9d 100644

>>>> --- a/meta/recipes-core/musl/musl_git.bb

>>>> +++ b/meta/recipes-core/musl/musl_git.bb

>>>> @@ -66,7 +66,7 @@ do_install() {

>>>>         done

>>>>  }

>>>>

>>>> -RDEPENDS_${PN}-dev += "linux-libc-headers-dev bsd-headers-dev libssp-nonshared-staticdev"

>>>> +RDEPENDS_${PN}-dev += "linux-libc-headers-dev bsd-headers-dev libssp-nonshared-staticdev ${PN}-staticdev"

>>>>  RPROVIDES_${PN}-dev += "libc-dev virtual-libc-dev"

>>>>  RPROVIDES_${PN} += "ldd libsegfault rtld(GNU_HASH)"

>>>>

>>>> --

>>>> 2.17.0

>>>>

>>>> --

>>>> _______________________________________________

>>>> Openembedded-core mailing list

>>>> Openembedded-core@lists.openembedded.org

>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-core/musl/musl_git.bb b/meta/recipes-core/musl/musl_git.bb
index a0a098f5b4..d7d201df9d 100644
--- a/meta/recipes-core/musl/musl_git.bb
+++ b/meta/recipes-core/musl/musl_git.bb
@@ -66,7 +66,7 @@  do_install() {
 	done
 }
 
-RDEPENDS_${PN}-dev += "linux-libc-headers-dev bsd-headers-dev libssp-nonshared-staticdev"
+RDEPENDS_${PN}-dev += "linux-libc-headers-dev bsd-headers-dev libssp-nonshared-staticdev ${PN}-staticdev"
 RPROVIDES_${PN}-dev += "libc-dev virtual-libc-dev"
 RPROVIDES_${PN} += "ldd libsegfault rtld(GNU_HASH)"