[oe,meta-oe] stm32flash: Fix packaging errors

Message ID 20180518200554.30205-2-raj.khem@gmail.com
State New
Headers show
Series
  • [oe,meta-oe] stm32flash: Fix packaging errors
Related show

Commit Message

Khem Raj May 18, 2018, 8:05 p.m.
Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

-- 
2.17.0

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Comments

Peter Kjellerstedt May 18, 2018, 8:43 p.m. | #1
> -----Original Message-----

> From: openembedded-devel-bounces@lists.openembedded.org

> [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of

> Khem Raj

> Sent: den 18 maj 2018 22:06

> To: openembedded-devel@lists.openembedded.org

> Subject: [oe] [meta-oe][PATCH] stm32flash: Fix packaging errors

> 

> Signed-off-by: Khem Raj <raj.khem@gmail.com>

> ---

>  meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb | 12 ++++++------

>  1 file changed, 6 insertions(+), 6 deletions(-)

> 

> diff --git a/meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb b/meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb

> index d401981ff9..59bd1b60e1 100644

> --- a/meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb

> +++ b/meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb

> @@ -1,16 +1,16 @@

>  SUMMARY = "Open source flash program for STM32 using the ST serial bootloader"

>  HOMEPAGE = "https://sourceforge.net/projects/stm32flash/"

>  BUGTRACKER = "https://sourceforge.net/p/stm32flash/tickets/"

> -LICENSE = "GPLv2"

> +LICENSE = "GPL-2.0+"

>  LIC_FILES_CHKSUM = "file://gpl-2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263"

> 

> -inherit autotools-brokensep

> -

>  S = "${WORKDIR}/${PN}"


I missed it in my comments, but Anuj had already pointed it out, 
That ${PN} above should be changed to ${BPN}.

> -SRC_URI = "https://prdownloads.sourceforge.net/stm32flash/stm32flash-${PV}.tar.gz"

> +SRC_URI = "${SOURCEFORGE_MIRROR}/${BPN}/${BP}.tar.gz"

> +

> +do_install() {

> +	oe_runmake install DESTDIR=${D} PREFIX=${prefix}

> +}

> 

>  SRC_URI[md5sum] = "40f673502949f3bb655d2bcc539d7b6a"

>  SRC_URI[sha256sum] = "97aa9422ef02e82f7da9039329e21a437decf972cb3919ad817f70ac9a49e306"

> -

> -FILES_${PN} = "/usr/local/bin/stm32flash"

> --

> 2.17.0


//Peter

-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Khem Raj May 18, 2018, 9:05 p.m. | #2
On Fri, May 18, 2018 at 1:43 PM, Peter Kjellerstedt
<peter.kjellerstedt@axis.com> wrote:
>> -----Original Message-----

>> From: openembedded-devel-bounces@lists.openembedded.org

>> [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of

>> Khem Raj

>> Sent: den 18 maj 2018 22:06

>> To: openembedded-devel@lists.openembedded.org

>> Subject: [oe] [meta-oe][PATCH] stm32flash: Fix packaging errors

>>

>> Signed-off-by: Khem Raj <raj.khem@gmail.com>

>> ---

>>  meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb | 12 ++++++------

>>  1 file changed, 6 insertions(+), 6 deletions(-)

>>

>> diff --git a/meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb b/meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb

>> index d401981ff9..59bd1b60e1 100644

>> --- a/meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb

>> +++ b/meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb

>> @@ -1,16 +1,16 @@

>>  SUMMARY = "Open source flash program for STM32 using the ST serial bootloader"

>>  HOMEPAGE = "https://sourceforge.net/projects/stm32flash/"

>>  BUGTRACKER = "https://sourceforge.net/p/stm32flash/tickets/"

>> -LICENSE = "GPLv2"

>> +LICENSE = "GPL-2.0+"

>>  LIC_FILES_CHKSUM = "file://gpl-2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263"

>>

>> -inherit autotools-brokensep

>> -

>>  S = "${WORKDIR}/${PN}"

>

> I missed it in my comments, but Anuj had already pointed it out,

> That ${PN} above should be changed to ${BPN}.


right, I will do that in v2
-- 
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Patch

diff --git a/meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb b/meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb
index d401981ff9..59bd1b60e1 100644
--- a/meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb
+++ b/meta-oe/recipes-support/stm32flash/stm32flash_0.5.bb
@@ -1,16 +1,16 @@ 
 SUMMARY = "Open source flash program for STM32 using the ST serial bootloader"
 HOMEPAGE = "https://sourceforge.net/projects/stm32flash/"
 BUGTRACKER = "https://sourceforge.net/p/stm32flash/tickets/"
-LICENSE = "GPLv2"
+LICENSE = "GPL-2.0+"
 LIC_FILES_CHKSUM = "file://gpl-2.0.txt;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
-inherit autotools-brokensep
-
 S = "${WORKDIR}/${PN}"
 
-SRC_URI = "https://prdownloads.sourceforge.net/stm32flash/stm32flash-${PV}.tar.gz"
+SRC_URI = "${SOURCEFORGE_MIRROR}/${BPN}/${BP}.tar.gz"
+
+do_install() {
+	oe_runmake install DESTDIR=${D} PREFIX=${prefix}
+}
 
 SRC_URI[md5sum] = "40f673502949f3bb655d2bcc539d7b6a"
 SRC_URI[sha256sum] = "97aa9422ef02e82f7da9039329e21a437decf972cb3919ad817f70ac9a49e306"
-
-FILES_${PN} = "/usr/local/bin/stm32flash"