pinctrl: samsung: Fix suspend/resume for Exynos5433 GPF1..5 banks

Message ID 20180521063449.4086-1-m.szyprowski@samsung.com
State New
Headers show
Series
  • pinctrl: samsung: Fix suspend/resume for Exynos5433 GPF1..5 banks
Related show

Commit Message

Marek Szyprowski May 21, 2018, 6:34 a.m.
GPF1..5 banks in Exynos5433 are located in two pinctrl devices: ALIVE and
IMEM. Although they are partially located in ALIVE section, the state of
their registers in IMEM section is lost after suspend/resume cycle. To
properly handle such case, those banks have to be defined with standard
'exynos5433_bank_type_off' tpye (with PINCFG_TYPE_CON_PDN and
PINCFG_TYPE_PUD_PDN register offsets). This automatically instructs
the generic Samsung pinctrl suspend/resume code to save and restore state
of those registers.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

---
 drivers/pinctrl/samsung/pinctrl-exynos.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.0

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Krzysztof Kozlowski May 23, 2018, 7:02 p.m. | #1
On Mon, May 21, 2018 at 08:34:49AM +0200, Marek Szyprowski wrote:
> GPF1..5 banks in Exynos5433 are located in two pinctrl devices: ALIVE and

> IMEM. Although they are partially located in ALIVE section, the state of

> their registers in IMEM section is lost after suspend/resume cycle. To

> properly handle such case, those banks have to be defined with standard

> 'exynos5433_bank_type_off' tpye (with PINCFG_TYPE_CON_PDN and

> PINCFG_TYPE_PUD_PDN register offsets). This automatically instructs

> the generic Samsung pinctrl suspend/resume code to save and restore state

> of those registers.

> 

> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---

>  drivers/pinctrl/samsung/pinctrl-exynos.h | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 


Thanks, applied.

Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.h b/drivers/pinctrl/samsung/pinctrl-exynos.h
index 7639b926c5c1..6ae81b44ba46 100644
--- a/drivers/pinctrl/samsung/pinctrl-exynos.h
+++ b/drivers/pinctrl/samsung/pinctrl-exynos.h
@@ -103,7 +103,7 @@ 
 
 #define EXYNOS5433_PIN_BANK_EINTW_EXT(pins, reg, id, offs, pctl_idx) \
 	{							\
-		.type           = &exynos5433_bank_type_alive,	\
+		.type           = &exynos5433_bank_type_off,	\
 		.pctl_offset    = reg,				\
 		.nr_pins        = pins,				\
 		.eint_type      = EINT_TYPE_WKUP,		\