diff mbox series

[edk2,2/6] ArmVirtPkg/PlatformBootManagerLib: add missing report status code call

Message ID 20180522140850.30369-3-ard.biesheuvel@linaro.org
State Superseded
Headers show
Series Abstract allocation of PEI accessible memory | expand

Commit Message

Ard Biesheuvel May 22, 2018, 2:08 p.m. UTC
Consumers of status code reports may rely on a status code to be
reported when the ReadyToBoot event is signalled. For instance,
FirmwarePerformanceDxe will fail to install the FPDT ACPI table
in this case. So add the missing call.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 +
 ArmVirtPkg/Library/PlatformBootManagerLib/QemuKernel.c               | 4 ++++
 2 files changed, 5 insertions(+)

-- 
2.17.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Laszlo Ersek May 22, 2018, 6:58 p.m. UTC | #1
On 05/22/18 16:08, Ard Biesheuvel wrote:
> Consumers of status code reports may rely on a status code to be

> reported when the ReadyToBoot event is signalled. For instance,

> FirmwarePerformanceDxe will fail to install the FPDT ACPI table

> in this case. So add the missing call.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---

>  ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 +

>  ArmVirtPkg/Library/PlatformBootManagerLib/QemuKernel.c               | 4 ++++

>  2 files changed, 5 insertions(+)

> 

> diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf

> index d6c1ef95dc44..0cbc82f5d27d 100644

> --- a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf

> +++ b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf

> @@ -53,6 +53,7 @@ [LibraryClasses]

>    PrintLib

>    QemuBootOrderLib

>    QemuFwCfgLib

> +  ReportStatusCodeLib

>    UefiBootManagerLib

>    UefiBootServicesTableLib

>    UefiLib

> diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/QemuKernel.c b/ArmVirtPkg/Library/PlatformBootManagerLib/QemuKernel.c

> index ac47d21e71c8..7b59f57eb19f 100644

> --- a/ArmVirtPkg/Library/PlatformBootManagerLib/QemuKernel.c

> +++ b/ArmVirtPkg/Library/PlatformBootManagerLib/QemuKernel.c

> @@ -20,6 +20,7 @@

>  #include <Guid/FileSystemVolumeLabelInfo.h>

>  #include <Library/PrintLib.h>

>  #include <Library/QemuFwCfgLib.h>

> +#include <Library/ReportStatusCodeLib.h>

>  #include <Protocol/DevicePath.h>

>  #include <Protocol/LoadedImage.h>

>  #include <Protocol/SimpleFileSystem.h>

> @@ -1072,6 +1073,9 @@ TryRunningQemuKernel (

>    //

>    EfiSignalEventReadyToBoot();

>  

> +  REPORT_STATUS_CODE (EFI_PROGRESS_CODE,

> +    (EFI_SOFTWARE_DXE_BS_DRIVER | EFI_SW_DXE_BS_PC_READY_TO_BOOT_EVENT));

> +

>    //

>    // Start the image.

>    //

> 


Reviewed-by: Laszlo Ersek <lersek@redhat.com>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
diff mbox series

Patch

diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
index d6c1ef95dc44..0cbc82f5d27d 100644
--- a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
+++ b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
@@ -53,6 +53,7 @@  [LibraryClasses]
   PrintLib
   QemuBootOrderLib
   QemuFwCfgLib
+  ReportStatusCodeLib
   UefiBootManagerLib
   UefiBootServicesTableLib
   UefiLib
diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/QemuKernel.c b/ArmVirtPkg/Library/PlatformBootManagerLib/QemuKernel.c
index ac47d21e71c8..7b59f57eb19f 100644
--- a/ArmVirtPkg/Library/PlatformBootManagerLib/QemuKernel.c
+++ b/ArmVirtPkg/Library/PlatformBootManagerLib/QemuKernel.c
@@ -20,6 +20,7 @@ 
 #include <Guid/FileSystemVolumeLabelInfo.h>
 #include <Library/PrintLib.h>
 #include <Library/QemuFwCfgLib.h>
+#include <Library/ReportStatusCodeLib.h>
 #include <Protocol/DevicePath.h>
 #include <Protocol/LoadedImage.h>
 #include <Protocol/SimpleFileSystem.h>
@@ -1072,6 +1073,9 @@  TryRunningQemuKernel (
   //
   EfiSignalEventReadyToBoot();
 
+  REPORT_STATUS_CODE (EFI_PROGRESS_CODE,
+    (EFI_SOFTWARE_DXE_BS_DRIVER | EFI_SW_DXE_BS_PC_READY_TO_BOOT_EVENT));
+
   //
   // Start the image.
   //