[6/6] arm64: dts: socionext: Add missing cooling device properties for CPUs

Message ID 744f4c0a9a6f0d3acfc36e49ef62f17f53831b3b.1527225682.git.viresh.kumar@linaro.org
State New
Headers show
Series
  • arm64: dts: Add missing cooling device properties for CPUs
Related show

Commit Message

Viresh Kumar May 25, 2018, 5:40 a.m.
The cooling device properties, like "#cooling-cells" and
"dynamic-power-coefficient", should either be present for all the CPUs
of a cluster or none. If these are present only for a subset of CPUs of
a cluster then things will start falling apart as soon as the CPUs are
brought online in a different order. For example, this will happen
because the operating system looks for such properties in the CPU node
it is trying to bring up, so that it can register a cooling device.

Add such missing properties.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

---
 arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.15.0.194.g9af6a3dea062

Comments

Viresh Kumar June 4, 2018, 7:14 a.m. | #1
On 01-06-18, 12:25, Masahiro Yamada wrote:
> 2018-05-25 14:40 GMT+09:00 Viresh Kumar <viresh.kumar@linaro.org>:

> > The cooling device properties, like "#cooling-cells" and

> > "dynamic-power-coefficient", should either be present for all the CPUs

> > of a cluster or none. If these are present only for a subset of CPUs of

> > a cluster then things will start falling apart as soon as the CPUs are

> > brought online in a different order. For example, this will happen

> > because the operating system looks for such properties in the CPU node

> > it is trying to bring up, so that it can register a cooling device.

> >

> > Add such missing properties.

> >

> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

> 

> 

> Applied to linux-uniphier.

> 

> I had already sent a PR for v4.18-rc1 before I received this patch.

> Please wait for v4.19-rc1.


Sure, no hurry. Though I thought this kind of fixes can go in 4.18-rc2 as well,
isn't it ?

-- 
viresh

Patch

diff --git a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
index 3a5ed789c056..10ffb5019013 100644
--- a/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
+++ b/arch/arm64/boot/dts/socionext/uniphier-ld20.dtsi
@@ -58,6 +58,7 @@ 
 			clocks = <&sys_clk 32>;
 			enable-method = "psci";
 			operating-points-v2 = <&cluster0_opp>;
+			#cooling-cells = <2>;
 		};
 
 		cpu2: cpu@100 {
@@ -77,6 +78,7 @@ 
 			clocks = <&sys_clk 33>;
 			enable-method = "psci";
 			operating-points-v2 = <&cluster1_opp>;
+			#cooling-cells = <2>;
 		};
 	};