[12/15] arm: dts: highbank: Add missing OPP properties for CPUs

Message ID f8a4e5c3062397736475ec599de730206846cb9b.1527244201.git.viresh.kumar@linaro.org
State Accepted
Commit c7ea1579a17e81c602cfc8121013cf8e39edd32b
Headers show
Series
  • Untitled series #11660
Related show

Commit Message

Viresh Kumar May 25, 2018, 10:31 a.m.
The OPP properties, like "operating-points", should either be present
for all the CPUs of a cluster or none. If these are present only for a
subset of CPUs of a cluster then things will start falling apart as soon
as the CPUs are brought online in a different order. For example, this
will happen because the operating system looks for such properties in
the CPU node it is trying to bring up, so that it can create an OPP
table.

Add such missing properties.

Fix other missing property (clock latency) as well to make it all
work.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

---
 arch/arm/boot/dts/highbank.dts | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

-- 
2.15.0.194.g9af6a3dea062

Comments

Olof Johansson July 3, 2018, 2:46 p.m. | #1
On Mon, Jul 2, 2018 at 9:13 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 02-07-18, 16:27, Olof Johansson wrote:

>> On Mon, Jul 02, 2018 at 02:25:40PM -0600, Rob Herring wrote:

>> > On Fri, May 25, 2018 at 4:32 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:

>> > >

>> > > The OPP properties, like "operating-points", should either be present

>> > > for all the CPUs of a cluster or none. If these are present only for a

>> > > subset of CPUs of a cluster then things will start falling apart as soon

>> > > as the CPUs are brought online in a different order. For example, this

>> > > will happen because the operating system looks for such properties in

>> > > the CPU node it is trying to bring up, so that it can create an OPP

>> > > table.

>> > >

>> > > Add such missing properties.

>> > >

>> > > Fix other missing property (clock latency) as well to make it all

>> > > work.

>> > >

>> > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

>> > > ---

>> > >  arch/arm/boot/dts/highbank.dts | 30 ++++++++++++++++++++++++++++++

>> > >  1 file changed, 30 insertions(+)

>> >

>> > Acked-by: Rob Herring <robh@kernel.org>

>> >

>> > ARM-SOC maintainers, Please apply this.

>>

>> Applied to next/dt.

>

> Thanks Olof.

>

> Can you also apply other patches in this series, that haven't been

> applied yet by SoC maintainers ? And same for the arm64 series..


This is the kind of patch that should be applied by the maintainers
for active platforms, where they have systems to test with and can
make sure you haven't regressed something on them.

For very low patch rate platforms we can apply directly through
maintainer acks, like in this case.

So, my recommendation is to repost the series to the maintainers.
Please don't patchbomb arm@kernel.org though, so keep us off of cc by
default (you can add our individual addresses if you want).


Thanks,

-Olof

Patch

diff --git a/arch/arm/boot/dts/highbank.dts b/arch/arm/boot/dts/highbank.dts
index ed14aeac0566..50278715de76 100644
--- a/arch/arm/boot/dts/highbank.dts
+++ b/arch/arm/boot/dts/highbank.dts
@@ -56,6 +56,16 @@ 
 			next-level-cache = <&L2>;
 			clocks = <&a9pll>;
 			clock-names = "cpu";
+			operating-points = <
+				/* kHz    ignored */
+				 1300000  1000000
+				 1200000  1000000
+				 1100000  1000000
+				  800000  1000000
+				  400000  1000000
+				  200000  1000000
+			>;
+			clock-latency = <100000>;
 		};
 
 		cpu@902 {
@@ -65,6 +75,16 @@ 
 			next-level-cache = <&L2>;
 			clocks = <&a9pll>;
 			clock-names = "cpu";
+			operating-points = <
+				/* kHz    ignored */
+				 1300000  1000000
+				 1200000  1000000
+				 1100000  1000000
+				  800000  1000000
+				  400000  1000000
+				  200000  1000000
+			>;
+			clock-latency = <100000>;
 		};
 
 		cpu@903 {
@@ -74,6 +94,16 @@ 
 			next-level-cache = <&L2>;
 			clocks = <&a9pll>;
 			clock-names = "cpu";
+			operating-points = <
+				/* kHz    ignored */
+				 1300000  1000000
+				 1200000  1000000
+				 1100000  1000000
+				  800000  1000000
+				  400000  1000000
+				  200000  1000000
+			>;
+			clock-latency = <100000>;
 		};
 	};