| Message ID | 20180525153841.3314617-1-arnd@arndb.de |
|---|---|
| State | New |
| Headers | show |
| Series | staging: typec: rt1711h: fix tcpci dependency | expand |
On Fri, May 25, 2018 at 05:38:25PM +0200, Arnd Bergmann wrote: > Using 'select' instead of the normal 'depends on' causes > a build issue with CONFIG_I2C=m: > > WARNING: unmet direct dependencies detected for TYPEC_TCPCI > Depends on [m]: STAGING [=y] && TYPEC_TCPM [=y] && I2C [=m] > Selected by [y]: > - TYPEC_RT1711H [=y] && STAGING [=y] && TYPEC_TCPM [=y] > > Fixes: ce08eaeb6388 ("staging: typec: rt1711h typec chip driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/staging/typec/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I think that this is already fixed in linux-next with some patches that I queued up there yesterday. When did you last see this problem? thanks, greg k-h
On Fri, May 25, 2018 at 5:52 PM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > On Fri, May 25, 2018 at 05:38:25PM +0200, Arnd Bergmann wrote: >> Using 'select' instead of the normal 'depends on' causes >> a build issue with CONFIG_I2C=m: >> >> WARNING: unmet direct dependencies detected for TYPEC_TCPCI >> Depends on [m]: STAGING [=y] && TYPEC_TCPM [=y] && I2C [=m] >> Selected by [y]: >> - TYPEC_RT1711H [=y] && STAGING [=y] && TYPEC_TCPM [=y] >> >> Fixes: ce08eaeb6388 ("staging: typec: rt1711h typec chip driver") >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> --- >> drivers/staging/typec/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > I think that this is already fixed in linux-next with some patches that > I queued up there yesterday. When did you last see this problem? It's on linux-next, but since there hasn't been a release this week, I'm sure you are right that this was already fixed. Arnd
diff --git a/drivers/staging/typec/Kconfig b/drivers/staging/typec/Kconfig index 3aa981fbc8f5..51474d798f99 100644 --- a/drivers/staging/typec/Kconfig +++ b/drivers/staging/typec/Kconfig @@ -11,7 +11,7 @@ config TYPEC_TCPCI config TYPEC_RT1711H tristate "Richtek RT1711H Type-C chip driver" - select TYPEC_TCPCI + depends on TYPEC_TCPCI help Richtek RT1711H Type-C chip driver that works with Type-C Port Controller Manager to provide USB PD and USB
Using 'select' instead of the normal 'depends on' causes a build issue with CONFIG_I2C=m: WARNING: unmet direct dependencies detected for TYPEC_TCPCI Depends on [m]: STAGING [=y] && TYPEC_TCPM [=y] && I2C [=m] Selected by [y]: - TYPEC_RT1711H [=y] && STAGING [=y] && TYPEC_TCPM [=y] Fixes: ce08eaeb6388 ("staging: typec: rt1711h typec chip driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/staging/typec/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0