From patchwork Fri May 25 15:50:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 136957 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp3759689lji; Fri, 25 May 2018 08:52:40 -0700 (PDT) X-Google-Smtp-Source: AB8JxZp3ujZxtO8uhiHuOnDUhDy0KJyb5w5BJOyttNU8u/chxmPUT71VKz9Q0DdqfYCI015guvwT X-Received: by 2002:a17:902:3a5:: with SMTP id d34-v6mr3217864pld.103.1527263560058; Fri, 25 May 2018 08:52:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527263560; cv=none; d=google.com; s=arc-20160816; b=JMxX5wLIRgt/nVLnXA35B6sUPBjRTFzCyA/+z+QWZ788v2FEv0mYbOGKjt1nU5qZ5r 5VBuAmiSHIXSfbgVGtySExXqctM4T2KipwHYDwsHUphlLBmjvYpgTHztYowN/5JTPjQN uVhHvCChEmVLfSBjRbqSgI3Ruy+O0aMmqf0CMb84C9qgcOV21egEPIIwVti4nPvS4++k ADl7fFOEtRmhjYSkDvBq8YOhcMG6F8vLkobEv9jHJKd6pof1NveZ6XjbGok6uLNEyaJI cUH68juiFMk8kaI1dQJ8E1EDNqDz0q6VzprNvrG8+Mk8gcg4YBZ3ISfnF+Gied8gohW5 8y2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=XRyGe+WyizPJikhSWLSrVhNUN5msjPJ8mp0xf8tBLxY=; b=YV2W1fYEE0Klug67zvqsWpthiB69AEKBbRoekgVIy3s2SeYt6aHzw9vn1lF0qgzWN7 OwmP12pZpwgcB15EqSxyOhZmtgXuuoXZbkyjF1vEiRQlJ2VWjkqOqVNcUfDj+8IuH7dU m0tk6eHnH8CLZ5YwtvUJo6CKV13uF43AJzhZjA3z3OfAiOgmkhuRRDx0vA4pnGRX2pCm nE6a0ag2cUeL2vnYNy5kiDQFMB6p+wufYY/vCS/PqUPzEKHzgirLCz6kjSY2PwDIAnVq JOch1GhnY2KXKklKeJDF1IlkjdA9dXKQvA0hJl4X4rg7Cy+bGhrILkbq8BRYqMB+P6iP ciEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x12-v6si18719998pgv.389.2018.05.25.08.52.39; Fri, 25 May 2018 08:52:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-samsung-soc-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-samsung-soc-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966293AbeEYPwj (ORCPT + 3 others); Fri, 25 May 2018 11:52:39 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:54613 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965666AbeEYPwi (ORCPT ); Fri, 25 May 2018 11:52:38 -0400 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue105 [212.227.15.145]) with ESMTPA (Nemesis) id 0LzJj7-1gQfMt3d5t-014UxT; Fri, 25 May 2018 17:52:15 +0200 From: Arnd Bergmann To: Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , David Airlie Cc: Arnd Bergmann , Kukjin Kim , Krzysztof Kozlowski , Marek Szyprowski , Andrzej Pietrasiewicz , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 6/8] drm/exynos: fix scaler_task_done return type Date: Fri, 25 May 2018 17:50:13 +0200 Message-Id: <20180525155030.3667352-6-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20180525155030.3667352-1-arnd@arndb.de> References: <20180525155030.3667352-1-arnd@arndb.de> X-Provags-ID: V03:K1:IeYDxoepEF3K07loDeAEQjFUqNru020qvDEONZYRpd19ZlaZutS rb9//WJwk8g2uox3LQpnEX8BRpy3hHbs9FxGsOVTCiSpTC33PzsggztvP3I4gIqYVUXQli/ uZHNxYxaoU01Agb5GnZ5vvrmzqGJs4DymfIwRJh9QcdS+fY1y5RPKnepu7Lfl7GkCRrjd5I 4TW84NHyhbKUjHOfcatWA== X-UI-Out-Filterresults: notjunk:1; V01:K0:OgOYizXz/tU=:J07lSl1AFFN+LE2Nr8xk8z Kl+8woDqZHTSKs4yLZbUruY3E77F2dJZkEKxH4+/XtlhB5KpKsNEow2m6ZrR0saY35e4mnBuO rtSQGtLbi9zfopX/y1Sh4NRfSbeNoceN3FD261cJnJLndAu2NBMnJHAFEqj5TZOdqLav7fQ/3 5ALAyWJAnU1iHp/df8MZagsOF/Jl3mg6OdNGr1fZkc7863Jnukfneqx6uW9WpG167q/D3RQ1S hKX+YCoArVD57wMNKAyjZMnRryw4t8y0hMNQ1bXWju3aJdH2pLNTwgge0+y0jQRP9p9WqkpS/ pKQNyfJxyBaohXzcE5LhJIvGzDcBzfmcmppb7yknmddJWvF1JhLzmbZsT3womSeQSkAV/xYL/ oEdPGmnCeDv4jlV5k+GPD/4QFyDBlhytjBHOqxsi0v63NYN0/qmuBkww+VKKr2hKDvM0n504l MXgUxoz9b1V002/m38XfFt+d4fxWmNkS9m8s1JMc4ZCzJ/VWAGubJ8GNyHnGXL/M3je1SE73V 4YnTr/IcH4C67I7G1BMd4CCO8w9Hr0LwBk2NYdxrkTlZbB4kEKn/r8HfZazWSKx0Zkj1WnDbW jgT5lkUT4yu6ojEI5/pC0GavXJ3TCtX3xfLvE2bmRhDn5KpO6dZfmA4WYmiQfjrpryx4P9u1W xdE5lYVZe7FWeuiP36QlsiWOrcTy6Xv0/znTl2T+RsLDi0fthNvg/GgiWvDYgVSEZoMk= Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Modern gcc versions warn about returning a ternary operator with an 'int' type in a function returning type 'bool': drivers/gpu/drm/exynos/exynos_drm_scaler.c: In function 'scaler_task_done': drivers/gpu/drm/exynos/exynos_drm_scaler.c:402:47: error: ?: using integer constants in boolean context [-Werror=int-in-bool-context] return val & SCALER_INT_STATUS_FRAME_END ? 0 : -EINVAL; >From context, it becomes clear that this should have been 'int', so I'm fixing it, along with parenthesizing the expression to make it clearer what is meant here (I got confused at first, after seeing the warning). Fixes: 01fb9185dc18 ("drm/exynos: Add driver for Exynos Scaler module") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/exynos/exynos_drm_scaler.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/gpu/drm/exynos/exynos_drm_scaler.c b/drivers/gpu/drm/exynos/exynos_drm_scaler.c index 63b05b7c846a..4ad49d7782cd 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_scaler.c +++ b/drivers/gpu/drm/exynos/exynos_drm_scaler.c @@ -397,9 +397,9 @@ static inline u32 scaler_get_int_status(struct scaler_context *scaler) return scaler_read(SCALER_INT_STATUS); } -static inline bool scaler_task_done(u32 val) +static inline int scaler_task_done(u32 val) { - return val & SCALER_INT_STATUS_FRAME_END ? 0 : -EINVAL; + return (val & SCALER_INT_STATUS_FRAME_END) ? 0 : -EINVAL; } static irqreturn_t scaler_irq_handler(int irq, void *arg)