[AARCH64] Add support of ARMv8.4 in saphira for Qualcomm server part

Message ID CAAdirjwRkR4Pf1-wHg-5nqf=xi0dPQNRq=wTQBnB=JOarp1c+A@mail.gmail.com
State New
Headers show
Series
  • [AARCH64] Add support of ARMv8.4 in saphira for Qualcomm server part
Related show

Commit Message

Sameera Deshpande May 29, 2018, 10:06 a.m.
Hi!

Please find attached the patch to add support of ARMv8.4 in saphira
for Qualcomm server part. Tested on aarch64, without any regressions.

Ok for trunk?

gas/ChangeLog:

2018-05-29 Sameera Deshpande <sameera.deshpande@linaro.org>

        * config/tc-aarch64.c : Add support of ARMv8.4 in saphira.

-- 
- Thanks and regards,
  Sameera D.

Comments

Sameera Deshpande May 30, 2018, 5:58 a.m. | #1
On Tue 29 May, 2018, 3:36 PM Sameera Deshpande, <
sameera.deshpande@linaro.org> wrote:

> Hi!

>

> Please find attached the patch to add support of ARMv8.4 in saphira

> for Qualcomm server part. Tested on aarch64, without any regressions.

>

> Ok for trunk?

>

> gas/ChangeLog:

>

> 2018-05-29 Sameera Deshpande <sameera.deshpande@linaro.org>

>

>         * config/tc-aarch64.c : Add support of ARMv8.4 in saphira.

>

> --

> - Thanks and regards,

>   Sameera D.

>


Adding Siddhesh.

- Thanks and regards,
  Sameera D.

>
Sameera Deshpande May 31, 2018, 1:26 a.m. | #2
On Wed 30 May, 2018, 11:28 AM Sameera Deshpande, <
sameera.deshpande@linaro.org> wrote:

>

>

> On Tue 29 May, 2018, 3:36 PM Sameera Deshpande, <

> sameera.deshpande@linaro.org> wrote:

>

>> Hi!

>>

>> Please find attached the patch to add support of ARMv8.4 in saphira

>> for Qualcomm server part. Tested on aarch64, without any regressions.

>>

>> Ok for trunk?

>>

>> gas/ChangeLog:

>>

>> 2018-05-29 Sameera Deshpande <sameera.deshpande@linaro.org>

>>

>>         * config/tc-aarch64.c : Add support of ARMv8.4 in saphira.

>>

>> --

>> - Thanks and regards,

>>   Sameera D.

>>

>

> Adding Siddhesh.

>

> - Thanks and regards,

>   Sameera D.

>

>>
Siddhesh Poyarekar May 31, 2018, 7:43 a.m. | #3
On 31 May 2018 at 06:56, Sameera Deshpande <sameera.deshpande@linaro.org> wrote:
>

> On Wed 30 May, 2018, 11:28 AM Sameera Deshpande,

> <sameera.deshpande@linaro.org> wrote:

>>

>>

>>

>> On Tue 29 May, 2018, 3:36 PM Sameera Deshpande,

>> <sameera.deshpande@linaro.org> wrote:

>>>

>>> Hi!

>>>

>>> Please find attached the patch to add support of ARMv8.4 in saphira

>>> for Qualcomm server part. Tested on aarch64, without any regressions.

>>>

>>> Ok for trunk?

>>>

>>> gas/ChangeLog:

>>>

>>> 2018-05-29 Sameera Deshpande <sameera.deshpande@linaro.org>

>>>

>>>         * config/tc-aarch64.c : Add support of ARMv8.4 in saphira.

>>>

>>> --

>>> - Thanks and regards,

>>>   Sameera D.

>>

>>

>> Adding Siddhesh.


Thanks, I can confirm that the saphira core does indeed support ARMv8.4.

Siddhesh
Nick Clifton June 5, 2018, 11:23 a.m. | #4
Hi Sameera,

> gas/ChangeLog:

> 

> 2018-05-29 Sameera Deshpande <sameera.deshpande@linaro.org>

> 

>         * config/tc-aarch64.c : Add support of ARMv8.4 in saphira.


Approved - please apply.

Cheers
  Nick
Sameera Deshpande June 5, 2018, 5:39 p.m. | #5
On Tue 5 Jun, 2018, 4:54 PM Nick Clifton, <nickc@redhat.com> wrote:

> Hi Sameera,

>

> > gas/ChangeLog:

> >

> > 2018-05-29 Sameera Deshpande <sameera.deshpande@linaro.org>

> >

> >         * config/tc-aarch64.c : Add support of ARMv8.4 in saphira.

>

> Approved - please apply.

>

> Cheers

>   Nick

>


Hi Nick,

Thanks for approving. However, I do not have write access to binutils. Will
it be possible for you to submit this patch in my stead, please?

- Thanks and regards,
  Sameera D.

>
Nick Clifton June 6, 2018, 2:21 p.m. | #6
Hi Sameera,

> Thanks for approving. However, I do not have write access to binutils. Will

> it be possible for you to submit this patch in my stead, please?


Done.

Cheers
  Nick
Sameera Deshpande June 6, 2018, 2:43 p.m. | #7
On Wed 6 Jun, 2018, 7:51 PM Nick Clifton, <nickc@redhat.com> wrote:

> Hi Sameera,

>

> > Thanks for approving. However, I do not have write access to binutils.

> Will

> > it be possible for you to submit this patch in my stead, please?

>

> Done.

>

> Cheers

>   Nick

>


Thanks Nick!

- Thanks and regards,
  Sameera D.

>

Patch

diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
index 02c92e3901..c31e7d2111 100644
--- a/gas/config/tc-aarch64.c
+++ b/gas/config/tc-aarch64.c
@@ -8579,7 +8579,7 @@  static const struct aarch64_cpu_option_table aarch64_cpus[] = {
 			       AARCH64_FEATURE_CRC | AARCH64_FEATURE_CRYPTO
 			       | AARCH64_FEATURE_RDMA),
    "Qualcomm QDF24XX"},
-  {"saphira", AARCH64_FEATURE (AARCH64_ARCH_V8_3,
+  {"saphira", AARCH64_FEATURE (AARCH64_ARCH_V8_4,
 			       AARCH64_FEATURE_CRYPTO | AARCH64_FEATURE_PROFILE),
    "Qualcomm Saphira"},
   {"thunderx", AARCH64_FEATURE (AARCH64_ARCH_V8,