gpio: davinci: fix build warning when !CONFIG_OF

Message ID 20180529145101.20808-1-nsekhar@ti.com
State Accepted
Commit 6310b930ccbba55168f30b610fae681d73bd7bd2
Headers show
Series
  • gpio: davinci: fix build warning when !CONFIG_OF
Related show

Commit Message

Sekhar Nori May 29, 2018, 2:51 p.m.
This nukes the following warning that is seen when building without
OF support:

drivers/gpio/gpio-davinci.c:437:25: warning: ‘keystone_gpio_get_irq_chip’ defined but not used [-Wunused-function]
 static struct irq_chip *keystone_gpio_get_irq_chip(unsigned int irq)
                         ^~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Sekhar Nori <nsekhar@ti.com>

---
 drivers/gpio/gpio-davinci.c | 2 --
 1 file changed, 2 deletions(-)

-- 
2.16.2

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Linus Walleij May 30, 2018, 7:11 a.m. | #1
On Tue, May 29, 2018 at 4:51 PM, Sekhar Nori <nsekhar@ti.com> wrote:

> This nukes the following warning that is seen when building without

> OF support:

>

> drivers/gpio/gpio-davinci.c:437:25: warning: ‘keystone_gpio_get_irq_chip’ defined but not used [-Wunused-function]

>  static struct irq_chip *keystone_gpio_get_irq_chip(unsigned int irq)

>                          ^~~~~~~~~~~~~~~~~~~~~~~~~~

> Signed-off-by: Sekhar Nori <nsekhar@ti.com>


Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index 987126c4c6f6..b574ecff7761 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -610,14 +610,12 @@  static int davinci_gpio_irq_setup(struct platform_device *pdev)
 	return 0;
 }
 
-#if IS_ENABLED(CONFIG_OF)
 static const struct of_device_id davinci_gpio_ids[] = {
 	{ .compatible = "ti,keystone-gpio", keystone_gpio_get_irq_chip},
 	{ .compatible = "ti,dm6441-gpio", davinci_gpio_get_irq_chip},
 	{ /* sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, davinci_gpio_ids);
-#endif
 
 static struct platform_driver davinci_gpio_driver = {
 	.probe		= davinci_gpio_probe,