mmc: sdhci-msm: Remove NO_CARD_NO_RESET quirk

Message ID 20180530144335.7888-1-georgi.djakov@linaro.org
State Accepted
Commit 4ba9bf98b8996b70d73381e700384ac75b82f745
Headers show
Series
  • mmc: sdhci-msm: Remove NO_CARD_NO_RESET quirk
Related show

Commit Message

Georgi Djakov May 30, 2018, 2:43 p.m.
Now we have a proper implementation for the power irq handling and this
quirk is not needed anymore. In fact, it is causing card detection delays
on apq8096 platforms and the following error is displayed:
sdhci_msm 74a4900.sdhci: mmc0: pwr_irq for req: (4) timed out

The quirk is forcing the controller to retain 1.8V signalling on the slot
even when a new card is inserted, which is not correct. The proper behavior
would be to reset the controller in order to start with 3.3V signaling.

Fixes: c0309b3803fe ("mmc: sdhci-msm: Add sdhci msm register write APIs which wait for pwr irq")
Suggested-by: Vijay Viswanath <vviswana@codeaurora.org>
Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>

---
This can go for v4.18, as it's not a critical fix.
Tested on db410c and db820c.
---
 drivers/mmc/host/sdhci-msm.c | 1 -
 1 file changed, 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Ulf Hansson May 31, 2018, 11:04 a.m. | #1
On 30 May 2018 at 16:43, Georgi Djakov <georgi.djakov@linaro.org> wrote:
> Now we have a proper implementation for the power irq handling and this

> quirk is not needed anymore. In fact, it is causing card detection delays

> on apq8096 platforms and the following error is displayed:

> sdhci_msm 74a4900.sdhci: mmc0: pwr_irq for req: (4) timed out

>

> The quirk is forcing the controller to retain 1.8V signalling on the slot

> even when a new card is inserted, which is not correct. The proper behavior

> would be to reset the controller in order to start with 3.3V signaling.

>

> Fixes: c0309b3803fe ("mmc: sdhci-msm: Add sdhci msm register write APIs which wait for pwr irq")

> Suggested-by: Vijay Viswanath <vviswana@codeaurora.org>

> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>


Thanks, applied for next!

Kind regards
Uffe

> ---

> This can go for v4.18, as it's not a critical fix.

> Tested on db410c and db820c.

> ---

>  drivers/mmc/host/sdhci-msm.c | 1 -

>  1 file changed, 1 deletion(-)

>

> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c

> index c283291db705..791779173332 100644

> --- a/drivers/mmc/host/sdhci-msm.c

> +++ b/drivers/mmc/host/sdhci-msm.c

> @@ -1333,7 +1333,6 @@ static const struct sdhci_ops sdhci_msm_ops = {

>

>  static const struct sdhci_pltfm_data sdhci_msm_pdata = {

>         .quirks = SDHCI_QUIRK_BROKEN_CARD_DETECTION |

> -                 SDHCI_QUIRK_NO_CARD_NO_RESET |

>                   SDHCI_QUIRK_SINGLE_POWER_WRITE |

>                   SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN,

>         .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN,

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
index c283291db705..791779173332 100644
--- a/drivers/mmc/host/sdhci-msm.c
+++ b/drivers/mmc/host/sdhci-msm.c
@@ -1333,7 +1333,6 @@  static const struct sdhci_ops sdhci_msm_ops = {
 
 static const struct sdhci_pltfm_data sdhci_msm_pdata = {
 	.quirks = SDHCI_QUIRK_BROKEN_CARD_DETECTION |
-		  SDHCI_QUIRK_NO_CARD_NO_RESET |
 		  SDHCI_QUIRK_SINGLE_POWER_WRITE |
 		  SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN,
 	.quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN,