ieee802154: mcr20a: add missing includes

Message ID 20180530214732.1021121-1-arnd@arndb.de
State Accepted
Commit a6032120d341badd9b034cb64411e7089d8f4285
Headers show
Series
  • ieee802154: mcr20a: add missing includes
Related show

Commit Message

Arnd Bergmann May 30, 2018, 9:47 p.m.
Without CONFIG_GPIOLIB, some headers are not included implicitly,
leading to a build failure:

drivers/net/ieee802154/mcr20a.c: In function 'mcr20a_probe':
drivers/net/ieee802154/mcr20a.c:1347:13: error: implicit declaration of function 'irq_get_trigger_type'; did you mean 'irq_get_irqchip_state'? [-Werror=implicit-function-declaration]

This includes gpio/consumer.h and irq.h directly rather through the
gpiolib header.

Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/net/ieee802154/mcr20a.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.9.0

Comments

Xue Liu June 1, 2018, 9:52 p.m. | #1
Hello Arnd,

Thanks for the fix.

Acked-by: Xue Liu <liuxuenetmail@gmail.com>


On Wed, 30 May 2018 at 23:47, Arnd Bergmann <arnd@arndb.de> wrote:
>

> Without CONFIG_GPIOLIB, some headers are not included implicitly,

> leading to a build failure:

>

> drivers/net/ieee802154/mcr20a.c: In function 'mcr20a_probe':

> drivers/net/ieee802154/mcr20a.c:1347:13: error: implicit declaration of function 'irq_get_trigger_type'; did you mean 'irq_get_irqchip_state'? [-Werror=implicit-function-declaration]

>

> This includes gpio/consumer.h and irq.h directly rather through the

> gpiolib header.

>

> Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver driver")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> ---

>  drivers/net/ieee802154/mcr20a.c | 3 ++-

>  1 file changed, 2 insertions(+), 1 deletion(-)

>

> diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c

> index de0d7f28a181..e428277781ac 100644

> --- a/drivers/net/ieee802154/mcr20a.c

> +++ b/drivers/net/ieee802154/mcr20a.c

> @@ -15,10 +15,11 @@

>   */

>  #include <linux/kernel.h>

>  #include <linux/module.h>

> -#include <linux/gpio.h>

> +#include <linux/gpio/consumer.h>

>  #include <linux/spi/spi.h>

>  #include <linux/workqueue.h>

>  #include <linux/interrupt.h>

> +#include <linux/irq.h>

>  #include <linux/skbuff.h>

>  #include <linux/of_gpio.h>

>  #include <linux/regmap.h>

> --

> 2.9.0

>



--

Patch

diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c
index de0d7f28a181..e428277781ac 100644
--- a/drivers/net/ieee802154/mcr20a.c
+++ b/drivers/net/ieee802154/mcr20a.c
@@ -15,10 +15,11 @@ 
  */
 #include <linux/kernel.h>
 #include <linux/module.h>
-#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
 #include <linux/spi/spi.h>
 #include <linux/workqueue.h>
 #include <linux/interrupt.h>
+#include <linux/irq.h>
 #include <linux/skbuff.h>
 #include <linux/of_gpio.h>
 #include <linux/regmap.h>