From patchwork Fri Jun 1 09:04:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "\(Exiting\) Baolin Wang" X-Patchwork-Id: 137496 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp680360lji; Fri, 1 Jun 2018 02:06:23 -0700 (PDT) X-Google-Smtp-Source: ADUXVKL/cknVpFf78WoU9PwLblUTMo8eAucSCNbSzVKYqCA3KqKH0A64DMVcJ4iwZ/CUNz5XXe+h X-Received: by 2002:a17:902:b28c:: with SMTP id u12-v6mr10424426plr.68.1527843983116; Fri, 01 Jun 2018 02:06:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527843983; cv=none; d=google.com; s=arc-20160816; b=ym3xsXpHxGiIGJ/B3lSaBT/L3zmmcVTjZdlmkQEIeUMlB/Gl2CkYF6WvIj2HjNp3zc EEaU9pap1gW5vDKPbj+YU1xEtB+Y42Xj94Pm60lid2nljnXegHx5m52a/0qdDLomSld9 5egRvgASN4qeGMfZD0P2kIElJgT1xln14/dPAUBjHEmy+0Bo8QR6c5ioP0I1gs9cdKjb eCT7d2tAyeB0EnVoxq/Ro99NiKUDi5lndQl/OHbXqXYL6LuEfjF88kWhVmcVjCmI6WZu tFPc0QdCBnDC1kRin78/EZJk6Vw7sy2CebN3PTWmXy+zJVrY7++OMZHO7im5d+67/Rg8 14+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=y6rwY3jFptgeXlF1nA+iIjbA4Z16sjg0bDMz2V84xl4=; b=jngWEZ7cIZhGmB2ESRFVOXp7IEbO8vQU1v2YDSK9LvftRs65dXEFHPIXWyhg4dQ4/Y 0ydjdKQ8dfnUkp9ScnWpe8qo2tKjNq0wwIh8URwGE48GNmvSq3s4drn9+IxL10SsmP8t MXqkNlDF7O8IrkW6u+JqLtIDFsNiTXAmqQMwq8oDfbDo+IsU7OYZy1jdme8EOs6dqdBT aj40qmekMltsJft1aZ+Y/tB1zPmUZgd+doSSwR7laDx2CrgbYeDRuZb8v0fkPlmGWWuO mdAwLAIKeWExaGEUpygyhyKoZVexL/xHGd3WwiodTYVb+le5njzZge/T6E0/91kqgWOp KJFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bUqL0owy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r11-v6si30705335pgp.235.2018.06.01.02.06.22; Fri, 01 Jun 2018 02:06:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bUqL0owy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751436AbeFAJGU (ORCPT + 30 others); Fri, 1 Jun 2018 05:06:20 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:33343 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751247AbeFAJF7 (ORCPT ); Fri, 1 Jun 2018 05:05:59 -0400 Received: by mail-pg0-f68.google.com with SMTP id e11-v6so1797026pgq.0 for ; Fri, 01 Jun 2018 02:05:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=y6rwY3jFptgeXlF1nA+iIjbA4Z16sjg0bDMz2V84xl4=; b=bUqL0owydwmpEzB7POGEHGlQmMuVk6A1vRmNM+SV2xLlHRMuwRa6qfowBD35jCwBi+ mU6/lV6fgOyMH7gh//IeLH/LkSDBXKPma1/xTZJ2jog3XDUfzSwJKnEUwrdD81yB9wjF L52quBLUnXyKFAmgCX9sLFTcitt8kVnqFjL+4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=y6rwY3jFptgeXlF1nA+iIjbA4Z16sjg0bDMz2V84xl4=; b=kKdsdGvX5kQDumvl1kMMPzNIGTWHyDJ/+QZzU0QVDyLx54R6Dldy3drbP5fjcV44o1 Uo8ES+L7ZS7gJcFbryAOcP9bKwblg/3izlFaROw1kQotT8r7vIh/awhReKv85uvaYSLr r4u7KbCf0QruQrH3WxIyKLM7VKi4RmlQ1i01JHBa6vciNz2YVw66cAQmALtM5+anME9x c4if+xL63quHR7M7U3uu94JUKp4lLTBP+RRUnmpkUQgyPwvgx/WIRD/ZcRm0RnpNGXJJ v1f3fLlfGRz9ZEpN8b3FLVsfhbPIeYutMW13qRufDFTzr2LH7UgOGUTAvW5IaPr5RT16 tjSA== X-Gm-Message-State: ALKqPwfVUMSq7BCluL4tPWgRqPa3LKG1I2tbs53R74Ush87Rn/Sn/PuF +sNSIEqiSsdzjNv+cz+v1bfMgQ== X-Received: by 2002:a63:7a49:: with SMTP id j9-v6mr8199208pgn.353.1527843957857; Fri, 01 Jun 2018 02:05:57 -0700 (PDT) Received: from baolinwangubtpc.spreadtrum.com ([117.18.48.102]) by smtp.gmail.com with ESMTPSA id a4-v6sm89505351pfj.19.2018.06.01.02.05.55 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 01 Jun 2018 02:05:57 -0700 (PDT) From: Baolin Wang To: ohad@wizery.com, bjorn.andersson@linaro.org, broonie@kernel.org Cc: baolin.wang@linaro.org, linux-spi@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] spi: sprd: Change to use devm_hwspin_lock_request_specific() Date: Fri, 1 Jun 2018 17:04:55 +0800 Message-Id: <7bfce450d511115159e38d860318c6bd2216808a.1527843425.git.baolin.wang@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1be6adeb558fada77de79a40cd5ef7dc2719c945.1527843425.git.baolin.wang@linaro.org> References: <1be6adeb558fada77de79a40cd5ef7dc2719c945.1527843425.git.baolin.wang@linaro.org> In-Reply-To: <1be6adeb558fada77de79a40cd5ef7dc2719c945.1527843425.git.baolin.wang@linaro.org> References: <1be6adeb558fada77de79a40cd5ef7dc2719c945.1527843425.git.baolin.wang@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Change to use devm_hwspin_lock_request_specific() instead of freeing the hwlock explicitly when unbound the device. Signed-off-by: Baolin Wang --- drivers/spi/spi-sprd-adi.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) -- 1.7.9.5 diff --git a/drivers/spi/spi-sprd-adi.c b/drivers/spi/spi-sprd-adi.c index d8d5e2f..6fb5c0c 100644 --- a/drivers/spi/spi-sprd-adi.c +++ b/drivers/spi/spi-sprd-adi.c @@ -465,7 +465,7 @@ static int sprd_adi_probe(struct platform_device *pdev) goto put_ctlr; } - sadi->hwlock = hwspin_lock_request_specific(ret); + sadi->hwlock = devm_hwspin_lock_request_specific(&pdev->dev, ret); if (!sadi->hwlock) { ret = -ENXIO; goto put_ctlr; @@ -483,7 +483,7 @@ static int sprd_adi_probe(struct platform_device *pdev) ret = devm_spi_register_controller(&pdev->dev, ctlr); if (ret) { dev_err(&pdev->dev, "failed to register SPI controller\n"); - goto free_hwlock; + goto put_ctlr; } sadi->restart_handler.notifier_call = sprd_adi_restart_handler; @@ -491,13 +491,11 @@ static int sprd_adi_probe(struct platform_device *pdev) ret = register_restart_handler(&sadi->restart_handler); if (ret) { dev_err(&pdev->dev, "can not register restart handler\n"); - goto free_hwlock; + goto put_ctlr; } return 0; -free_hwlock: - hwspin_lock_free(sadi->hwlock); put_ctlr: spi_controller_put(ctlr); return ret; @@ -509,7 +507,6 @@ static int sprd_adi_remove(struct platform_device *pdev) struct sprd_adi *sadi = spi_controller_get_devdata(ctlr); unregister_restart_handler(&sadi->restart_handler); - hwspin_lock_free(sadi->hwlock); return 0; }