From patchwork Sat Jun 2 00:03:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 137579 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp1557029lji; Fri, 1 Jun 2018 17:05:53 -0700 (PDT) X-Google-Smtp-Source: ADUXVKK5eo9ixaWYpviyFTSs01zHt28iU0iRpIVazDcYxrfiYrgl31w28g8isY8Y+7E+vWj3fvHt X-Received: by 2002:a63:a513:: with SMTP id n19-v6mr10259630pgf.381.1527897953701; Fri, 01 Jun 2018 17:05:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527897953; cv=none; d=google.com; s=arc-20160816; b=bLsem9k8GqiXbgOHvQ31kbcW4Co06A3tDIs5GirSeERq5D6gGX5I5pQCTbpP0y8Wp4 2SOSuqefaxDjt7RLbcF8rPM75m4uuRl8N4AdVpnmaHFt3EMS/gY0XvNOOblrvEe4RbRV mfUs98takVfjqgMxDfD8ejblX65dE/0JhrSiRJAQ1RzyijnPS4qHQAoDfyVSCZhSS2mc UnFnq9yPIyu2R+3Yxou813VXuOapmPrQ+NwdfERN/eE8Oe4TKTsWQ7MSPEBv4bFXZ7sd IuXQlj+vEYck5L63hhBt5zOc1GuI5oJjKeC4isxzexk0j5klz3RZ/46U28ESHmRcGTwq 6cjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=dqDMtZPIn3oZZHWSSyJYqEnQXRDAsQqM0Y6vaBL5ecY=; b=C6BGnp5owj2VqkJ1hX0Ly61uEDTEgfyANxU0R7Q9PgGe1XhyWTFbiy1BQa3Ps/+uOb Z2WcxCf4XoIwcfH396t2oTfmu1B6VGK+VKrpA9gbqI3P53hqYG1lQ+S21xV9DHtNE76E Kfpg35MHhUYqhnbLB+ghbe3A6cHUmgK8aecGY79DrGBMJt9N5PRujFcgXpSr+wTWxlJ/ QZofmpFCEkoZ2VVxXqRrf7Qu3PgRxtr+Ajc8lvg3THoXKJxF1bSRTmFM0NMkyC8DPIiR RAWXnp3TcTnKV0vemrXtTvAwvWtxjopuZ906u5fOSZgbnsgJvrTfioUQg4Pm7rX8hdXD mPpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=L6/nnov5; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r125-v6si3698528pfc.202.2018.06.01.17.05.53; Fri, 01 Jun 2018 17:05:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=L6/nnov5; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751135AbeFBAFv (ORCPT + 5 others); Fri, 1 Jun 2018 20:05:51 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:32803 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750974AbeFBAFu (ORCPT ); Fri, 1 Jun 2018 20:05:50 -0400 Received: by mail-wr0-f193.google.com with SMTP id k16-v6so10527950wro.0 for ; Fri, 01 Jun 2018 17:05:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=wn6Agb+5TcRSiwYPl38oPGp/MMRVEjg46nuQ2bUWxvs=; b=L6/nnov5hAqpymvODyVQc6LXrpOPxATC5o+9BLoSixUzidmwo1iB6MQNb+sLZqqI8M Z/bjTTUyFC02YpgnSE4sHeSlivT1VOhVeaBbQ1x5JrDyVpXsmPMJI67wY/S92On3TEp+ wwTtXFC+Ms2RPWBMtP43F5TNhK4CuSyxVPJ6s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=wn6Agb+5TcRSiwYPl38oPGp/MMRVEjg46nuQ2bUWxvs=; b=tN+cZD559dAFJXGFbSTnjs15dIvC4eAW6qsMblQJGwpnR8Xg9/Snyshco31jAw6Ce7 UP7fpqsvq008kVXDaFt9cV1Pv+cLqQ1j3QSL43NSn+8Eb+V5oPmjxIkrBZjoH2rcsvkc 8efB+JsHl7r9NFOxx7+xz+wYHxRRRc/ZkLVh9UAEjhosxjPqwcYJQVAG3AldxIkSdNgs Avs4Z8lVk7KE9MH8r6RFtJgxS4jv2AMXjPpcHx+wqTzQ3r69wArcSOgKrtugJkUpM+Qd IYpGd+XdYM0vfCAp7sOP4M5zNbLhbAkPtJixkKsQYRSTl/kZxQrDjYJCSSAYRCx1uMJk zfxA== X-Gm-Message-State: ALKqPwcpBuEgv4TB7Rr2IVEAqfWM8nEAf/ttrNjtPrMDf8sfsdkMrJmW +ht9Ze8qNW6CF2bEPW4EwGxxMA== X-Received: by 2002:adf:a54a:: with SMTP id j10-v6mr10998126wrb.155.1527897949193; Fri, 01 Jun 2018 17:05:49 -0700 (PDT) Received: from localhost.localdomain (cpc90716-aztw32-2-0-cust92.18-1.cable.virginm.net. [86.26.100.93]) by smtp.gmail.com with ESMTPSA id e13-v6sm25626947wrm.45.2018.06.01.17.05.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 01 Jun 2018 17:05:47 -0700 (PDT) From: Srinivas Kandagatla To: robh+dt@kernel.org, frowand.list@gmail.com Cc: linux-arm-msm@vger.kernel.org, bgoswami@codeaurora.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, rohkumar@qti.qualcomm.com, Srinivas Kandagatla Subject: [PATCH v2] of: platform: stop accessing invalid dev in of_platform_device_destroy Date: Sat, 2 Jun 2018 01:03:43 +0100 Message-Id: <20180602000343.20045-1-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.16.2 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Immediately after the platform_device_unregister() the device will be cleaned up. Accessing the freed pointer immediately after that will crash the system. Found this bug when kernel is built with CONFIG_PAGE_POISONING and testing loading/unloading audio drivers in a loop on Qcom platforms. Fix this by removing accessing the dev pointer. Below is the carsh trace: Unable to handle kernel paging request at virtual address 6b6b6b6b6b6c03 Mem abort info: ESR = 0x96000021 Exception class = DABT (current EL), IL = 32 bits SET = 0, FnV = 0 EA = 0, S1PTW = 0 Data abort info: ISV = 0, ISS = 0x00000021 CM = 0, WnR = 0 [006b6b6b6b6b6c03] address between user and kernel address ranges Internal error: Oops: 96000021 [#1] PREEMPT SMP Modules linked in: CPU: 2 PID: 1784 Comm: sh Tainted: G W 4.17.0-rc7-02230-ge3a63a7ef641-dirty #204 Hardware name: Qualcomm Technologies, Inc. APQ 8016 SBC (DT) pstate: 80000005 (Nzcv daif -PAN -UAO) pc : clear_bit+0x18/0x2c lr : of_platform_device_destroy+0x64/0xb8 sp : ffff00000c9c3930 x29: ffff00000c9c3930 x28: ffff80003d39b200 x27: ffff000008bb1000 x26: 0000000000000040 x25: 0000000000000124 x24: ffff80003a9a3080 x23: 0000000000000060 x22: ffff00000939f518 x21: ffff80003aa79e98 x20: ffff80003aa3dae0 x19: ffff80003aa3c890 x18: ffff800009feb794 x17: 0000000000000000 x16: 0000000000000000 x15: ffff800009feb790 x14: 0000000000000000 x13: ffff80003a058778 x12: ffff80003a058728 x11: ffff80003a058750 x10: 0000000000000000 x9 : 0000000000000006 x8 : ffff80003a825988 x7 : bbbbbbbbbbbbbbbb x6 : 0000000000000001 x5 : 0000000000000000 x4 : 0000000000000001 x3 : 0000000000000008 x2 : 0000000000000001 x1 : 6b6b6b6b6b6b6c03 x0 : 0000000000000000 Process sh (pid: 1784, stack limit = 0x (ptrval)) Call trace: clear_bit+0x18/0x2c q6afe_remove+0x20/0x38 apr_device_remove+0x30/0x70 device_release_driver_internal+0x170/0x208 device_release_driver+0x14/0x20 bus_remove_device+0xcc/0x150 device_del+0x10c/0x310 device_unregister+0x1c/0x70 apr_remove_device+0xc/0x18 device_for_each_child+0x50/0x80 apr_remove+0x18/0x20 rpmsg_dev_remove+0x38/0x68 device_release_driver_internal+0x170/0x208 device_release_driver+0x14/0x20 bus_remove_device+0xcc/0x150 device_del+0x10c/0x310 device_unregister+0x1c/0x70 qcom_smd_remove_device+0xc/0x18 device_for_each_child+0x50/0x80 qcom_smd_unregister_edge+0x3c/0x70 smd_subdev_remove+0x18/0x28 rproc_stop+0x48/0xd8 rproc_shutdown+0x60/0xe8 state_store+0xbc/0xf8 dev_attr_store+0x18/0x28 sysfs_kf_write+0x3c/0x50 kernfs_fop_write+0x118/0x1e0 __vfs_write+0x18/0x110 vfs_write+0xa4/0x1a8 ksys_write+0x48/0xb0 sys_write+0xc/0x18 el0_svc_naked+0x30/0x34 Code: d2800022 8b400c21 f9800031 9ac32043 (c85f7c22) Signed-off-by: Srinivas Kandagatla --- Changes since v1: - fixed issue while reprobing. drivers/of/platform.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) -- 2.16.2 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/of/platform.c b/drivers/of/platform.c index c00d81dfac0b..84c5c899187b 100644 --- a/drivers/of/platform.c +++ b/drivers/of/platform.c @@ -529,10 +529,13 @@ arch_initcall_sync(of_platform_default_populate_init); int of_platform_device_destroy(struct device *dev, void *data) { + struct device_node *np; + /* Do not touch devices not populated from the device tree */ if (!dev->of_node || !of_node_check_flag(dev->of_node, OF_POPULATED)) return 0; + np = dev->of_node; /* Recurse for any nodes that were treated as busses */ if (of_node_check_flag(dev->of_node, OF_POPULATED_BUS)) device_for_each_child(dev, NULL, of_platform_device_destroy); @@ -544,8 +547,8 @@ int of_platform_device_destroy(struct device *dev, void *data) amba_device_unregister(to_amba_device(dev)); #endif - of_node_clear_flag(dev->of_node, OF_POPULATED); - of_node_clear_flag(dev->of_node, OF_POPULATED_BUS); + of_node_clear_flag(np, OF_POPULATED); + of_node_clear_flag(np, OF_POPULATED_BUS); return 0; } EXPORT_SYMBOL_GPL(of_platform_device_destroy);