[v2] ASoC: dapm: delete dapm_kcontrol_data paths list before freeing it

Message ID 20180604111326.15708-1-srinivas.kandagatla@linaro.org
State New
Headers show
  • [v2] ASoC: dapm: delete dapm_kcontrol_data paths list before freeing it
Related show

Commit Message

Srinivas Kandagatla June 4, 2018, 11:13 a.m.
dapm_kcontrol_data is freed as part of dapm_kcontrol_free(), leaving the
paths pointer dangling in the list.

This leads to system crash when we try to unload and reload sound card.
I hit this bug during ADSP crash/reboot test case on Dragon board DB410c.

Without this patch, on SLAB Poisoning enabled build, kernel crashes with
"BUG kmalloc-128 (Tainted: G        W        ): Poison overwritten"

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

Changes since v1:
	-remove unnecessary very long bug trace.

 sound/soc/soc-dapm.c | 2 ++
 1 file changed, 2 insertions(+)


To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index 1e9a36389667..36a39ba30226 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -433,6 +433,8 @@  static int dapm_kcontrol_data_alloc(struct snd_soc_dapm_widget *widget,
 static void dapm_kcontrol_free(struct snd_kcontrol *kctl)
 	struct dapm_kcontrol_data *data = snd_kcontrol_chip(kctl);
+	list_del(&data->paths);