From patchwork Tue Jun 5 04:47:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 137665 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp491324lji; Mon, 4 Jun 2018 21:56:54 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKYMHkG7BC+7/cp9Ysckg1e9uEnHGizpkJ3LJugKdpF4XAF/4rZ8hHwcWeHchd2L3wUD+cM X-Received: by 2002:a17:902:bd87:: with SMTP id q7-v6mr6962284pls.147.1528174614558; Mon, 04 Jun 2018 21:56:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528174614; cv=none; d=google.com; s=arc-20160816; b=YMtjKsqSM4q59e4GvlonfZ5oBVgTxb2spzefdjqF8Kxk42fIFRnW4rMRnJKe54/Aby oTqaZvBSB5fy1S1T0qdvrBC62VMmho8ZNH78t/4az4e1WB3gV7szKt3GgzbZ5w7KbS5r ZMBtE1d7S0ErMZRGcBCaoYYQe/dr2sR6/tzVE0Yja5YwqCxWxf3YyrQ/Th2euyrVToMt 2zBpjcw4WC9vUpvFFAOYqmqEbieksdfzKZCYh8/7WqnAfeOCNfG6LB9GjsdJgp0cFrSa c/qxT+C6fK2kq2of8z4hYWD1l6n5evoJF7E+7g+KJqXj6E4o9xkW3hqUzrPvnL1avKn+ g5Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=b3fjp616SQYNxvOacxc+2lA78+Lk79OQL6fooZqPMQ0=; b=sABbzGKgIj4tRc61JdlFn+gJUyONYw4yhZwYpErQEnmDEjNASozd017elKT5PADZ3n ukpM42mLYr33ISDHPLcKvDJj4JA0IDwY3gMhoKAGGtBLuLUW5C08LTT0S+UiA7ssZbOq jpfMrtp/+xsr7aBZMMyI93EjNMJFhazjqMVgKdgLA6cFZAwakcpD3W5EgkqnJUlkKmE5 G5CCDUcl6vaShRziApUh3IHz7tFBcCSO/Ti6zO2oF05F5lMxbJ7arvw2ojM9jlVBZYNB VKY/Ti/ADHqd6geUl+wa+sPX59nd8WZPBQsNFpC4VmOe3KV7m0R3CWav3iykCks2Yr8A vsVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=LCG1jzfx; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q2-v6si48205436plh.136.2018.06.04.21.56.54; Mon, 04 Jun 2018 21:56:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=LCG1jzfx; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751477AbeFEE4x (ORCPT + 5 others); Tue, 5 Jun 2018 00:56:53 -0400 Received: from mail-pl0-f67.google.com ([209.85.160.67]:40274 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751361AbeFEE4w (ORCPT ); Tue, 5 Jun 2018 00:56:52 -0400 Received: by mail-pl0-f67.google.com with SMTP id t12-v6so739816plo.7 for ; Mon, 04 Jun 2018 21:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cwf79dPZ6Mk82viwE3UOroewlvnMne770dLqXn7PpmY=; b=LCG1jzfxlS8cxnXUJxMZ/DzKUI1Zj0l1TOxtWSartnBnsQx78ei/rgBWTyHsTTdLzy 2+UIXDgAYN4beBFTzlW7/tGoMZ+sYnJfysOc7e3fwn+ecPr4ctGKpE7KWK9QVU2ZFnX/ CNX+QHkcmeOEnSH49piQB5CKQruMkptPjdJ4w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cwf79dPZ6Mk82viwE3UOroewlvnMne770dLqXn7PpmY=; b=VS9qjtNY5g1w9bvwdhMKBTNGdwhmjzYJhSotknzrPJx0KcCOe/MLIkdj1VptfL9Slu w+NB9mDnE6tpRNSQb/XUCe83Zd1jHUbnFqauE23Tksx+GMPL+ACfjVers/qegQIOT48Y XwrUA6zKeTOkb6wPVa39nEnpZnJSHOqMfRizW/cd8bcB2QOO9iYx5vUDCnYvtmKQp6G9 6HyLuKIZhTV49FisQE1qmd7VlDdstWg6J6CNUXdgAERNb7Ah5Qu0sk6uFTjNaxRp9Kd2 /UBUB9JD7TzY/KgUDuk9qcPq+ffN/yCVmfZIJoyx6HiePNNUTAwzX7t3Cp4rA4rPrvD3 FTHg== X-Gm-Message-State: ALKqPwddNLJJT4shgcDZDnFjcUMKvOBs92veDY9kmRbBFJlsxnjRlUy2 fqY13SpxnuVANAVepeOtBuvFqg== X-Received: by 2002:a17:902:8a82:: with SMTP id p2-v6mr24717641plo.244.1528174612158; Mon, 04 Jun 2018 21:56:52 -0700 (PDT) Received: from localhost ([122.172.63.23]) by smtp.gmail.com with ESMTPSA id n10-v6sm7891012pfb.27.2018.06.04.21.56.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jun 2018 21:56:51 -0700 (PDT) From: Viresh Kumar To: arm@kernel.org, Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai Cc: Viresh Kumar , Vincent Guittot , ionela.voinescu@arm.com, Daniel Lezcano , chris.redpath@arm.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH V2 1/2] arm: dts: sun8i-h3: Add missing cooling device properties for CPUs Date: Tue, 5 Jun 2018 10:17:48 +0530 Message-Id: X-Mailer: git-send-email 2.15.0.194.g9af6a3dea062 In-Reply-To: <20180601151701.sshwfdbflic6mybv@flea> References: <20180601151701.sshwfdbflic6mybv@flea> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The cooling device properties, like "#cooling-cells" and "dynamic-power-coefficient", should either be present for all the CPUs of a cluster or none. If these are present only for a subset of CPUs of a cluster then things will start falling apart as soon as the CPUs are brought online in a different order. For example, this will happen because the operating system looks for such properties in the CPU node it is trying to bring up, so that it can register a cooling device. Add such missing properties. Fix other missing properties (clocks, clock-names) as well to make it all work. Signed-off-by: Viresh Kumar --- V2: Separated patch for h3. arch/arm/boot/dts/sun8i-h3.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+) -- 2.15.0.194.g9af6a3dea062 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi index 41d57c76f290..9dff6887923c 100644 --- a/arch/arm/boot/dts/sun8i-h3.dtsi +++ b/arch/arm/boot/dts/sun8i-h3.dtsi @@ -84,21 +84,30 @@ compatible = "arm,cortex-a7"; device_type = "cpu"; reg = <1>; + clocks = <&ccu CLK_CPUX>; + clock-names = "cpu"; operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; }; cpu@2 { compatible = "arm,cortex-a7"; device_type = "cpu"; reg = <2>; + clocks = <&ccu CLK_CPUX>; + clock-names = "cpu"; operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; }; cpu@3 { compatible = "arm,cortex-a7"; device_type = "cpu"; reg = <3>; + clocks = <&ccu CLK_CPUX>; + clock-names = "cpu"; operating-points-v2 = <&cpu0_opp_table>; + #cooling-cells = <2>; }; };