From patchwork Tue Jun 5 11:44:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 137715 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp851920lji; Tue, 5 Jun 2018 04:45:08 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKze0NoJvTuHF/8BsojvibhFMcfHIbs7OCc2LWMUhlVq2+SceljnuKnvE9WPMzCmkLNAlaT X-Received: by 2002:a62:5004:: with SMTP id e4-v6mr24895398pfb.71.1528199108112; Tue, 05 Jun 2018 04:45:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528199108; cv=none; d=google.com; s=arc-20160816; b=uWoh71r0z0qANCOvqC8bLAh/dGQEWLE0fvZBvRS/O3nxr67s2WWxEdywIzg8WZu08B iTlxy5ZC+7FfSFBu1bqRyYUJ4VLzBR8BIqAb30tyOqXgsxsFasM8/EPcz/+PSHTnhx9U 5DHC+99ZUPUF7Tvp+UriiaPnaxn4gJOSqDH3xNrgSBEETklqvH63MfpNyw6RtvkqbvVl z10caI1jCMJHN+k107eE5WEI1x+0aKUrYCbQI79dZs7LhW3X1gpno4cnYP9lfgJfVZLu K236twmv7U8+Ri6GGq9VxdfXUg8CaLB0q3xEpo5HxHHnHlEZpc/WXvs+SPzOGzen7wQb KKzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=1rHB/7LgKd62+DjMcFRugBLNYoun2e3saKaGSNr4zbc=; b=qnZhXZwnQhupAG6b9Hqknx1p4HmDbVXIKN+i4LcMU+cN2mvzhqpRMLP16bPongV4x4 xRr8c8ht/NP7MhdhAfSOtgZqlaHYFKyQzTgUpic3CfOTSH97HsGnT63Z51W0PVCCbVgq SSZsJfi7F6G7IJNzpsQC5WcLVwgbgEAHg/GmPawNFYOAj1NCX6CzPXV3WhDcZcnyYW50 jqJFEIsKV/KtASIkh069vtMmwsbLZoWVvBSlvDIQOz/UzeIMuNnfCClito7hbZRxqH18 gANgO5Bj+GnfXh6+naC4h5P+pvy/1n2uPYfnj9nOThd4qGQ01Eixoit8aOQrYKtIH8YT A4tg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u189-v6si22777388pgd.260.2018.06.05.04.45.02; Tue, 05 Jun 2018 04:45:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751721AbeFELpA (ORCPT + 10 others); Tue, 5 Jun 2018 07:45:00 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:35525 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751622AbeFELpA (ORCPT ); Tue, 5 Jun 2018 07:45:00 -0400 Received: from wuerfel.lan ([95.208.111.237]) by mrelayeu.kundenserver.de (mreue005 [212.227.15.129]) with ESMTPA (Nemesis) id 0MR93L-1frHuz39l1-00UXjG; Tue, 05 Jun 2018 13:44:54 +0200 From: Arnd Bergmann To: "Rafael J. Wysocki" , Viresh Kumar Cc: Arnd Bergmann , Ilia Lin , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] cpufreq: kryo: allow building as a loadable module Date: Tue, 5 Jun 2018 13:44:24 +0200 Message-Id: <20180605114453.1381941-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:57oeEaoE/TbPh/0dlaPflkcfFNDoLJDYCe39vyxhDNMXhYQ8z2G ePuq7sirlnx72JycXkgqQ4ARmhO/C6AiRGBzd/AeoAviZSqmiwhslA0SqOGIVegPVUYMwTQ I35KdQlWDcr5grWU43whyOcjcPbWga++nQV9cMunv6yu5uoI/NvScB1RhY/t8vKNfAyIbAz H8dhlP5RuE9MgQCP2Vr6g== X-UI-Out-Filterresults: notjunk:1; V01:K0:5nrw9W4fa2A=:yAHiVx//zvMMRoNRNyV9CK Z2snSL36sFna4psMvjUiRi/7lllDRUActZ81k7iSq9L8fW+7cNigDpO42C13m5ARexgO35ZqI 0nHOPzAmr5k/WAhNaYsG0RjedxXwVsVwwym+neN/0/qEKamwsXfRKnRfzzaFxJnSuB/kRi9Ng GXTKK9h0jiV7bhT0M8CSWHITTfnNOQcL/WgYZuI0yI0XyYS5jzB27/fOnb2fdFgl/h3WxzfEi zWrg0u7PkfQ+iXtBp5yJvIoh8IhXm0YQcqjuZpiyCB4wXMak8GATq6qadrgS2d/JL5/PQ736x KMgddP8eaS/fiDtDoYdlTykVeYCBF+bQQ1aDoWe7Y4ixXMYXRh9j1p+432lXOJYc8xCUK8vBG qI/V/Jo9XrWCe8E+hGk78sIwVYvnQd9g6ZloDHDGEy1GNQtJC+TV3xBZ4XIYHaDDAI86IiQNu 7XCHwsTyHrcaIk95g4JDhVKSSWi5OBRHx1sKBV1ALmkKnHZEdWqxLYqVDZH97MGEJ54DOBArg hq3MqLXr7DcojOEVYzeY4jf4ycEYiQYYG5ECt/l5/CmWlwOUosCrLKBhIuPsLJra0hlG1ls3a 9s1NtgXG+e1qUHiS+PhfuVZJ/ZP5lT7PrG4ghIpbW/DKtz7Q0RuhzwMLanwdZNTbMQUw+B0Mr BiGARe9+G4zLVy7Pv479CuHwP3REFCYQh/BSrMVPJNWnpXgerEgTWgYHmqQR0YSHUVrw= Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Building the kryo cpufreq driver while QCOM_SMEM is a loadable module results in a link error: drivers/cpufreq/qcom-cpufreq-kryo.o: In function `qcom_cpufreq_kryo_probe': qcom-cpufreq-kryo.c:(.text+0xbc): undefined reference to `qcom_smem_get' The problem is that Kconfig ignores interprets the dependency as met when the dependent symbol is a 'bool' one. By making it 'tristate', it will be forced to be a module here, which builds successfully. Fixes: 46e2856b8e18 ("cpufreq: Add Kryo CPU scaling driver") Signed-off-by: Arnd Bergmann --- drivers/cpufreq/Kconfig.arm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0 Acked-by: Viresh Kumar diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index c7ce928fbf1f..52f5f1a2040c 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm @@ -125,7 +125,7 @@ config ARM_OMAP2PLUS_CPUFREQ default ARCH_OMAP2PLUS config ARM_QCOM_CPUFREQ_KRYO - bool "Qualcomm Kryo based CPUFreq" + tristate "Qualcomm Kryo based CPUFreq" depends on ARM64 depends on QCOM_QFPROM depends on QCOM_SMEM