[edk2,edk2-platforms,1/3] Platform/Socionext/DeveloperBox: add support for persistent capsules

Message ID 20180607113203.27606-2-ard.biesheuvel@linaro.org
State New
Headers show
Series
  • DeveloperBox capsule update changes for progress reporting
Related show

Commit Message

Ard Biesheuvel June 7, 2018, 11:32 a.m.
Add support for PersistAcrossReset capsules, by setting the associated
PCD, and by enabling the warm reboot implementation that reenters PEI
with interrupts, caches and MMU disabled.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

---
 Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

-- 
2.17.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm June 15, 2018, 5:22 p.m. | #1
On Thu, Jun 07, 2018 at 01:32:01PM +0200, Ard Biesheuvel wrote:
> Add support for PersistAcrossReset capsules, by setting the associated

> PCD, and by enabling the warm reboot implementation that reenters PEI

> with interrupts, caches and MMU disabled.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>


Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>


Feel free to push this one separately once everything is in place to
do so.

> ---

>  Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 7 ++-----

>  1 file changed, 2 insertions(+), 5 deletions(-)

> 

> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc

> index 300e3fd656a5..1476257acce1 100644

> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc

> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc

> @@ -226,11 +226,8 @@ [PcdsFeatureFlag]

>    gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE

>    gEfiMdePkgTokenSpaceGuid.PcdUgaConsumeSupport|FALSE

>  

> -  #

> -  # This requires support in ARM Trusted Firmware and SCP for warm reset,

> -  # so disable for now

> -  #

> -  gEfiMdeModulePkgTokenSpaceGuid.PcdSupportUpdateCapsuleReset|FALSE

> +  gArmTokenSpaceGuid.PcdArmReenterPeiForCapsuleWarmReboot|TRUE

> +  gEfiMdeModulePkgTokenSpaceGuid.PcdSupportUpdateCapsuleReset|TRUE

>  

>    # needed for NFIT tables installed by RamDiskDxe

>    gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE

> -- 

> 2.17.0

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ard Biesheuvel June 18, 2018, 6:43 a.m. | #2
On 15 June 2018 at 19:22, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Thu, Jun 07, 2018 at 01:32:01PM +0200, Ard Biesheuvel wrote:

>> Add support for PersistAcrossReset capsules, by setting the associated

>> PCD, and by enabling the warm reboot implementation that reenters PEI

>> with interrupts, caches and MMU disabled.

>>

>> Contributed-under: TianoCore Contribution Agreement 1.1

>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

>

> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

>


Thanks.

> Feel free to push this one separately once everything is in place to

> do so.

>


Pushed as f65939a9d98b283351fa5b9d62a8d49c42143b4f

>> ---

>>  Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 7 ++-----

>>  1 file changed, 2 insertions(+), 5 deletions(-)

>>

>> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc

>> index 300e3fd656a5..1476257acce1 100644

>> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc

>> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc

>> @@ -226,11 +226,8 @@ [PcdsFeatureFlag]

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE

>>    gEfiMdePkgTokenSpaceGuid.PcdUgaConsumeSupport|FALSE

>>

>> -  #

>> -  # This requires support in ARM Trusted Firmware and SCP for warm reset,

>> -  # so disable for now

>> -  #

>> -  gEfiMdeModulePkgTokenSpaceGuid.PcdSupportUpdateCapsuleReset|FALSE

>> +  gArmTokenSpaceGuid.PcdArmReenterPeiForCapsuleWarmReboot|TRUE

>> +  gEfiMdeModulePkgTokenSpaceGuid.PcdSupportUpdateCapsuleReset|TRUE

>>

>>    # needed for NFIT tables installed by RamDiskDxe

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE

>> --

>> 2.17.0

>>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
index 300e3fd656a5..1476257acce1 100644
--- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
+++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
@@ -226,11 +226,8 @@  [PcdsFeatureFlag]
   gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE
   gEfiMdePkgTokenSpaceGuid.PcdUgaConsumeSupport|FALSE
 
-  #
-  # This requires support in ARM Trusted Firmware and SCP for warm reset,
-  # so disable for now
-  #
-  gEfiMdeModulePkgTokenSpaceGuid.PcdSupportUpdateCapsuleReset|FALSE
+  gArmTokenSpaceGuid.PcdArmReenterPeiForCapsuleWarmReboot|TRUE
+  gEfiMdeModulePkgTokenSpaceGuid.PcdSupportUpdateCapsuleReset|TRUE
 
   # needed for NFIT tables installed by RamDiskDxe
   gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE