[2/3] drm/exynos: Suspend/resume display pipeline as early/late as possible

Message ID 20180611122500.11587-3-m.szyprowski@samsung.com
State New
Headers show
  • Exynos DRM: cleanup of suspend/resume code
Related show

Commit Message

Marek Szyprowski June 11, 2018, 12:24 p.m.
In the current code, exynos_drm_suspend() function is called after all
real devices (CRTCs, Encoders, etc) are suspended, because Exynos DRM
virtual platform device is created as last device in the system (as
a part of DRM registration). None of the devices for real hardware
modules has its own system suspend/resume callbacks, so it doesn't
change any order of the executed code, but it has a side-effect:
runtime PM callbacks for real devices are not executed, because those
devices are considered by PM core as already suspended. This might
cause issues on boards with complex pipelines, where something
depends on the runtime PM state of the given device.

To ensure that exynos_drm_suspend() is called before any suspend
callback from the real devices, assign it to .prepare callback. Same
for exynos_drm_resume(), using .complete callback ensures that all
real devices have been resumed when calling it.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>

 drivers/gpu/drm/exynos/exynos_drm_drv.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)


To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
index c0b4a03ae1b6..d98bc15d490d 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
@@ -147,7 +147,6 @@  static struct drm_driver exynos_drm_driver = {
 	.minor	= DRIVER_MINOR,
 static int exynos_drm_suspend(struct device *dev)
 	struct drm_device *drm_dev = dev_get_drvdata(dev);
@@ -170,7 +169,7 @@  static int exynos_drm_suspend(struct device *dev)
 	return 0;
-static int exynos_drm_resume(struct device *dev)
+static void exynos_drm_resume(struct device *dev)
 	struct drm_device *drm_dev = dev_get_drvdata(dev);
 	struct exynos_drm_private *private;
@@ -182,13 +181,11 @@  static int exynos_drm_resume(struct device *dev)
 	drm_atomic_helper_resume(drm_dev, private->suspend_state);
-	return 0;
 static const struct dev_pm_ops exynos_drm_pm_ops = {
-	SET_SYSTEM_SLEEP_PM_OPS(exynos_drm_suspend, exynos_drm_resume)
+	.prepare = exynos_drm_suspend,
+	.complete = exynos_drm_resume,
 /* forward declaration */