From patchwork Tue Jun 12 00:51:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 138271 Delivered-To: patch@linaro.org Received: by 2002:a2e:970d:0:0:0:0:0 with SMTP id r13-v6csp4700735lji; Mon, 11 Jun 2018 17:57:41 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIlQQ9JGosTMjq2lNq/hsm3uYeRuv7kCJ+iWehqvcQCT2vwPXY8tT9679R+NLxfVrJ+UsVt X-Received: by 2002:a37:ddce:: with SMTP id u75-v6mr1366704qku.147.1528765061190; Mon, 11 Jun 2018 17:57:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528765061; cv=none; d=google.com; s=arc-20160816; b=PGQ6oeMX8FmYdMd6tLgp7s62oVpFeEhqfbsiAQjqvF1b2okxcWIe5Q2M5RsxytYV8i 0FTrg47NWUYXgDS527Uk+VNRwDwV799IC0HjoxqhnsL9k12drWXYvWM4vce0rFzQT9sb WZTV/3FaNH9NTPS2w6Yr0yCvNZmng4gxjUSa6YCX+NRzHzEaRClkxKmAAsyALegskB/b a55BQrXieZyQZSwwzPYVa2iLCBd8kv2fMH+NO0eLl2e7r3RJL803VwzTlq0zop3QrH9e 3lUEb0nF22FhOCeYPimHdM5o1I3XCZOuo5I8nV/twK6yi++9W23XDoz/RrdZO8+eaxz1 r4aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=hH8QigC+q35bIyhukhRUrE8DEOH4jeKJ9AJrWVs2Mm8=; b=qaRqjQ1ArPc+UCSKFsVHqBKfFBYYgU6u5udgBPs7ZRO2Wfh73dirIyMPUgVYvQ7wPj JYgxZ8TmQ0qTNGiWldYIBX/TtJZ2/qMTcLC3eGdDjsX4THJLTZbU87S4BE8tKYJQWYwe 3ckF1gjLqk7TPU03irYSl5eVCftN0BJa63lJFFS/m3noQVbKmV3jc61lOp1lT4xXsA2g V18KJQZYDvBqlDbGJLs124BhYl4HMj2xLjnPK42LJPolSMPttcHZ4FAzx/Xaolzv+VLf Dej1/QhLEF4XkmQjYdi4L2xFz4CtTsUPoiYMZp8ATdv+zN2bxB7qbeT6OQYpJQ1siICn 5Q+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=eFvYSdPj; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id 7-v6si2451840qvd.268.2018.06.11.17.57.41 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 11 Jun 2018 17:57:41 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=eFvYSdPj; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:52030 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSXcy-0001Ii-Mo for patch@linaro.org; Mon, 11 Jun 2018 20:57:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59274) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSXXZ-00051u-79 for qemu-devel@nongnu.org; Mon, 11 Jun 2018 20:52:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSXXW-0007KG-Tt for qemu-devel@nongnu.org; Mon, 11 Jun 2018 20:52:05 -0400 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]:42170) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fSXXW-0007Ji-O3 for qemu-devel@nongnu.org; Mon, 11 Jun 2018 20:52:02 -0400 Received: by mail-pf0-x244.google.com with SMTP id w7-v6so11133547pfn.9 for ; Mon, 11 Jun 2018 17:52:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hH8QigC+q35bIyhukhRUrE8DEOH4jeKJ9AJrWVs2Mm8=; b=eFvYSdPjuROSPBOJO+pCQg2SxeJJZzMv+ZFvbUlv3epR9lP/Mw7DCr9KPZssxGcLeR CUHUXbdZcClAOfWdMaFxVPCFmrCSuKdSAiqFIMwzQZ5h83ckz6CcFAhgCUhCFfejccnP xhwEMLfPN4ev97vWzLfQ5Ie4ViQCiDQuFxHp8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hH8QigC+q35bIyhukhRUrE8DEOH4jeKJ9AJrWVs2Mm8=; b=U7UrwgNr/NhR1L3uDXYsv8JGfzI22XcCgJEf9tIxEjjJdko4C1iuad/OGryxq8k3KB IFn/bZytkVOpuOoI3rGNjbVgkzV3SwGieXRJ3tvoNP9FXQwl5a7FN0iuBwX7z5mGrFfa QgtC8F7Sn9LHB/nxTZahfKhbavFQ+Z27k5SrfGl6EHMWbkKn+xmMihippYMStslQks91 H6RAYunuwalwS8UQVKROVfyCgAb4rIVDQ6LZhKmYxcCgufcV+HECX4oLfZKLMufmK9lA Dg5OMG0zyIg/e1JvnL2yT9PzDXuMG5WrUsiTxqXwENwHCVN7NQSuuZIagDYEEvJZENct HoxQ== X-Gm-Message-State: APt69E2zxS0+h/FOz0n0c3YbtUq8Bz130K9XwTV+IDUKTFPMzmHEIayL GYc9gilFoVWrGefGZgLSi3kYqlHux6A= X-Received: by 2002:a63:b956:: with SMTP id v22-v6mr1217179pgo.438.1528764721413; Mon, 11 Jun 2018 17:52:01 -0700 (PDT) Received: from cloudburst.twiddle.net (rrcs-173-198-77-219.west.biz.rr.com. [173.198.77.219]) by smtp.gmail.com with ESMTPSA id l26-v6sm43362802pgn.55.2018.06.11.17.51.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Jun 2018 17:52:00 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 11 Jun 2018 14:51:31 -1000 Message-Id: <20180612005145.3375-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180612005145.3375-1-richard.henderson@linaro.org> References: <20180612005145.3375-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c00::244 Subject: [Qemu-devel] [PATCH v3 05/19] linux-user: Remove DEBUG X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, laurent@vivier.eu Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" This is redundant with both -strace and actual tracing. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Laurent Vivier Signed-off-by: Richard Henderson --- linux-user/syscall.c | 10 ---------- 1 file changed, 10 deletions(-) -- 2.17.1 diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 7b9ac3b408..c212149245 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -163,7 +163,6 @@ * (The one remaining unallocated bit is 0x1000 which used to be CLONE_PID.) */ -//#define DEBUG /* Define DEBUG_ERESTARTSYS to force every syscall to be restarted * once. This exercises the codepaths for restart. */ @@ -5777,9 +5776,6 @@ static abi_long do_ioctl(int fd, int cmd, abi_long arg) ie++; } arg_type = ie->arg_type; -#if defined(DEBUG) - gemu_log("ioctl: cmd=0x%04lx (%s)\n", (long)cmd, ie->name); -#endif if (ie->do_ioctl) { return ie->do_ioctl(ie, buf_temp, fd, cmd, arg); } else if (!ie->host_cmd) { @@ -7980,9 +7976,6 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, } #endif -#ifdef DEBUG - gemu_log("syscall %d", num); -#endif trace_guest_user_syscall(cpu, num, arg1, arg2, arg3, arg4, arg5, arg6, arg7, arg8); if(do_strace) print_syscall(num, arg1, arg2, arg3, arg4, arg5, arg6); @@ -12772,9 +12765,6 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, break; } fail: -#ifdef DEBUG - gemu_log(" = " TARGET_ABI_FMT_ld "\n", ret); -#endif if(do_strace) print_syscall_ret(num, ret); trace_guest_user_syscall_ret(cpu, num, ret);