rm_work: remove obsolete rm_work_all task

Message ID 20180612133705.876-1-ross.burton@intel.com
State New
Headers show
Series
  • rm_work: remove obsolete rm_work_all task
Related show

Commit Message

Ross Burton June 12, 2018, 1:37 p.m.
*all tasks have been deprecated and replaced by bitbake --runall.

Signed-off-by: Ross Burton <ross.burton@intel.com>

---
 meta/classes/rm_work.bbclass | 6 ------
 1 file changed, 6 deletions(-)

-- 
2.11.0

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Richard Purdie June 12, 2018, 2:01 p.m. | #1
On Tue, 2018-06-12 at 14:37 +0100, Ross Burton wrote:
> *all tasks have been deprecated and replaced by bitbake --runall.

> 

> Signed-off-by: Ross Burton <ross.burton@intel.com>

> ---

>  meta/classes/rm_work.bbclass | 6 ------

>  1 file changed, 6 deletions(-)

> 

> diff --git a/meta/classes/rm_work.bbclass

> b/meta/classes/rm_work.bbclass

> index 318d121d2b5..ff74d232c97 100644

> --- a/meta/classes/rm_work.bbclass

> +++ b/meta/classes/rm_work.bbclass

> @@ -115,12 +115,6 @@ do_rm_work () {

>          fi

>      done

>  }

> -do_rm_work_all () {

> -    :

> -}

> -do_rm_work_all[recrdeptask] = "do_rm_work"

> -do_rm_work_all[noexec] = "1"

> -addtask rm_work_all after before do_build

>  

>  do_populate_sdk[postfuncs] += "rm_work_populatesdk"

>  rm_work_populatesdk () {


The idea was to remove the "all" tasks which could be done
better/differently.

I think this one may be an integral part of how rm_work gets triggered
and that without this, bits of the build won't get cleaned up. The key
part is the "before do_build", i.e. its active in the taskgraph of
standard builds.

Cheers,

Richard

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/classes/rm_work.bbclass b/meta/classes/rm_work.bbclass
index 318d121d2b5..ff74d232c97 100644
--- a/meta/classes/rm_work.bbclass
+++ b/meta/classes/rm_work.bbclass
@@ -115,12 +115,6 @@  do_rm_work () {
         fi
     done
 }
-do_rm_work_all () {
-    :
-}
-do_rm_work_all[recrdeptask] = "do_rm_work"
-do_rm_work_all[noexec] = "1"
-addtask rm_work_all after before do_build
 
 do_populate_sdk[postfuncs] += "rm_work_populatesdk"
 rm_work_populatesdk () {