[1/3] net: dsa: Add DT bindings for Vitesse VSC73xx switches

Message ID 20180614123534.8063-2-linus.walleij@linaro.org
State Superseded
Headers show
Series
  • [1/3] net: dsa: Add DT bindings for Vitesse VSC73xx switches
Related show

Commit Message

Linus Walleij June 14, 2018, 12:35 p.m.
This adds the device tree bindings for the Vitesse VSC73xx
switches. We also add the vendor name for Vitesse.

Cc: devicetree@vger.kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

---
 .../bindings/net/dsa/vitesse,vsc73xx.txt      | 81 +++++++++++++++++++
 .../devicetree/bindings/vendor-prefixes.txt   |  1 +
 2 files changed, 82 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/net/dsa/vitesse,vsc73xx.txt

-- 
2.17.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Florian Fainelli June 14, 2018, 4:09 p.m. | #1
On 06/14/2018 05:35 AM, Linus Walleij wrote:
> This adds the device tree bindings for the Vitesse VSC73xx

> switches. We also add the vendor name for Vitesse.

> 

> Cc: devicetree@vger.kernel.org

> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

> ---

>  .../bindings/net/dsa/vitesse,vsc73xx.txt      | 81 +++++++++++++++++++

>  .../devicetree/bindings/vendor-prefixes.txt   |  1 +

>  2 files changed, 82 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/net/dsa/vitesse,vsc73xx.txt

> 

> diff --git a/Documentation/devicetree/bindings/net/dsa/vitesse,vsc73xx.txt b/Documentation/devicetree/bindings/net/dsa/vitesse,vsc73xx.txt

> new file mode 100644

> index 000000000000..474cdba5fa37

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/net/dsa/vitesse,vsc73xx.txt

> @@ -0,0 +1,81 @@

> +Vitess VSC73xx Switches

> +=======================

> +

> +This defines device tree bindings for the Vitesse VSC73xx switch chips.

> +The Vitesse company has been acquired by Microsemi and Microsemi in turn

> +acquired by Microchip but retains this vendor branding.

> +

> +The currently supported switch chips are:

> +Vitesse VSC7385 SparX-G5 5+1-port Integrated Gigabit Ethernet Switch

> +Vitesse VSC7388 SparX-G8 8-port Integrated Gigabit Ethernet Switch

> +Vitesse VSC7395 SparX-G5e 5+1-port Integrated Gigabit Ethernet Switch

> +Vitesse VSC7398 SparX-G8e 8-port Integrated Gigabit Ethernet Switch

> +

> +The device tree node is an SPI device so it must reside inside a SPI bus

> +device tree node, see spi/spi-bus.txt

> +

> +Required properties:

> +

> +- compatible: must be exactly one of:

> +	"vitesse,vsc7385"

> +	"vitesse,vsc7388"

> +	"vitesse,vsc7395"

> +	"vitesse,vsc7398"

> +- gpio-controller: indicates that this switch is also a GPIO controller,

> +  see gpio/


Missing reference here?

> +- #gpio-cells: this must be set to <2> and indicates that we are a twocell

> +  GPIO controller.


Should you also reference the standard binding here to interpret what
those two cells mean?

Other than that:

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>


> +

> +Optional properties:

> +

> +- reset-gpios: a handle to a GPIO line that can issue reset of the chip.

> +  It should be tagged as active low.

> +

> +Required subnodes:

> +

> +See net/dsa/dsa.txt for a list of additional required and optional properties

> +and subnodes of DSA switches.

> +

> +Examples:

> +

> +switch@0 {

> +	compatible = "vitesse,vsc7395";

> +	reg = <0>;

> +	/* Specified for 2.5 MHz or below */

> +	spi-max-frequency = <2500000>;

> +	gpio-controller;

> +	#gpio-cells = <2>;

> +

> +	ports {

> +		#address-cells = <1>;

> +		#size-cells = <0>;

> +

> +		port@0 {

> +			reg = <0>;

> +			label = "lan1";

> +		};

> +		port@1 {

> +			reg = <1>;

> +			label = "lan2";

> +		};

> +		port@2 {

> +			reg = <2>;

> +			label = "lan3";

> +		};

> +		port@3 {

> +			reg = <3>;

> +			label = "lan4";

> +		};

> +		vsc: port@6 {

> +			reg = <6>;

> +			label = "cpu";

> +			ethernet = <&gmac1>;

> +			phy-mode = "rgmii";

> +			fixed-link {

> +				speed = <1000>;

> +				full-duplex;

> +				pause;

> +			};

> +		};

> +	};

> +};

> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt

> index b5f978a4cac6..e8473894700c 100644

> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt

> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt

> @@ -385,6 +385,7 @@ v3	V3 Semiconductor

>  variscite	Variscite Ltd.

>  via	VIA Technologies, Inc.

>  virtio	Virtual I/O Device Specification, developed by the OASIS consortium

> +vitesse	Vitesse Semiconductor Corporation

>  vivante	Vivante Corporation

>  vocore VoCore Studio

>  voipac	Voipac Technologies s.r.o.

> 


-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jiri Pirko June 17, 2018, 7:40 a.m. | #2
Thu, Jun 14, 2018 at 02:35:32PM CEST, linus.walleij@linaro.org wrote:
>This adds the device tree bindings for the Vitesse VSC73xx

>switches. We also add the vendor name for Vitesse.

>

>Cc: devicetree@vger.kernel.org

>Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

>---

> .../bindings/net/dsa/vitesse,vsc73xx.txt      | 81 +++++++++++++++++++

> .../devicetree/bindings/vendor-prefixes.txt   |  1 +

> 2 files changed, 82 insertions(+)

> create mode 100644 Documentation/devicetree/bindings/net/dsa/vitesse,vsc73xx.txt

>

>diff --git a/Documentation/devicetree/bindings/net/dsa/vitesse,vsc73xx.txt b/Documentation/devicetree/bindings/net/dsa/vitesse,vsc73xx.txt

>new file mode 100644

>index 000000000000..474cdba5fa37

>--- /dev/null

>+++ b/Documentation/devicetree/bindings/net/dsa/vitesse,vsc73xx.txt

>@@ -0,0 +1,81 @@

>+Vitess VSC73xx Switches


s/Vitess/Vitesse/

[...]
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/Documentation/devicetree/bindings/net/dsa/vitesse,vsc73xx.txt b/Documentation/devicetree/bindings/net/dsa/vitesse,vsc73xx.txt
new file mode 100644
index 000000000000..474cdba5fa37
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/dsa/vitesse,vsc73xx.txt
@@ -0,0 +1,81 @@ 
+Vitess VSC73xx Switches
+=======================
+
+This defines device tree bindings for the Vitesse VSC73xx switch chips.
+The Vitesse company has been acquired by Microsemi and Microsemi in turn
+acquired by Microchip but retains this vendor branding.
+
+The currently supported switch chips are:
+Vitesse VSC7385 SparX-G5 5+1-port Integrated Gigabit Ethernet Switch
+Vitesse VSC7388 SparX-G8 8-port Integrated Gigabit Ethernet Switch
+Vitesse VSC7395 SparX-G5e 5+1-port Integrated Gigabit Ethernet Switch
+Vitesse VSC7398 SparX-G8e 8-port Integrated Gigabit Ethernet Switch
+
+The device tree node is an SPI device so it must reside inside a SPI bus
+device tree node, see spi/spi-bus.txt
+
+Required properties:
+
+- compatible: must be exactly one of:
+	"vitesse,vsc7385"
+	"vitesse,vsc7388"
+	"vitesse,vsc7395"
+	"vitesse,vsc7398"
+- gpio-controller: indicates that this switch is also a GPIO controller,
+  see gpio/
+- #gpio-cells: this must be set to <2> and indicates that we are a twocell
+  GPIO controller.
+
+Optional properties:
+
+- reset-gpios: a handle to a GPIO line that can issue reset of the chip.
+  It should be tagged as active low.
+
+Required subnodes:
+
+See net/dsa/dsa.txt for a list of additional required and optional properties
+and subnodes of DSA switches.
+
+Examples:
+
+switch@0 {
+	compatible = "vitesse,vsc7395";
+	reg = <0>;
+	/* Specified for 2.5 MHz or below */
+	spi-max-frequency = <2500000>;
+	gpio-controller;
+	#gpio-cells = <2>;
+
+	ports {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		port@0 {
+			reg = <0>;
+			label = "lan1";
+		};
+		port@1 {
+			reg = <1>;
+			label = "lan2";
+		};
+		port@2 {
+			reg = <2>;
+			label = "lan3";
+		};
+		port@3 {
+			reg = <3>;
+			label = "lan4";
+		};
+		vsc: port@6 {
+			reg = <6>;
+			label = "cpu";
+			ethernet = <&gmac1>;
+			phy-mode = "rgmii";
+			fixed-link {
+				speed = <1000>;
+				full-duplex;
+				pause;
+			};
+		};
+	};
+};
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
index b5f978a4cac6..e8473894700c 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -385,6 +385,7 @@  v3	V3 Semiconductor
 variscite	Variscite Ltd.
 via	VIA Technologies, Inc.
 virtio	Virtual I/O Device Specification, developed by the OASIS consortium
+vitesse	Vitesse Semiconductor Corporation
 vivante	Vivante Corporation
 vocore VoCore Studio
 voipac	Voipac Technologies s.r.o.